From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2ED7EA046B for ; Wed, 26 Jun 2019 09:08:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 266701B952; Wed, 26 Jun 2019 09:08:20 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E31085B34 for ; Wed, 26 Jun 2019 09:08:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 00:08:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,418,1557212400"; d="scan'208";a="155775914" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga008.jf.intel.com with ESMTP; 26 Jun 2019 00:08:17 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Jun 2019 00:08:17 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Jun 2019 00:08:16 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.87]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Wed, 26 Jun 2019 15:08:14 +0800 From: "Tu, Lijuan" To: "thaq@marvell.com" , "dts@dpdk.org" CC: "fmasood@marvell.com" , "avijay@marvell.com" Thread-Topic: [dts] [PATCH] tests/TestSuite_vlan_ethertype_config.py: Added condition check to selected "tpids" based on cards. Thread-Index: AQHVJOXDSAZJwrMUSEW8lXG3m6102aatkgcA Date: Wed, 26 Jun 2019 07:08:14 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAC4FA4@SHSMSX101.ccr.corp.intel.com> References: <1560759661-8842-1-git-send-email-thaq@marvell.com> In-Reply-To: <1560759661-8842-1-git-send-email-thaq@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDkzZmI3ZGMtOTlmMi00YmQ0LThhMDItNDMxMDEwN2ZkMDcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUlUeFFuSGg2ekJwTmZ3Qys3ZUI3bzc5MG1TbEVuSTJJT0xoUm5OWjVKN2l5K2F1UGVObXdQSGk2eG1mdnRcL3IifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/TestSuite_vlan_ethertype_config.py: Added condition check to selected "tpids" based on cards. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of thaq@marvell.com > Sent: Monday, June 17, 2019 4:21 PM > To: dts@dpdk.org > Cc: fmasood@marvell.com; avijay@marvell.com; Thanseerulhaq > > Subject: [dts] [PATCH] tests/TestSuite_vlan_ethertype_config.py: Added > condition check to selected "tpids" based on cards. >=20 > From: Thanseerulhaq >=20 > cavium_a063 cards supports only default tpids in rx mode so added > conditon checks. > Listing "test_vlan_qinq_tpid" & test_vlan_change_tpid testcase of > vlan_ethertype_config as invalid for cavium_a063 cards. >=20 > Signed-off-by: Thanseerulhaq > --- > conf/test_case_checklist.json | 16 ++++++++++++++++ > tests/TestSuite_vlan_ethertype_config.py | 24 ++++++++++++++++++++---- > 2 files changed, 36 insertions(+), 4 deletions(-) >=20 > diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.jso= n > index 7b46bc1..1c4dc6d 100644 > --- a/conf/test_case_checklist.json > +++ b/conf/test_case_checklist.json > @@ -2103,6 +2103,7 @@ > "fortville_spirit_single", > "cavium_a034", > "cavium_a011", > + "cavium_a063" > "fortville_25g" > ], > "Target": [ > @@ -2296,5 +2297,20 @@ > "Bug ID": "", > "Comments": "the nic not support this case" > } > + ], > + "vlan_change_tpid": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > ] > } > diff --git a/tests/TestSuite_vlan_ethertype_config.py > b/tests/TestSuite_vlan_ethertype_config.py > index 684f68a..1cb1083 100644 > --- a/tests/TestSuite_vlan_ethertype_config.py > +++ b/tests/TestSuite_vlan_ethertype_config.py > @@ -198,7 +198,11 @@ class TestVlanEthertypeConfig(TestCase): > self.dut.send_expect("vlan set strip off %s" % > dutRxPortId, "testpmd> ", 20) > rx_vlans =3D [1, random_vlan, MAX_VLAN] > - tpids =3D [0x8100, 0xA100] > + # caium_a063 card support only default '0x8100' tpid in rx mode > + if self.nic =3D=3D "cavium_a063": > + tpids =3D [0x8100] > + else: > + tpids =3D [0x8100, 0xA100] > for tpid in tpids: > self.dut.send_expect("vlan set outer tpid 0x%x %s" % > (tpid, dutRxPortId), "testpmd> ") @@ -2= 26,7 +230,11 > @@ class TestVlanEthertypeConfig(TestCase): > dutRxPortId, "testpmd> ", 20) > self.dut.send_expect("start", "testpmd> ") >=20 > - tpids =3D [0x8100, 0xA100] > + # caium_a063 card support only default '0x8100' tpid in rx mode > + if self.nic =3D=3D "cavium_a063": > + tpids =3D [0x8100] > + else: > + tpids =3D [0x8100, 0xA100] > for tpid in tpids: > self.dut.send_expect("vlan set outer tpid 0x%x %s" % > (tpid, dutRxPortId), "testpmd> ") @@ -2= 54,7 +262,11 > @@ class TestVlanEthertypeConfig(TestCase): > "vlan set strip on %s" % dutRxPortId, "testpmd> ", 20) > self.dut.send_expect("start", "testpmd> ", 20) >=20 > - tpids =3D [0x8100, 0xA100] > + # caium_a063 card support only default '0x8100' tpid in rx mode > + if self.nic =3D=3D "cavium_a063": > + tpids =3D [0x8100] > + else: > + tpids =3D [0x8100, 0xA100] > for tpid in tpids: > self.dut.send_expect("vlan set outer tpid 0x%x %s" % > (tpid, dutRxPortId), "testpmd> ") @@ -2= 79,7 +291,11 > @@ class TestVlanEthertypeConfig(TestCase): > dutRxPortId, "testpmd> ", 20) > self.dut.send_expect("start", "testpmd> ") >=20 > - tpids =3D [0x8100, 0xA100] > + # caium_a063 card support only default '0x8100' tpid in rx mode > + if self.nic =3D=3D "cavium_a063": > + tpids =3D [0x8100] > + else: > + tpids =3D [0x8100, 0xA100] > for tpid in tpids: > self.dut.send_expect("vlan set outer tpid 0x%x %s" % > (tpid, dutTxPortId), "testpmd> ") > -- > 1.8.3.1