test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>
Subject: Re: [dts] [next][PATCH V1] tests/link_flowctrl add transmission packet	time and fix description issue
Date: Wed, 26 Jun 2019 08:58:20 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAC5473@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190619150450.41225-1-meijuanx.zhao@intel.com>

Merged into master

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhaomeijuan
> Sent: Wednesday, June 19, 2019 11:05 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [next][PATCH V1] tests/link_flowctrl add transmission packet
> time and fix description issue
> 
> *.add transmission packet time to synchronous etgen transmission packet
> time *.result[0] is loss packet rate, so it's not necessary to devide 100 or add
> percent
> 
> Signed-off-by: zhaomeijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_link_flowctrl.py | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py
> index 0192498..5a8833d 100644
> --- a/tests/TestSuite_link_flowctrl.py
> +++ b/tests/TestSuite_link_flowctrl.py
> @@ -121,11 +121,12 @@ class TestLinkFlowctrl(TestCase):
>          # run packet generator
>          streams = self.pktgen_helper.prepare_stream_from_tginput(tgenInput,
> 100,
>                                              None, self.tester.pktgen)
> -        result = self.tester.pktgen.measure_loss(stream_ids=streams)
> +        options = {'duration': 60}
> +        result = self.tester.pktgen.measure_loss(stream_ids=streams,
> + options=options)
> 
>          self.dut.send_expect("stop", "testpmd> ")
> 
> -        return result[0]/100
> +        return result[0]
> 
>      def get_testpmd_port_stats(self, ports):
>          """
> @@ -357,7 +358,7 @@ class TestLinkFlowctrl(TestCase):
>                                              tx_flow_control='on',
>                                              pause_frame_fwd='on')
> 
> -        self.logger.info("Packet loss: %.3f%%" % result)
> +        self.logger.info("Packet loss: %.3f" % result)
> 
>          self.verify(result <= 0.01,
>                      "Link flow control fail, the loss percent is more than 1%") @@ -
> 371,7 +372,7 @@ class TestLinkFlowctrl(TestCase):
>                                              tx_flow_control='on',
>                                              pause_frame_fwd='off')
> 
> -        self.logger.info("Packet loss: %.3f%%" % result)
> +        self.logger.info("Packet loss: %.3f" % result)
> 
>          self.verify(result <= 0.01,
>                      "Link flow control fail, the loss percent is more than 1%") @@ -
> 385,7 +386,7 @@ class TestLinkFlowctrl(TestCase):
>                                              tx_flow_control='on',
>                                              pause_frame_fwd='off')
> 
> -        self.logger.info("Packet loss: %.3f%%" % result)
> +        self.logger.info("Packet loss: %.3f" % result)
> 
>          self.verify(result <= 0.01,
>                      "Link flow control fail, the loss percent is more than 1%") @@ -
> 399,7 +400,7 @@ class TestLinkFlowctrl(TestCase):
>                                              tx_flow_control='off',
>                                              pause_frame_fwd='on')
> 
> -        self.logger.info("Packet loss: %.3f%%" % result)
> +        self.logger.info("Packet loss: %.3f" % result)
> 
>          self.verify(result >= 0.5,
>                      "Link flow control fail, the loss percent is less than 50%") @@ -
> 413,7 +414,7 @@ class TestLinkFlowctrl(TestCase):
>                                              tx_flow_control='off',
>                                              pause_frame_fwd='off')
> 
> -        self.logger.info("Packet loss: %.3f%%" % result)
> +        self.logger.info("Packet loss: %.3f" % result)
> 
>          self.verify(result >= 0.5,
>                      "Link flow control fail, the loss percent is less than 50%") @@ -
> 427,7 +428,7 @@ class TestLinkFlowctrl(TestCase):
>                                              tx_flow_control='on',
>                                              pause_frame_fwd='off')
> 
> -        self.logger.info("Packet loss: %.3f%%" % result)
> +        self.logger.info("Packet loss: %.3f" % result)
> 
>          self.verify(result <= 0.01,
>                      "Link flow control fail, the loss percent is more than 1%")
> --
> 2.17.1


      reply	other threads:[~2019-06-26  8:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19 15:04 zhaomeijuan
2019-06-26  8:58 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BAC5473@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=meijuanx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).