test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib
@ 2019-07-02  8:18 yufengmx
  2019-07-02  8:18 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message yufengmx
  2019-07-03  1:26 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib Zhang, Yuwei1
  0 siblings, 2 replies; 5+ messages in thread
From: yufengmx @ 2019-07-02  8:18 UTC (permalink / raw)
  To: dts; +Cc: yufengmx

 fix wrong output message format in verifier_result method 
 remove un-used string lib import 

yufengmx (1):
  tests/external_memory: fix wrong output message

 tests/TestSuite_external_memory.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1]tests/external_memory: fix wrong output message
  2019-07-02  8:18 [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib yufengmx
@ 2019-07-02  8:18 ` yufengmx
  2019-07-03  1:25   ` Zhang, Yuwei1
  2019-07-03  5:42   ` Tu, Lijuan
  2019-07-03  1:26 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib Zhang, Yuwei1
  1 sibling, 2 replies; 5+ messages in thread
From: yufengmx @ 2019-07-02  8:18 UTC (permalink / raw)
  To: dts; +Cc: yufengmx


fix wrong output message format in verifier_result method.
remove un-used string lib import.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_external_memory.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_external_memory.py b/tests/TestSuite_external_memory.py
index dd3c121..9a75427 100644
--- a/tests/TestSuite_external_memory.py
+++ b/tests/TestSuite_external_memory.py
@@ -35,7 +35,6 @@ DPDK Test suite.
 Test external memory.
 """
 
-import string
 import time
 import re
 import utils
@@ -136,7 +135,7 @@ class TestExternalMemory(TestCase):
         p = re.compile(r'\d+')
         result = p.findall(out)
         amount = 20 * len(self.dut_ports)
-        self.verify(str(amount) in result, "Wrong: can't get <%s> package")
+        self.verify(str(amount) in result, "Wrong: can't get <%d> package" % amount)
 
         self.dut.send_expect("quit", "#", 10)
 
-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]tests/external_memory: fix wrong output message
  2019-07-02  8:18 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message yufengmx
@ 2019-07-03  1:25   ` Zhang, Yuwei1
  2019-07-03  5:42   ` Tu, Lijuan
  1 sibling, 0 replies; 5+ messages in thread
From: Zhang, Yuwei1 @ 2019-07-03  1:25 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Mo, YufengX

Acked-by: Yuwei Zhang <yuwei1.zhang@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
Sent: Tuesday, July 2, 2019 4:18 PM
To: dts@dpdk.org
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts] [PATCH V1]tests/external_memory: fix wrong output message


fix wrong output message format in verifier_result method.
remove un-used string lib import.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_external_memory.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_external_memory.py b/tests/TestSuite_external_memory.py
index dd3c121..9a75427 100644
--- a/tests/TestSuite_external_memory.py
+++ b/tests/TestSuite_external_memory.py
@@ -35,7 +35,6 @@ DPDK Test suite.
 Test external memory.
 """
 
-import string
 import time
 import re
 import utils
@@ -136,7 +135,7 @@ class TestExternalMemory(TestCase):
         p = re.compile(r'\d+')
         result = p.findall(out)
         amount = 20 * len(self.dut_ports)
-        self.verify(str(amount) in result, "Wrong: can't get <%s> package")
+        self.verify(str(amount) in result, "Wrong: can't get <%d> package" % amount)
 
         self.dut.send_expect("quit", "#", 10)
 
-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib
  2019-07-02  8:18 [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib yufengmx
  2019-07-02  8:18 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message yufengmx
@ 2019-07-03  1:26 ` Zhang, Yuwei1
  1 sibling, 0 replies; 5+ messages in thread
From: Zhang, Yuwei1 @ 2019-07-03  1:26 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Mo, YufengX

Acked-by: Yuwei Zhang <yuwei1.zhang@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
Sent: Tuesday, July 2, 2019 4:18 PM
To: dts@dpdk.org
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib

 fix wrong output message format in verifier_result method  remove un-used string lib import 

yufengmx (1):
  tests/external_memory: fix wrong output message

 tests/TestSuite_external_memory.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]tests/external_memory: fix wrong output message
  2019-07-02  8:18 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message yufengmx
  2019-07-03  1:25   ` Zhang, Yuwei1
@ 2019-07-03  5:42   ` Tu, Lijuan
  1 sibling, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2019-07-03  5:42 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Mo, YufengX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Tuesday, July 2, 2019 4:18 PM
> To: dts@dpdk.org
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1]tests/external_memory: fix wrong output message
> 
> 
> fix wrong output message format in verifier_result method.
> remove un-used string lib import.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_external_memory.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_external_memory.py
> b/tests/TestSuite_external_memory.py
> index dd3c121..9a75427 100644
> --- a/tests/TestSuite_external_memory.py
> +++ b/tests/TestSuite_external_memory.py
> @@ -35,7 +35,6 @@ DPDK Test suite.
>  Test external memory.
>  """
> 
> -import string
>  import time
>  import re
>  import utils
> @@ -136,7 +135,7 @@ class TestExternalMemory(TestCase):
>          p = re.compile(r'\d+')
>          result = p.findall(out)
>          amount = 20 * len(self.dut_ports)
> -        self.verify(str(amount) in result, "Wrong: can't get <%s> package")
> +        self.verify(str(amount) in result, "Wrong: can't get <%d> package" %
> amount)
> 
>          self.dut.send_expect("quit", "#", 10)
> 
> --
> 1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-07-03  5:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-02  8:18 [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib yufengmx
2019-07-02  8:18 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message yufengmx
2019-07-03  1:25   ` Zhang, Yuwei1
2019-07-03  5:42   ` Tu, Lijuan
2019-07-03  1:26 ` [dts] [PATCH V1]tests/external_memory: fix wrong output message and remove un-used lib Zhang, Yuwei1

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).