From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "pvukkisala@marvell.com" <pvukkisala@marvell.com>,
"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
"fmasood@marvell.com" <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] checksum_offload: Support this test in vector mode
Date: Wed, 3 Jul 2019 09:41:33 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BADA80C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1561544021-9741-1-git-send-email-pvukkisala@marvell.com>
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Wednesday, June 26, 2019 6:14 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] checksum_offload: Support this test in vector mode
>
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
>
> Send and sniff 4 packets to support vector mode cavium HW stops
> calculating check sums upon receiving first incorrect checksum. So accept
> unknown also as bad
>
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
> tests/TestSuite_checksum_offload.py | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index db0663e..7176cb9 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -129,7 +129,7 @@ class TestChecksumOffload(TestCase):
> self.tester.scapy_foreground()
>
> for packet_type in packets_sent.keys():
> - self.tester.scapy_append('sendp([%s], iface="%s")' %
> (packets_sent[packet_type], tx_interface))
> + self.tester.scapy_append('sendp([%s], iface="%s", count=4)'
> + % (packets_sent[packet_type], tx_interface))
> self.tester.scapy_execute()
> out = self.dut.get_session_output(timeout=1)
> lines = out.split("\r\n")
> @@ -146,7 +146,10 @@ class TestChecksumOffload(TestCase):
> if (flag == 1):
> self.verify("PKT_RX_L4_CKSUM_GOOD" in line, "Packet Rx
> L4 checksum valid-flags error!")
> elif (flag == 0):
> - self.verify("PKT_RX_L4_CKSUM_BAD" in line, "Packet Rx
> L4 checksum valid-flags error!")
> + if self.nic == "cavium_a063":
> + self.verify("PKT_RX_L4_CKSUM_BAD" in line or
> "PKT_RX_L4_CKSUM_UNKNOWN" in line, "Packet Rx L4 checksum valid-flags
> error!")
> + else:
> + self.verify("PKT_RX_L4_CKSUM_BAD"
> + in line, "Packet Rx L4 checksum valid-flags error!")
> else:
> if "PKT_RX_L4_CKSUM" not in line:
> self.verify(0, "There is no L4 checksum flags appeared!")
> @@ -185,11 +188,11 @@ class TestChecksumOffload(TestCase):
>
> self.tester.send_expect("exit()", "#")
>
> - inst = self.tester.tcpdump_sniff_packets(intf=rx_interface,
> count=len(packets_sent),
> + inst = self.tester.tcpdump_sniff_packets(intf=rx_interface,
> + count=len(packets_sent)*4,
> filters=[{'layer': 'ether', 'config': {'src': sniff_src}}])
>
> for packet_type in packets_sent.keys():
> - self.tester.scapy_append('sendp([%s], iface="%s")' %
> (packets_sent[packet_type], tx_interface))
> + self.tester.scapy_append('sendp([%s], iface="%s", count=4)'
> + % (packets_sent[packet_type], tx_interface))
>
> self.tester.scapy_execute()
> p = self.tester.load_tcpdump_sniff_packets(inst)
> @@ -197,7 +200,7 @@ class TestChecksumOffload(TestCase):
> reslist =
> [p[i].pktgen.pkt.sprintf("%IP.chksum%;%TCP.chksum%;%UDP.chksum%;%SCTP.
> chksum%") for i in range(nr_packets)]
> out = string.join(reslist, ",")
> packets_received = out.split(',')
> - self.verify(len(packets_sent) == len(packets_received), "Unexpected
> Packets Drop")
> + self.verify(len(packets_sent)*4 == len(packets_received),
> + "Unexpected Packets Drop")
>
> for packet_received in packets_received:
> ip_checksum, tcp_checksum, udp_checksum, sctp_checksum =
> packet_received.split(';')
> --
> 1.7.9.5
next prev parent reply other threads:[~2019-07-03 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 10:13 pvukkisala
2019-07-03 9:41 ` Tu, Lijuan [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-14 11:12 pvukkisala
2019-06-26 7:01 ` Tu, Lijuan
2019-06-26 10:14 ` Phanendra Vukkisala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BADA80C@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=avijay@marvell.com \
--cc=dts@dpdk.org \
--cc=fmasood@marvell.com \
--cc=pvukkisala@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).