test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Ma, LihongX" <lihongx.ma@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Ma, LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vhost_event_idx_interrupt: add verify of	qemu version
Date: Wed, 10 Jul 2019 02:07:27 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BADE682@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1562623553-24007-1-git-send-email-lihongx.ma@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Tuesday, July 9, 2019 6:06 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] tests/vhost_event_idx_interrupt: add verify of
> qemu version
> 
> in this suite, the qemu will start as server mode, and qemu supports server
> mode starting with version 2.7
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_vhost_event_idx_interrupt.py | 22
> ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/tests/TestSuite_vhost_event_idx_interrupt.py
> b/tests/TestSuite_vhost_event_idx_interrupt.py
> index 4df5a42..24cd066 100644
> --- a/tests/TestSuite_vhost_event_idx_interrupt.py
> +++ b/tests/TestSuite_vhost_event_idx_interrupt.py
> @@ -36,6 +36,7 @@ Vhost event idx interrupt need test with l3fwd-power
> sample
> 
>  import utils
>  import time
> +import re
>  from virt_common import VM
>  from test_case import TestCase
> 
> @@ -136,6 +137,26 @@ class TestVhostEventIdxInterrupt(TestCase):
>              if vm_config.params[i].keys()[0] == 'cpu':
>                  vm_config.params[i]['cpu'][0]['number'] = self.queues
> 
> +    def check_qemu_version(self, vm_config):
> +        """
> +        in this suite, the qemu version should greater 2.7
> +        """
> +        self.vm_qemu_version = vm_config.qemu_emulator
> +        params_number = len(vm_config.params)
> +        for i in range(params_number):
> +            if vm_config.params[i].keys()[0] == 'qemu':
> +                self.vm_qemu_version =
> + vm_config.params[i]['qemu'][0]['path']
> +
> +        out = self.dut.send_expect("%s --version" % self.vm_qemu_version, "#")
> +        result = re.search("QEMU\s*emulator\s*version\s*(\d*.\d*)", out)
> +        self.verify(result is not None,
> +                'the qemu path may be not right: %s' % self.vm_qemu_version)
> +        version = result.group(1)
> +        index = version.find('.')
> +        self.verify(int(version[:index])>2 or (int(version[:index])==2 and
> int(version[index+1:])>=7),
> +                    'This qemu version should greater than 2.7 ' + \
> +                    'in this suite, please config it in
> + vhost_sample.cfg file')
> +
>      def start_vms(self, vm_num=1):
>          """
>          start qemus
> @@ -156,6 +177,7 @@ class TestVhostEventIdxInterrupt(TestCase):
>              vm_params['opt_settings'] = opt_args
>              vm_info.set_vm_device(**vm_params)
>              self.set_vm_cpu_number(vm_info)
> +            self.check_qemu_version(vm_info)
>              vm_dut = None
>              try:
>                  vm_dut = vm_info.start(load_config=False)
> --
> 2.7.4


      parent reply	other threads:[~2019-07-10  2:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 22:05 lihong
2019-07-09  5:29 ` Ma, LihongX
2019-07-10  2:07 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BADE682@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).