test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "pvukkisala@marvell.com" <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
	"fmasood@marvell.com" <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
Date: Wed, 10 Jul 2019 05:25:15 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BADE8CF@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1562248643-7014-1-git-send-email-pvukkisala@marvell.com>

Sorry, applied error, could you fix it?

Applying: dynamic_queue: Fix Tx queue tests on cavium device
.git/rebase-apply/patch:20: trailing whitespace.
                # Check Tx stopped queue only transmits qringsize-1 packets
error: patch failed: tests/TestSuite_dynamic_queue.py:150
error: tests/TestSuite_dynamic_queue.py: patch does not apply
Patch failed at 0001 dynamic_queue: Fix Tx queue tests on cavium device

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Thursday, July 4, 2019 9:57 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] dynamic_queue: Fix Tx queue tests on cavium device
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> our pmd completely blocks queuing up the pkts into TXD when queue is in
> stop state
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_dynamic_queue.py |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_dynamic_queue.py
> b/tests/TestSuite_dynamic_queue.py
> index f334a96..912e858 100644
> --- a/tests/TestSuite_dynamic_queue.py
> +++ b/tests/TestSuite_dynamic_queue.py
> @@ -150,9 +150,13 @@ class TestDynamicQueue(TestCase):
>              out = self.dut_testpmd.execute_cmd('stop')
>              tx_num = qringsize - 1
> 
> -            # Check Tx stopped queue only transmits qringsize-1 packets
> -            self.verify("TX-packets: %d" % tx_num in out,
> -                        "Fail to stop txq at runtime")
> +            if self.nic == "cavium_a063":
> +                self.verify("TX-packets: 0" in out,
> +                            "Fail to stop txq at runtime")
> +            else:
> +                # Check Tx stopped queue only transmits qringsize-1 packets
> +                self.verify("TX-packets: %d" % tx_num in out,
> +                            "Fail to stop txq at runtime")
>              if chgflag == 1:
>                  chg_qringsize = qringsize % 1024 + 256
>                  self.dut_testpmd.execute_cmd(
> --
> 1.7.9.5


  reply	other threads:[~2019-07-10  5:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 13:57 pvukkisala
2019-07-10  5:25 ` Tu, Lijuan [this message]
2019-07-15  6:43 pvukkisala
2019-08-07  3:23 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BADE8CF@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).