test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/TestSuite_vf_vlan:set filter on before add vlan
  2019-07-23  2:58 [dts] [PATCH V1] tests/TestSuite_vf_vlan:set filter on before add vlan zhang,yan
@ 2019-07-23  2:54 ` Zhang, YanX A
  2019-08-06  9:53 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, YanX A @ 2019-07-23  2:54 UTC (permalink / raw)
  To: dts

Tested-by:  Zhang, YanX A <yanx.a.zhang@intel.com>

-----Original Message-----
From: Zhang, YanX A 
Sent: Tuesday, July 23, 2019 10:58 AM
To: dts@dpdk.org
Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
Subject: [dts][PATCH V1] tests/TestSuite_vf_vlan:set filter on before add vlan

set filter on before add vlan.
Otherwise the following error will be reported:
    ---Port 0: vlan-filtering disabled
    ---rte_eth_dev_vlan_filter(port_pi=0, vlan_id=4095, on=1) failed diag=-38

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_vf_vlan.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py index d0175b3..f50a7e5 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -289,6 +289,7 @@ class TestVfVlan(TestCase):
             # if you want insert tx_vlan,
             # please enable rx_vlan at the same time
             if self.kdriver == "i40e":
+                self.vm0_testpmd.execute_cmd('vlan set filter on 0')
                 self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % tx_vlan)
             self.vm0_testpmd.execute_cmd('stop')
             self.vm0_testpmd.execute_cmd('port stop all')
--
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/TestSuite_vf_vlan:set filter on before add vlan
@ 2019-07-23  2:58 zhang,yan
  2019-07-23  2:54 ` Zhang, YanX A
  2019-08-06  9:53 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: zhang,yan @ 2019-07-23  2:58 UTC (permalink / raw)
  To: dts; +Cc: zhang,yan

set filter on before add vlan.
Otherwise the following error will be reported:
    ---Port 0: vlan-filtering disabled
    ---rte_eth_dev_vlan_filter(port_pi=0, vlan_id=4095, on=1) failed diag=-38

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_vf_vlan.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index d0175b3..f50a7e5 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -289,6 +289,7 @@ class TestVfVlan(TestCase):
             # if you want insert tx_vlan,
             # please enable rx_vlan at the same time
             if self.kdriver == "i40e":
+                self.vm0_testpmd.execute_cmd('vlan set filter on 0')
                 self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % tx_vlan)
             self.vm0_testpmd.execute_cmd('stop')
             self.vm0_testpmd.execute_cmd('port stop all')
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_vf_vlan:set filter on before add vlan
  2019-07-23  2:58 [dts] [PATCH V1] tests/TestSuite_vf_vlan:set filter on before add vlan zhang,yan
  2019-07-23  2:54 ` Zhang, YanX A
@ 2019-08-06  9:53 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-08-06  9:53 UTC (permalink / raw)
  To: Zhang, YanX A, dts; +Cc: Zhang, YanX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Tuesday, July 23, 2019 10:58 AM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_vf_vlan:set filter on before add
> vlan
> 
> set filter on before add vlan.
> Otherwise the following error will be reported:
>     ---Port 0: vlan-filtering disabled
>     ---rte_eth_dev_vlan_filter(port_pi=0, vlan_id=4095, on=1) failed diag=-38
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_vf_vlan.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py index
> d0175b3..f50a7e5 100644
> --- a/tests/TestSuite_vf_vlan.py
> +++ b/tests/TestSuite_vf_vlan.py
> @@ -289,6 +289,7 @@ class TestVfVlan(TestCase):
>              # if you want insert tx_vlan,
>              # please enable rx_vlan at the same time
>              if self.kdriver == "i40e":
> +                self.vm0_testpmd.execute_cmd('vlan set filter on 0')
>                  self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % tx_vlan)
>              self.vm0_testpmd.execute_cmd('stop')
>              self.vm0_testpmd.execute_cmd('port stop all')
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23  2:58 [dts] [PATCH V1] tests/TestSuite_vf_vlan:set filter on before add vlan zhang,yan
2019-07-23  2:54 ` Zhang, YanX A
2019-08-06  9:53 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox