test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/userspace_ethtool:Optimize test results
@ 2019-07-11  4:15 changqingxwu
  2019-08-07  2:23 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: changqingxwu @ 2019-07-11  4:15 UTC (permalink / raw)
  To: dts; +Cc: changqingxwu

Signed-off-by: changqingxwu <changqingx.wu@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index c774552..dd8c9a6 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -316,9 +316,6 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         portsinfo = []
         ori_drivers = []
         
-        if self.nic.startswith("fortville"):
-            return
-        
         for portid in range(len(self.ports)):
             self.dut.send_expect("regs %d regs_%d.bin" % (portid, portid), "EthApp>")
             portinfo = {'portid': portid, 'reg_file': 'regs_%d.bin' % portid}
@@ -338,7 +335,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             # get linux interface
             intf = netdev.get_interface_name()
             out = self.dut.send_expect("ethtool -d %s raw off file %s" % (intf, portinfo['reg_file']), "# ")
-            self.verify(("LINKS" in out and "FCTRL" in out), "Failed to dump %s registers" % intf)
+            self.verify(("register" in out and "CTRL" in out), "Failed to dump %s registers" % intf)
 
         for index in range(len(self.ports)):
             # bind to original driver
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/userspace_ethtool:Optimize test results
  2019-07-11  4:15 [dts] [PATCH V1] tests/userspace_ethtool:Optimize test results changqingxwu
@ 2019-08-07  2:23 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-08-07  2:23 UTC (permalink / raw)
  To: Wu, ChangqingX, dts; +Cc: Wu, ChangqingX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Thursday, July 11, 2019 12:15 PM
> To: dts@dpdk.org
> Cc: Wu, ChangqingX <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool:Optimize test results
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index c774552..dd8c9a6 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -316,9 +316,6 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          portsinfo = []
>          ori_drivers = []
> 
> -        if self.nic.startswith("fortville"):
> -            return
> -
>          for portid in range(len(self.ports)):
>              self.dut.send_expect("regs %d regs_%d.bin" % (portid, portid),
> "EthApp>")
>              portinfo = {'portid': portid, 'reg_file': 'regs_%d.bin' % portid} @@ -
> 338,7 +335,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
>              # get linux interface
>              intf = netdev.get_interface_name()
>              out = self.dut.send_expect("ethtool -d %s raw off file %s" % (intf,
> portinfo['reg_file']), "# ")
> -            self.verify(("LINKS" in out and "FCTRL" in out), "Failed to dump %s
> registers" % intf)
> +            self.verify(("register" in out and "CTRL" in out), "Failed
> + to dump %s registers" % intf)
> 
>          for index in range(len(self.ports)):
>              # bind to original driver
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-11  4:15 [dts] [PATCH V1] tests/userspace_ethtool:Optimize test results changqingxwu
2019-08-07  2:23 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox