test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Ma, LihongX" <lihongx.ma@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Ma, LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH V1] tests/loopback_multi_paths_port_restart: update	according to plan
Date: Wed, 7 Aug 2019 03:02:04 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BAFEB51@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1562894993-15581-1-git-send-email-lihongx.ma@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Friday, July 12, 2019 9:30 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] tests/loopback_multi_paths_port_restart: update
> according to plan
> 
> 1. remove testcase of virtio1.1 inorder path 2. add command 'set burst 1'
> when vhost port restart 3. modify prefix of testcase from test_perf to test
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  .../TestSuite_loopback_multi_paths_port_restart.py | 39 ++++++++-------------
> -
>  1 file changed, 13 insertions(+), 26 deletions(-)
> 
> diff --git a/tests/TestSuite_loopback_multi_paths_port_restart.py
> b/tests/TestSuite_loopback_multi_paths_port_restart.py
> index 797be95..b1bd32f 100644
> --- a/tests/TestSuite_loopback_multi_paths_port_restart.py
> +++ b/tests/TestSuite_loopback_multi_paths_port_restart.py
> @@ -33,10 +33,9 @@
> 
>  """
>  DPDK Test suite.
> -Benchmark Vhost loopback for 8 RX/TX PATHs.
> +Benchmark Vhost loopback for 7 RX/TX PATHs.
>  Includes Mergeable, Normal, Vector_RX,Inorder_mergeable, -
> Inorder_no_mergeable, VIRTIO1.1_mergeable, VIRTIO1.1_normal Path, -
> VIRTIO1.1_inorder_normal Path.
> +Inorder_no_mergeable, VIRTIO1.1_mergeable, VIRTIO1.1_normal Path.
>  """
>  import utils
>  import time
> @@ -144,7 +143,8 @@ class TestLoopbackPortRestart(TestCase):
>          self.vhost.send_expect("clear port stats all", "testpmd> ", 120)
>          self.vhost.send_expect("port start all", "testpmd> ", 120)
>          self.check_port_link_status_after_port_restart()
> -        self.vhost.send_expect("start tx_first 32", "testpmd> ", 120)
> +        self.vhost.send_expect("set burst 1", "testpmd> ", 120)
> +        self.vhost.send_expect("start tx_first 1", "testpmd> ", 120)
> 
>      def update_table_info(self, case_info, frame_size, Mpps, Cycle):
>          results_row = [frame_size]
> @@ -180,7 +180,7 @@ class TestLoopbackPortRestart(TestCase):
> 
>          self.port_restart()
>          Mpps = self.calculate_avg_throughput()
> -        self.update_table_info(case_info, frame_size, Mpps, "After Restart")
> +        self.update_table_info(case_info, frame_size, Mpps, "After
> + Restart and set burst to 1")
> 
>      def close_all_testpmd(self):
>          """
> @@ -196,7 +196,7 @@ class TestLoopbackPortRestart(TestCase):
>          self.dut.close_session(self.vhost)
>          self.dut.close_session(self.virtio_user)
> 
> -    def test_perf_vhost_loopback_virtio11_mergeable_mac(self):
> +    def test_vhost_loopback_virtio11_mergeable_mac(self):
>          """
>          performance for [frame_sizes] and restart port on virtio1.1 mergeable
> path
>          """
> @@ -209,7 +209,7 @@ class TestLoopbackPortRestart(TestCase):
>              self.close_all_testpmd()
>          self.result_table_print()
> 
> -    def test_perf_vhost_loopback_virtio11_normal_mac(self):
> +    def test_vhost_loopback_virtio11_normal_mac(self):
>          """
>          performance for [frame_sizes] and restart port ob virtio1.1 normal path
>          """
> @@ -222,20 +222,7 @@ class TestLoopbackPortRestart(TestCase):
>              self.close_all_testpmd()
>          self.result_table_print()
> 
> -    def test_perf_vhost_loopback_virtio11_inorder_mac(self):
> -        """
> -        performance for [frame_sizes] and restart port on virtio1.1 inorder
> path
> -        """
> -        pmd_arg = {"version": "packed_vq=1,in_order=1,mrg_rxbuf=0 ",
> -                          "path": "--tx-offloads=0x0 --enable-hw-vlan-strip "}
> -        for frame_size in self.frame_sizes:
> -            self.start_vhost_testpmd()
> -            self.start_virtio_user_testpmd(pmd_arg)
> -            self.send_and_verify("virtio1.1 inorder", frame_size)
> -            self.close_all_testpmd()
> -        self.result_table_print()
> -
> -    def test_perf_vhost_loopback_virtiouser_inorder_mergeable_mac(self):
> +    def test_vhost_loopback_virtiouser_inorder_mergeable_mac(self):
>          """
>          performance for [frame_sizes] and restart port on inorder mergeable
> path
>          """
> @@ -248,7 +235,7 @@ class TestLoopbackPortRestart(TestCase):
>              self.close_all_testpmd()
>          self.result_table_print()
> 
> -    def
> test_perf_vhost_loopback_virtiouser_inorder_mergeable_off_mac(self):
> +    def test_vhost_loopback_virtiouser_inorder_mergeable_off_mac(self):
>          """
>          performance for [frame_sizes] and restart port on inorder normal path
>          """
> @@ -261,7 +248,7 @@ class TestLoopbackPortRestart(TestCase):
>              self.close_all_testpmd()
>          self.result_table_print()
> 
> -    def test_perf_vhost_loopback_virtiouser_mergeable_mac(self):
> +    def test_vhost_loopback_virtiouser_mergeable_mac(self):
>          """
>          performance for [frame_sizes] and restart port on virtio mergeable
> path
>          """
> @@ -274,7 +261,7 @@ class TestLoopbackPortRestart(TestCase):
>              self.close_all_testpmd()
>          self.result_table_print()
> 
> -    def test_perf_vhost_loopback_virtiouser_normal_mac(self):
> +    def test_vhost_loopback_virtiouser_normal_mac(self):
>          """
>          performance for [frame_sizes] and restart port on virtio normal path
>          """
> @@ -287,12 +274,12 @@ class TestLoopbackPortRestart(TestCase):
>              self.close_all_testpmd()
>          self.result_table_print()
> 
> -    def test_perf_vhost_loopback_virtiouser_vector_rx_mac(self):
> +    def test_vhost_loopback_virtiouser_vector_rx_mac(self):
>          """
>          performance for frame_sizes and restart port on virtio vector rx
>          """
>          pmd_arg = {"version": "packed_vq=0,in_order=0,mrg_rxbuf=0 ",
> -                          "path": "--tx-offloads=0x0 "}
> +                          "path": ""}
>          for frame_size in self.frame_sizes:
>              self.start_vhost_testpmd()
>              self.start_virtio_user_testpmd(pmd_arg)
> --
> 2.7.4


      reply	other threads:[~2019-08-07  3:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12  1:29 lihong
2019-08-07  3:02 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BAFEB51@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).