test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] TestSuite_shutdown_api.py: disable-crc-strip is not supported for cavium_a063 and cavium_a064
@ 2019-08-12  3:27 nareddy
  2019-08-12  7:02 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: nareddy @ 2019-08-12  3:27 UTC (permalink / raw)
  To: dts; +Cc: fmasood, avijay, Praneeth Reddy

From: Praneeth Reddy <nareddy@marvell.com>

Removed disable-crc-strip parameter for cavium_a063 and cavium_a064

Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
---
 tests/TestSuite_shutdown_api.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index d31392d..f889e1c 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -265,7 +265,10 @@ class TestShutdownApi(TestCase):
         """
         RX_OFFLOAD_KEEP_CRC = 0x10000
 
-        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
+        if (self.nic in ["cavium_a063", "cavium_a064"]):
+            self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
+        else:
+            self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S)
         crc_keep_temp = []
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] TestSuite_shutdown_api.py: disable-crc-strip is not supported for cavium_a063 and cavium_a064
  2019-08-12  3:27 [dts] [PATCH] TestSuite_shutdown_api.py: disable-crc-strip is not supported for cavium_a063 and cavium_a064 nareddy
@ 2019-08-12  7:02 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-08-12  7:02 UTC (permalink / raw)
  To: nareddy, dts; +Cc: fmasood, avijay

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, August 12, 2019 11:27 AM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_shutdown_api.py: disable-crc-strip is not
> supported for cavium_a063 and cavium_a064
> 
> From: Praneeth Reddy <nareddy@marvell.com>
> 
> Removed disable-crc-strip parameter for cavium_a063 and cavium_a064
> 
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  tests/TestSuite_shutdown_api.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index d31392d..f889e1c 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -265,7 +265,10 @@ class TestShutdownApi(TestCase):
>          """
>          RX_OFFLOAD_KEEP_CRC = 0x10000
> 
> -        self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop --disable-crc-strip" % utils.create_mask(self.ports),
> socket=self.ports_socket)
> +        if (self.nic in ["cavium_a063", "cavium_a064"]):
> +            self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
> +        else:
> +            self.pmdout.start_testpmd("Default", "--portmask=%s
> + --port-topology=loop --disable-crc-strip" %
> + utils.create_mask(self.ports), socket=self.ports_socket)
>          out = self.dut.send_expect("show config rxtx", "testpmd> ")
>          Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S)
>          crc_keep_temp = []
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12  3:27 [dts] [PATCH] TestSuite_shutdown_api.py: disable-crc-strip is not supported for cavium_a063 and cavium_a064 nareddy
2019-08-12  7:02 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox