test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] test_plans: fix build warnings
Date: Mon, 12 Aug 2019 07:06:04 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB0195B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1565619738-46976-1-git-send-email-wenjiex.a.li@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Monday, August 12, 2019 10:22 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] test_plans: fix build warnings
> 
> fix build warnings
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  test_plans/af_xdp_test_plan.rst | 142 ++++++++++++++++----------------
>  test_plans/index.rst            |   8 +-
>  2 files changed, 77 insertions(+), 73 deletions(-)
> 
> diff --git a/test_plans/af_xdp_test_plan.rst
> b/test_plans/af_xdp_test_plan.rst index d12ef0c..58e6077 100644
> --- a/test_plans/af_xdp_test_plan.rst
> +++ b/test_plans/af_xdp_test_plan.rst
> @@ -139,36 +139,36 @@ Test case 4: multiqueue
> 
>  1. One queue.
> 
> -   1) Start the testpmd with one queue::
> +  1) Start the testpmd with one queue::
> 
> -    ./testpmd -l 29,30 -n 6 --no-pci \
> -    --vdev net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=1 \
> -    -- -i --nb-cores=1 --rxq=1 --txq=1 --port-topology=loop
> +      ./testpmd -l 29,30 -n 6 --no-pci \
> +      --vdev net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=1 \
> +      -- -i --nb-cores=1 --rxq=1 --txq=1 --port-topology=loop
> 
> -   2) Assign the kernel core::
> +  2) Assign the kernel core::
> 
> -    ./set_irq_affinity 34 enp216s0f0
> +      ./set_irq_affinity 34 enp216s0f0
> 
> -   3) Send packets with different dst IP address by packet generator
> -      with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> +  3) Send packets with different dst IP address by packet generator
> +     with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> 
>  2. Four queues.
> 
> -   1) Set hardware queue::
> +  1) Set hardware queue::
> 
> -    ethtool -L enp216s0f0 combined 4
> +      ethtool -L enp216s0f0 combined 4
> 
> -   2)Start the testpmd with four queues::
> +  2) Start the testpmd with four queues::
> 
> -    ./testpmd -l 29,30-33 -n 6 --no-pci \
> -    --vdev net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=4 \
> -    -- -i --nb-cores=4 --rxq=4 --txq=4 --port-topology=loop
> +      ./testpmd -l 29,30-33 -n 6 --no-pci \
> +      --vdev net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=4 \
> +      -- -i --nb-cores=4 --rxq=4 --txq=4 --port-topology=loop
> 
> -   3)Assign the kernel core::
> +  3) Assign the kernel core::
> 
> -    ./set_irq_affinity 34-37 enp216s0f0
> +      ./set_irq_affinity 34-37 enp216s0f0
> 
> -   4)Send packets with different dst IP address by packet generator
> +  4) Send packets with different dst IP address by packet generator
>        with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
>        The packets were distributed to the four queues.
> 
> @@ -177,45 +177,45 @@ Test case 5: multiqueue and zero copy
> 
>  1. One queue and zero copy.
> 
> -   1) Set hardware queue::
> +  1) Set hardware queue::
> 
> -    ethtool -L enp216s0f0 combined 1
> +      ethtool -L enp216s0f0 combined 1
> 
> -   2) Start the testpmd with one queue::
> +  2) Start the testpmd with one queue::
> 
> -    ./testpmd -l 29,30 -n 6 --no-pci \
> -    --vdev
> net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=1,pmd_zero_co
> py=1 \
> -    -- -i --nb-cores=1 --rxq=1 --txq=1 --port-topology=loop
> +      ./testpmd -l 29,30 -n 6 --no-pci \
> +      --vdev
> net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=1,pmd_zero_co
> py=1 \
> +      -- -i --nb-cores=1 --rxq=1 --txq=1 --port-topology=loop
> 
> -   3) Assign the kernel core::
> +  3) Assign the kernel core::
> 
> -    ./set_irq_affinity 34 enp216s0f0
> +      ./set_irq_affinity 34 enp216s0f0
> 
> -   4) Send packets with different dst IP address by packet generator
> -      with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> -      Expect the performance is better than non-zero-copy.
> +  4) Send packets with different dst IP address by packet generator
> +     with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> +     Expect the performance is better than non-zero-copy.
> 
>  2. Four queues and zero copy.
> 
> -   1) Set hardware queue::
> +  1) Set hardware queue::
> 
> -    ethtool -L enp216s0f0 combined 4
> +      ethtool -L enp216s0f0 combined 4
> 
> -   2) Start the testpmd with four queues::
> +  2) Start the testpmd with four queues::
> 
> -    ./testpmd -l 29,30-33 -n 6 --no-pci \
> -    --vdev
> net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=4,pmd_zero_co
> py=1 \
> -    -- -i --nb-cores=4 --rxq=4 --txq=4 --port-topology=loop
> +      ./testpmd -l 29,30-33 -n 6 --no-pci \
> +      --vdev
> net_af_xdp0,iface=enp216s0f0,start_queue=0,queue_count=4,pmd_zero_co
> py=1 \
> +      -- -i --nb-cores=4 --rxq=4 --txq=4 --port-topology=loop
> 
> -   3) Assign the kernel core::
> +  3) Assign the kernel core::
> 
> -    ./set_irq_affinity 34-37 enp216s0f0
> +      ./set_irq_affinity 34-37 enp216s0f0
> 
> -   4) Send packets with different dst IP address by packet generator
> -      with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> -      The packets were distributed to the four queues.
> -      Expect the performance of four queues is better than one queue.
> -      Expect the performance is better than non-zero-copy.
> +  4) Send packets with different dst IP address by packet generator
> +     with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> +     The packets were distributed to the four queues.
> +     Expect the performance of four queues is better than one queue.
> +     Expect the performance is better than non-zero-copy.
> 
>  Test case 6: need_wakeup
>  ========================
> @@ -242,57 +242,57 @@ Test case 7: xdpsock sample performance
> 
>  1. One queue.
> 
> -   1) Set hardware queue::
> +  1) Set hardware queue::
> 
> -    ethtool -L enp216s0f0 combined 1
> +      ethtool -L enp216s0f0 combined 1
> 
> -   2) Start the xdp socket with one queue::
> +  2) Start the xdp socket with one queue::
> 
> -    #taskset -c 30 ./xdpsock -l -i enp216s0f0
> +      #taskset -c 30 ./xdpsock -l -i enp216s0f0
> 
> -   3) Assign the kernel core::
> +  3) Assign the kernel core::
> 
> -    ./set_irq_affinity 34 enp216s0f0
> +      ./set_irq_affinity 34 enp216s0f0
> 
> -   4) Send packets with different dst IP address by packet generator
> -      with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> +  4) Send packets with different dst IP address by packet generator
> +     with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> 
>  2. Four queues.
> 
> -   1) Set hardware queue::
> +  1) Set hardware queue::
> 
> -    ethtool -L enp216s0f0 combined 4
> +      ethtool -L enp216s0f0 combined 4
> 
> -   2) Start the xdp socket with four queues::
> +  2) Start the xdp socket with four queues::
> 
> -    #taskset -c 30 ./xdpsock -l -i enp216s0f0 -q 0
> -    #taskset -c 31 ./xdpsock -l -i enp216s0f0 -q 1
> -    #taskset -c 32 ./xdpsock -l -i enp216s0f0 -q 2
> -    #taskset -c 33 ./xdpsock -l -i enp216s0f0 -q 3
> +      #taskset -c 30 ./xdpsock -l -i enp216s0f0 -q 0
> +      #taskset -c 31 ./xdpsock -l -i enp216s0f0 -q 1
> +      #taskset -c 32 ./xdpsock -l -i enp216s0f0 -q 2
> +      #taskset -c 33 ./xdpsock -l -i enp216s0f0 -q 3
> 
> -   3)Assign the kernel core::
> +  3) Assign the kernel core::
> 
> -    ./set_irq_affinity 34-37 enp216s0f0
> +      ./set_irq_affinity 34-37 enp216s0f0
> 
> -   4)Send packets with different dst IP address by packet generator
> -      with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> -      The packets were distributed to the four queues.
> -      Expect the performance of four queues is better than one queue.
> +  4) Send packets with different dst IP address by packet generator
> +     with different packet size from 64 bytes to 1518 bytes, check the
> throughput.
> +     The packets were distributed to the four queues.
> +     Expect the performance of four queues is better than one queue.
> 
>  3. Need_wakeup.
> 
> -   1) Set hardware queue::
> +  1) Set hardware queue::
> 
> -    ethtool -L enp216s0f0 combined 1
> +      ethtool -L enp216s0f0 combined 1
> 
> -   2) Start the xdp socket with four queues::
> +  2) Start the xdp socket with four queues::
> 
> -    #taskset -c 30 ./xdpsock -l -i enp216s0f0
> +      #taskset -c 30 ./xdpsock -l -i enp216s0f0
> 
> -   3)Assign the kernel core::
> +  3) Assign the kernel core::
> 
> -    ./set_irq_affinity 30 enp216s0f0
> +      ./set_irq_affinity 30 enp216s0f0
> 
> -   4) Send packets by packet generator with different packet size from 64
> bytes
> -      to 1518 bytes, check the throughput.
> -      Expect the performance is better than no need_wakeup.
> +  4) Send packets by packet generator with different packet size from 64
> bytes
> +     to 1518 bytes, check the throughput.
> +     Expect the performance is better than no need_wakeup.
> \ No newline at end of file
> diff --git a/test_plans/index.rst b/test_plans/index.rst index
> a8269fa..28f5a69 100644
> --- a/test_plans/index.rst
> +++ b/test_plans/index.rst
> @@ -189,7 +189,7 @@ The following are the test plans for the DPDK DTS
> automated test system.
>      vdev_primary_secondary_test_plan
>      vhost_1024_ethports_test_plan
>      virtio_pvp_regression_test_plan
> -    virtio_user_as_exceptional_path
> +    virtio_user_as_exceptional_path_test_plan
> 
>      unit_tests_cmdline_test_plan
>      unit_tests_crc_test_plan
> @@ -225,4 +225,8 @@ The following are the test plans for the DPDK DTS
> automated test system.
>      flow_classify_test_plan
>      dpdk_hugetlbfs_mount_size_test_plan
>      nic_single_core_perf_test_plan
> -    power_managerment_throughput_test_plan
> \ No newline at end of file
> +    power_managerment_throughput_test_plan
> +    ethtool_stats_test_plan
> +    iavf_test_plan
> +    packet_capture_test_plan
> +    packet_ordering_test_plan
> --
> 2.17.2


  reply	other threads:[~2019-08-12  7:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 14:22 Wenjie Li
2019-08-12  7:06 ` Tu, Lijuan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-12-22  5:20 [dts] [PATCH V1] test_plans:fix " Wenjie Li
2019-12-27  6:08 ` Tu, Lijuan
2019-07-22  7:08 [dts] [PATCH V1] test_plans: fix " Wenjie Li
2019-08-06  9:00 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB0195B@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).