From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFEF9A0613 for ; Wed, 28 Aug 2019 07:37:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5C101C1F3; Wed, 28 Aug 2019 07:37:08 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 189EB1BFFB for ; Wed, 28 Aug 2019 07:37:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 22:37:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,440,1559545200"; d="scan'208";a="188116089" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 27 Aug 2019 22:37:06 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 27 Aug 2019 22:37:06 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 27 Aug 2019 22:37:06 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Wed, 28 Aug 2019 13:37:04 +0800 From: "Tu, Lijuan" To: "Mo, YufengX" , "dts@dpdk.org" CC: "Mo, YufengX" Thread-Topic: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code Thread-Index: AQHVUZiubK+1s3dvKEO5OjF5sp9IhqcQIgcg Date: Wed, 28 Aug 2019 05:37:03 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB06690@SHSMSX101.ccr.corp.intel.com> References: <1565674467-21124-1-git-send-email-yufengx.mo@intel.com> <1565674467-21124-2-git-send-email-yufengx.mo@intel.com> In-Reply-To: <1565674467-21124-2-git-send-email-yufengx.mo@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjUwMDI5MDYtMGQ2NC00ZGNmLWJmMDAtYzViMmUyNDg1OTExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN2JsRU1JclVtQTgxWnozM2tFR1BURlhlRlhBYXhKQVBUWXJ6eWlEbEZJaGpUdGVYNXNMQU52dFdcLzFXRDMwbVgifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx > Sent: Tuesday, August 13, 2019 1:34 PM > To: dts@dpdk.org > Cc: Mo, YufengX > Subject: [dts] [PATCH V1]framework\qemu_kvm: remove duplicate source > code >=20 >=20 > remove duplicate opt_settings key setting in __add_vm_virtio_user_pci > method. >=20 > Signed-off-by: yufengmx > --- > framework/qemu_kvm.py | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index > c425f41..e349517 100644 > --- a/framework/qemu_kvm.py > +++ b/framework/qemu_kvm.py > @@ -813,8 +813,6 @@ class QEMUKvm(VirtBase): > opts['opt_settings'] =3D options['opt_settings'] > if 'opt_legacy' in options.keys() and options['opt_legacy']: > opts['opt_legacy'] =3D options['opt_legacy'] > - if 'opt_settings' in options.keys() and options['opt_settings']: > - opts['opt_settings'] =3D options['opt_settings'] > self.__add_vm_virtio_net_pci(**opts) >=20 > def __add_vm_virtio_cuse_pci(self, **options): > -- > 1.9.3