From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18A92A0613 for ; Wed, 28 Aug 2019 08:05:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D5001C1EE; Wed, 28 Aug 2019 08:05:22 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 241741C130 for ; Wed, 28 Aug 2019 08:05:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 23:05:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,440,1559545200"; d="scan'208";a="192481861" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 27 Aug 2019 23:05:19 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 27 Aug 2019 23:05:18 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 27 Aug 2019 23:05:18 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Wed, 28 Aug 2019 14:03:47 +0800 From: "Tu, Lijuan" To: "Ma, LihongX" , "dts@dpdk.org" CC: "Ma, LihongX" Thread-Topic: [dts] [PATCH V1] tests/vhost_dequeue_zero_copy: optimization code Thread-Index: AQHVUnwagFZjbnTpH0uFpKjf84MhtacQJ7cQ Date: Wed, 28 Aug 2019 06:03:46 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB067D5@SHSMSX101.ccr.corp.intel.com> References: <1565745488-28958-1-git-send-email-lihongx.ma@intel.com> In-Reply-To: <1565745488-28958-1-git-send-email-lihongx.ma@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2JhMDk1ZjktMTIyMi00OWJjLTk1YTQtZDZkNWExN2Y4NzZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTlU1Nk96UlBxUG10XC9zNDdZMVMwTDRCbzhwZ29JXC81c0lzYUw4Q3VrVUFuRGZTdlR2ZllLQ3JaNkdYekxqZTJLIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vhost_dequeue_zero_copy: optimization code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong > Sent: Wednesday, August 14, 2019 9:18 AM > To: dts@dpdk.org > Cc: Ma, LihongX > Subject: [dts] [PATCH V1] tests/vhost_dequeue_zero_copy: optimization > code >=20 > 1. modify class name > 2. update code to support trex >=20 > Signed-off-by: lihong > --- > tests/TestSuite_vhost_dequeue_zero_copy.py | 49 ++++++++++++++++-------- > ------ > 1 file changed, 26 insertions(+), 23 deletions(-) >=20 > diff --git a/tests/TestSuite_vhost_dequeue_zero_copy.py > b/tests/TestSuite_vhost_dequeue_zero_copy.py > index 596a23a..5935536 100644 > --- a/tests/TestSuite_vhost_dequeue_zero_copy.py > +++ b/tests/TestSuite_vhost_dequeue_zero_copy.py > @@ -45,16 +45,16 @@ import re > from settings import HEADER_SIZE > from virt_common import VM > from test_case import TestCase > -from etgen import IxiaPacketGenerator > +from pktgen import PacketGeneratorHelper >=20 >=20 > -class TestPVPQemuZeroCopy(TestCase, IxiaPacketGenerator): > +class TestVhostDequeueZeroCopy(TestCase): >=20 > def set_up_all(self): > """ > Run at the start of each test suite. > """ > - self.tester.extend_external_packet_generator(TestPVPQemuZeroCopy= , > self) > + > + self.tester.extend_external_packet_generator(TestVhostDequeueZeroCopy, > + self) > self.frame_sizes =3D [64, 128, 256, 512, 1024, 1518] > self.queue_number =3D 1 > self.nb_cores =3D 1 > @@ -74,6 +74,13 @@ class TestPVPQemuZeroCopy(TestCase, > IxiaPacketGenerator): > if 'packet_sizes' in self.get_suite_cfg(): > self.frame_sizes =3D self.get_suite_cfg()['packet_sizes'] >=20 > + self.out_path =3D '/tmp' > + out =3D self.tester.send_expect('ls -d %s' % self.out_path, '# '= ) > + if 'No such file or directory' in out: > + self.tester.send_expect('mkdir -p %s' % self.out_path, '# ') > + # create an instance to set stream field setting > + self.pktgen_helper =3D PacketGeneratorHelper() > + > def set_up(self): > """ > Run before each test case. > @@ -89,23 +96,6 @@ class TestPVPQemuZeroCopy(TestCase, > IxiaPacketGenerator): >=20 > self.vhost =3D self.dut.new_session(suite=3D"vhost-user") >=20 > - def ip(self, port, frag, src, proto, tos, dst, chksum, len, > - options, version, flags, ihl, ttl, id): > - """ > - Configure IP protocol. > - """ > - self.add_tcl_cmd("protocol config -name ip") > - self.add_tcl_cmd('ip config -sourceIpAddr "%s"' % src) > - self.add_tcl_cmd('ip config -destIpAddrMode ipRandom') > - self.add_tcl_cmd("ip config -ttl %d" % ttl) > - self.add_tcl_cmd("ip config -totalLength %d" % len) > - self.add_tcl_cmd("ip config -fragment %d" % frag) > - self.add_tcl_cmd("ip config -ipProtocol %d" % proto) > - self.add_tcl_cmd("ip config -identifier %d" % id) > - self.add_tcl_cmd("stream config -framesize %d" % (len + 18)) > - self.add_tcl_cmd("ip set %d %d %d" % ( > - self.chasId, port['card'], port['port'])) > - > def get_core_mask(self): > """ > check whether the server has enough cores to run case @@ -209,6 > +199,13 @@ class TestPVPQemuZeroCopy(TestCase, IxiaPacketGenerator): > results_row.append(cycle) > self.result_table_add(results_row) >=20 > + def set_fields(self): > + """ > + set ip protocol field behavior > + """ > + fields_config =3D {'ip': {'dst': {'action': 'random'}, }, } > + return fields_config > + > def calculate_avg_throughput(self, frame_size, loopback): > """ > start to send packet and get the throughput @@ -216,13 +213,19 @= @ > class TestPVPQemuZeroCopy(TestCase, IxiaPacketGenerator): > payload =3D frame_size - HEADER_SIZE['eth'] - HEADER_SIZE['ip'] = - > HEADER_SIZE['udp'] > flow =3D > '[Ether(dst=3D"%s")/IP(src=3D"192.168.4.1",proto=3D255)/UDP()/("X"*%d)]' = % ( > self.dst_mac, payload) > - self.tester.scapy_append('wrpcap("zero_copy.pcap", %s)' % flow) > + self.tester.scapy_append('wrpcap("%s/zero_copy.pcap", %s)' % ( > + self.out_path, flow)) > self.tester.scapy_execute() >=20 > tgenInput =3D [] > port =3D self.tester.get_local_port(self.dut_ports[0]) > - tgenInput.append((port, port, "zero_copy.pcap")) > - _, pps =3D self.tester.traffic_generator_throughput(tgenInput, d= elay=3D30) > + tgenInput.append((port, port, "%s/zero_copy.pcap" % self.out_pat= h)) > + vm_config =3D self.set_fields() > + self.tester.pktgen.clear_streams() > + streams =3D self.pktgen_helper.prepare_stream_from_tginput(tgenI= nput, > 100, vm_config, self.tester.pktgen) > + # set traffic option > + traffic_opt =3D {'delay': 5, 'duration': 20} > + _, pps =3D > + self.tester.pktgen.measure_throughput(stream_ids=3Dstreams, > + options=3Dtraffic_opt) > Mpps =3D pps / 1000000.0 > # when the fwd mode is rxonly, we can not receive data, so shoul= d not > verify it > if loopback !=3D "rxonly": > -- > 2.7.4