test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/qinq_filter: delete unused import
  2019-08-14 18:19 [dts] [PATCH V1] tests/qinq_filter: delete unused import Wenjie Li
@ 2019-08-14  9:28 ` Zhu, ShuaiX
  2019-08-28 10:03 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, ShuaiX @ 2019-08-14  9:28 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A, Zhu, ShuaiX

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, August 15, 2019 2:20 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/qinq_filter: delete unused import
> 
> delete unused import and it could cause "'in <string>' requires string as left
> operand, not type" with default scapy.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_qinq_filter.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py index
> 143f680..372e9e9 100644
> --- a/tests/TestSuite_qinq_filter.py
> +++ b/tests/TestSuite_qinq_filter.py
> @@ -38,7 +38,6 @@ Test the support of VLAN Offload Features by Poll Mode
> Drivers.
>  """
> 
>  from test_case import TestCase
> -from scapy.all import *
>  import utils
>  import time
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/qinq_filter: delete unused import
@ 2019-08-14 18:19 Wenjie Li
  2019-08-14  9:28 ` Zhu, ShuaiX
  2019-08-28 10:03 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-08-14 18:19 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

delete unused import and it could cause "'in <string>' requires 
string as left operand, not type" with default scapy.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_qinq_filter.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py
index 143f680..372e9e9 100644
--- a/tests/TestSuite_qinq_filter.py
+++ b/tests/TestSuite_qinq_filter.py
@@ -38,7 +38,6 @@ Test the support of VLAN Offload Features by Poll Mode Drivers.
 """
 
 from test_case import TestCase
-from scapy.all import *
 import utils
 import time
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/qinq_filter: delete unused import
  2019-08-14 18:19 [dts] [PATCH V1] tests/qinq_filter: delete unused import Wenjie Li
  2019-08-14  9:28 ` Zhu, ShuaiX
@ 2019-08-28 10:03 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-08-28 10:03 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, August 15, 2019 2:20 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/qinq_filter: delete unused import
> 
> delete unused import and it could cause "'in <string>' requires string as left
> operand, not type" with default scapy.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_qinq_filter.py | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/TestSuite_qinq_filter.py b/tests/TestSuite_qinq_filter.py
> index 143f680..372e9e9 100644
> --- a/tests/TestSuite_qinq_filter.py
> +++ b/tests/TestSuite_qinq_filter.py
> @@ -38,7 +38,6 @@ Test the support of VLAN Offload Features by Poll
> Mode Drivers.
>  """
> 
>  from test_case import TestCase
> -from scapy.all import *
>  import utils
>  import time
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14 18:19 [dts] [PATCH V1] tests/qinq_filter: delete unused import Wenjie Li
2019-08-14  9:28 ` Zhu, ShuaiX
2019-08-28 10:03 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox