test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "pvukkisala@marvell.com" <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
	"fmasood@marvell.com" <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] pktgen_ixia: Exit on failure of clear/take port	ownership
Date: Wed, 28 Aug 2019 10:06:23 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB06A75@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1565791658-32718-1-git-send-email-pvukkisala@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Wednesday, August 14, 2019 10:08 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] pktgen_ixia: Exit on failure of clear/take port
> ownership
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  framework/pktgen_ixia.py |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/pktgen_ixia.py b/framework/pktgen_ixia.py index
> 2895c6b..1e0675d 100644
> --- a/framework/pktgen_ixia.py
> +++ b/framework/pktgen_ixia.py
> @@ -601,14 +601,18 @@ class Ixia(SSHConnection):
>                      "set chasId [ixGetChassisID %s]" % self.tclServerIP, "% ")
>          self.chasId = int(out.strip())
> 
> -        self.send_expect("ixClearOwnership [list %s]" % string.join(
> +        out = self.send_expect("ixClearOwnership [list %s]" %
> + string.join(
>              ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
>                  for item in self.ports], ' '),
>              "% ", 10)
> -        self.send_expect("ixTakeOwnership [list %s] force" % string.join(
> +        if out.strip()[-1] != '0':
> +            return False
> +        out = self.send_expect("ixTakeOwnership [list %s] force" %
> + string.join(
>              ['[list %d %d %d]' % (self.chasId, item['card'], item['port'])
>                  for item in self.ports], ' '),
>              "% ", 10)
> +        if out.strip()[-1] != '0':
> +            return False
> 
>          return True
> 
> --
> 1.7.9.5


      reply	other threads:[~2019-08-28 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-14 14:07 pvukkisala
2019-08-28 10:06 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB06A75@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).