From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DEAAA0613 for ; Wed, 28 Aug 2019 12:06:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9202E1C205; Wed, 28 Aug 2019 12:06:33 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 318161BF9B for ; Wed, 28 Aug 2019 12:06:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 03:06:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,440,1559545200"; d="scan'208";a="197523987" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 28 Aug 2019 03:06:30 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 03:06:30 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 03:06:30 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Wed, 28 Aug 2019 18:06:28 +0800 From: "Tu, Lijuan" To: "thaq@marvell.com" , "dts@dpdk.org" CC: "fmasood@marvell.com" , "avijay@marvell.com" Thread-Topic: [dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected error in userspaceethtool ringparam testcase. Thread-Index: AQHVUqqG8NBR6Iin402sp24o5JuWg6cQayqQ Date: Wed, 28 Aug 2019 10:06:28 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB06A82@SHSMSX101.ccr.corp.intel.com> References: <1565791988-7842-1-git-send-email-thaq@marvell.com> In-Reply-To: <1565791988-7842-1-git-send-email-thaq@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWJmY2FjYmQtOGU4NC00NThlLTk4YmQtNmNkOThlYWNjODNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTHMxbGdldHBwNjg2REZ4RkI2ZXF5cjhNZDd1eGpyM2xMYndSVzlDa3owRXo2OEN0KzRuNXNSNmtaa0lWK0R4byJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected error in userspaceethtool ringparam testcase. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of thaq@marvell.com > Sent: Wednesday, August 14, 2019 10:13 PM > To: dts@dpdk.org > Cc: fmasood@marvell.com; avijay@marvell.com; Thanseerulhaq > > Subject: [dts] [PATCH] tests/TestSuite_userspace_ethtool.py: Corrected er= ror > in userspaceethtool ringparam testcase. >=20 > From: Thanseerulhaq >=20 > Observed ethtool ringparam setting command is passed worngly. > EthApp> ringparam > Set ring parameters >=20 > Signed-off-by: Thanseerulhaq > --- > tests/TestSuite_userspace_ethtool.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 557a3ff..0a4b772 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -402,7 +402,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > port =3D self.ports[index] > ori_rx_pkts, ori_tx_pkts =3D self.strip_portstats(port) > _, rx_max, _, tx_max =3D self.strip_ringparam(index) > - self.dut.send_expect("ringparam %d %d %d" % (index, rx_max, > tx_max), "EthApp>") > + self.dut.send_expect("ringparam %d %d %d" % (index, tx_max, > rx_max), "EthApp>") > rx_ring, _, tx_ring, _ =3D self.strip_ringparam(index) > self.verify(rx_ring =3D=3D rx_max, "Userspace tool failed to= set Rx ring > parameter") > self.verify(tx_ring =3D=3D tx_max, "Userspace tool failed to= set Tx ring > parameter") > -- > 1.8.3.1