test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code to support trex
@ 2019-08-14 17:35 lihong
  2019-08-20  2:37 ` Wang, Yinan
  2019-08-28 10:06 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: lihong @ 2019-08-14 17:35 UTC (permalink / raw)
  To: dts; +Cc: lihong

Signed-off-by: lihong <lihongx.ma@intel.com>
---
 tests/TestSuite_pvp_virtio_user_multi_queues.py | 45 ++++++++++++++-----------
 1 file changed, 25 insertions(+), 20 deletions(-)

diff --git a/tests/TestSuite_pvp_virtio_user_multi_queues.py b/tests/TestSuite_pvp_virtio_user_multi_queues.py
index ebe65ba..ff8a0c4 100644
--- a/tests/TestSuite_pvp_virtio_user_multi_queues.py
+++ b/tests/TestSuite_pvp_virtio_user_multi_queues.py
@@ -42,10 +42,10 @@ import time
 import re
 from settings import HEADER_SIZE
 from test_case import TestCase
-from etgen import IxiaPacketGenerator
+from pktgen import PacketGeneratorHelper
 
 
-class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
+class TestPVPVirtioMultiQueues(TestCase):
 
     def set_up_all(self):
         """
@@ -79,6 +79,13 @@ class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
         if 'packet_sizes' in self.get_suite_cfg():
             self.frame_sizes = self.get_suite_cfg()['packet_sizes']
 
+        self.out_path = '/tmp'
+        out = self.tester.send_expect('ls -d %s' % self.out_path, '# ')
+        if 'No such file or directory' in out:
+            self.tester.send_expect('mkdir -p %s' % self.out_path, '# ')
+        # create an instance to set stream field setting
+        self.pktgen_helper = PacketGeneratorHelper()
+
     def set_up(self):
         """
         Run before each test case.
@@ -92,21 +99,6 @@ class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
         self.vhost_user = self.dut.new_session(suite="vhost-user")
         self.virtio_user = self.dut.new_session(suite="virtio-user")
 
-    def ip(self, port, frag, src, proto, tos, dst, chksum, len, options, version, flags, ihl, ttl, id):
-        """
-        Configure IP protocol.
-        """
-        self.add_tcl_cmd("protocol config -name ip")
-        self.add_tcl_cmd('ip config -sourceIpAddr "%s"' % src)
-        self.add_tcl_cmd('ip config -destIpAddrMode ipRandom')
-        self.add_tcl_cmd("ip config -ttl %d" % ttl)
-        self.add_tcl_cmd("ip config -totalLength %d" % len)
-        self.add_tcl_cmd("ip config -fragment %d" % frag)
-        self.add_tcl_cmd("ip config -ipProtocol %d" % proto)
-        self.add_tcl_cmd("ip config -identifier %d" % id)
-        self.add_tcl_cmd("stream config -framesize %d" % (len + 18))
-        self.add_tcl_cmd("ip set %d %d %d" % (self.chasId, port['card'], port['port']))
-
     def start_vhost_testpmd(self):
         """
         start testpmd on vhost
@@ -166,6 +158,13 @@ class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
 
         self.vhost_user.send_expect("start", "testpmd> ", 60)
 
+    def set_fields(self):
+        """
+        set ip protocol field behavior
+        """
+        fields_config = {'ip':  {'dst': {'action': 'random'}, }, }
+        return fields_config
+
     def send_and_verify(self, case_info):
         """
         start to send packets and calculate avg throughput
@@ -175,11 +174,17 @@ class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
             tgen_input = []
             port = self.tester.get_local_port(self.dut_ports[0])
             self.tester.scapy_append('a=[Ether(dst="%s")/IP(src="0.240.74.101",proto=255)/UDP()/("X"*%d)]' % (self.dst_mac, payload_size))
-            self.tester.scapy_append('wrpcap("multiqueue.pcap", a)')
+            self.tester.scapy_append('wrpcap("%s/multiqueue.pcap" , a)' % self.out_path)
             self.tester.scapy_execute()
 
-            tgen_input.append((port, port, "multiqueue.pcap"))
-            _, pps = self.tester.traffic_generator_throughput(tgen_input)
+            tgen_input.append((port, port, "%s/multiqueue.pcap" % self.out_path))
+
+            vm_config = self.set_fields()
+            self.tester.pktgen.clear_streams()
+            streams = self.pktgen_helper.prepare_stream_from_tginput(tgen_input, 100, vm_config, self.tester.pktgen)
+            # set traffic option
+            traffic_opt = {'delay': 5, 'duration': 20}
+            _, pps = self.tester.pktgen.measure_throughput(stream_ids=streams, options=traffic_opt)
             Mpps = pps / 1000000.0
             self.verify(Mpps > 0, "can not receive packets of frame size %d" % (frame_size))
             throughput = Mpps * 100 / \
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code to support trex
  2019-08-14 17:35 [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code to support trex lihong
@ 2019-08-20  2:37 ` Wang, Yinan
  2019-08-28 10:06 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Wang, Yinan @ 2019-08-20  2:37 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: 2019^[$BG/^[(B8^[$B7n^[(B15^[$BF|^[(B 1:36
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code to
> support trex
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_pvp_virtio_user_multi_queues.py | 45
> ++++++++++++++-----------
>  1 file changed, 25 insertions(+), 20 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_user_multi_queues.py
> b/tests/TestSuite_pvp_virtio_user_multi_queues.py
> index ebe65ba..ff8a0c4 100644
> --- a/tests/TestSuite_pvp_virtio_user_multi_queues.py
> +++ b/tests/TestSuite_pvp_virtio_user_multi_queues.py
> @@ -42,10 +42,10 @@ import time
>  import re
>  from settings import HEADER_SIZE
>  from test_case import TestCase
> -from etgen import IxiaPacketGenerator
> +from pktgen import PacketGeneratorHelper
> 
> 
> -class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
> +class TestPVPVirtioMultiQueues(TestCase):
> 
>      def set_up_all(self):
>          """
> @@ -79,6 +79,13 @@ class TestPVPVirtioMultiQueues(TestCase,
> IxiaPacketGenerator):
>          if 'packet_sizes' in self.get_suite_cfg():
>              self.frame_sizes = self.get_suite_cfg()['packet_sizes']
> 
> +        self.out_path = '/tmp'
> +        out = self.tester.send_expect('ls -d %s' % self.out_path, '# ')
> +        if 'No such file or directory' in out:
> +            self.tester.send_expect('mkdir -p %s' % self.out_path, '# ')
> +        # create an instance to set stream field setting
> +        self.pktgen_helper = PacketGeneratorHelper()
> +
>      def set_up(self):
>          """
>          Run before each test case.
> @@ -92,21 +99,6 @@ class TestPVPVirtioMultiQueues(TestCase,
> IxiaPacketGenerator):
>          self.vhost_user = self.dut.new_session(suite="vhost-user")
>          self.virtio_user = self.dut.new_session(suite="virtio-user")
> 
> -    def ip(self, port, frag, src, proto, tos, dst, chksum, len, options, version, flags,
> ihl, ttl, id):
> -        """
> -        Configure IP protocol.
> -        """
> -        self.add_tcl_cmd("protocol config -name ip")
> -        self.add_tcl_cmd('ip config -sourceIpAddr "%s"' % src)
> -        self.add_tcl_cmd('ip config -destIpAddrMode ipRandom')
> -        self.add_tcl_cmd("ip config -ttl %d" % ttl)
> -        self.add_tcl_cmd("ip config -totalLength %d" % len)
> -        self.add_tcl_cmd("ip config -fragment %d" % frag)
> -        self.add_tcl_cmd("ip config -ipProtocol %d" % proto)
> -        self.add_tcl_cmd("ip config -identifier %d" % id)
> -        self.add_tcl_cmd("stream config -framesize %d" % (len + 18))
> -        self.add_tcl_cmd("ip set %d %d %d" % (self.chasId, port['card'],
> port['port']))
> -
>      def start_vhost_testpmd(self):
>          """
>          start testpmd on vhost
> @@ -166,6 +158,13 @@ class TestPVPVirtioMultiQueues(TestCase,
> IxiaPacketGenerator):
> 
>          self.vhost_user.send_expect("start", "testpmd> ", 60)
> 
> +    def set_fields(self):
> +        """
> +        set ip protocol field behavior
> +        """
> +        fields_config = {'ip':  {'dst': {'action': 'random'}, }, }
> +        return fields_config
> +
>      def send_and_verify(self, case_info):
>          """
>          start to send packets and calculate avg throughput @@ -175,11 +174,17
> @@ class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
>              tgen_input = []
>              port = self.tester.get_local_port(self.dut_ports[0])
> 
> self.tester.scapy_append('a=[Ether(dst="%s")/IP(src="0.240.74.101",proto=255)/
> UDP()/("X"*%d)]' % (self.dst_mac, payload_size))
> -            self.tester.scapy_append('wrpcap("multiqueue.pcap", a)')
> +            self.tester.scapy_append('wrpcap("%s/multiqueue.pcap" , a)'
> + % self.out_path)
>              self.tester.scapy_execute()
> 
> -            tgen_input.append((port, port, "multiqueue.pcap"))
> -            _, pps = self.tester.traffic_generator_throughput(tgen_input)
> +            tgen_input.append((port, port, "%s/multiqueue.pcap" %
> + self.out_path))
> +
> +            vm_config = self.set_fields()
> +            self.tester.pktgen.clear_streams()
> +            streams =
> self.pktgen_helper.prepare_stream_from_tginput(tgen_input, 100, vm_config,
> self.tester.pktgen)
> +            # set traffic option
> +            traffic_opt = {'delay': 5, 'duration': 20}
> +            _, pps =
> + self.tester.pktgen.measure_throughput(stream_ids=streams,
> + options=traffic_opt)
>              Mpps = pps / 1000000.0
>              self.verify(Mpps > 0, "can not receive packets of frame size %d" %
> (frame_size))
>              throughput = Mpps * 100 / \
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code to support trex
  2019-08-14 17:35 [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code to support trex lihong
  2019-08-20  2:37 ` Wang, Yinan
@ 2019-08-28 10:06 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-08-28 10:06 UTC (permalink / raw)
  To: Ma, LihongX, dts; +Cc: Ma, LihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Thursday, August 15, 2019 1:36 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code
> to support trex
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  tests/TestSuite_pvp_virtio_user_multi_queues.py | 45 ++++++++++++++------
> -----
>  1 file changed, 25 insertions(+), 20 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_virtio_user_multi_queues.py
> b/tests/TestSuite_pvp_virtio_user_multi_queues.py
> index ebe65ba..ff8a0c4 100644
> --- a/tests/TestSuite_pvp_virtio_user_multi_queues.py
> +++ b/tests/TestSuite_pvp_virtio_user_multi_queues.py
> @@ -42,10 +42,10 @@ import time
>  import re
>  from settings import HEADER_SIZE
>  from test_case import TestCase
> -from etgen import IxiaPacketGenerator
> +from pktgen import PacketGeneratorHelper
> 
> 
> -class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
> +class TestPVPVirtioMultiQueues(TestCase):
> 
>      def set_up_all(self):
>          """
> @@ -79,6 +79,13 @@ class TestPVPVirtioMultiQueues(TestCase,
> IxiaPacketGenerator):
>          if 'packet_sizes' in self.get_suite_cfg():
>              self.frame_sizes = self.get_suite_cfg()['packet_sizes']
> 
> +        self.out_path = '/tmp'
> +        out = self.tester.send_expect('ls -d %s' % self.out_path, '# ')
> +        if 'No such file or directory' in out:
> +            self.tester.send_expect('mkdir -p %s' % self.out_path, '# ')
> +        # create an instance to set stream field setting
> +        self.pktgen_helper = PacketGeneratorHelper()
> +
>      def set_up(self):
>          """
>          Run before each test case.
> @@ -92,21 +99,6 @@ class TestPVPVirtioMultiQueues(TestCase,
> IxiaPacketGenerator):
>          self.vhost_user = self.dut.new_session(suite="vhost-user")
>          self.virtio_user = self.dut.new_session(suite="virtio-user")
> 
> -    def ip(self, port, frag, src, proto, tos, dst, chksum, len, options, version,
> flags, ihl, ttl, id):
> -        """
> -        Configure IP protocol.
> -        """
> -        self.add_tcl_cmd("protocol config -name ip")
> -        self.add_tcl_cmd('ip config -sourceIpAddr "%s"' % src)
> -        self.add_tcl_cmd('ip config -destIpAddrMode ipRandom')
> -        self.add_tcl_cmd("ip config -ttl %d" % ttl)
> -        self.add_tcl_cmd("ip config -totalLength %d" % len)
> -        self.add_tcl_cmd("ip config -fragment %d" % frag)
> -        self.add_tcl_cmd("ip config -ipProtocol %d" % proto)
> -        self.add_tcl_cmd("ip config -identifier %d" % id)
> -        self.add_tcl_cmd("stream config -framesize %d" % (len + 18))
> -        self.add_tcl_cmd("ip set %d %d %d" % (self.chasId, port['card'],
> port['port']))
> -
>      def start_vhost_testpmd(self):
>          """
>          start testpmd on vhost
> @@ -166,6 +158,13 @@ class TestPVPVirtioMultiQueues(TestCase,
> IxiaPacketGenerator):
> 
>          self.vhost_user.send_expect("start", "testpmd> ", 60)
> 
> +    def set_fields(self):
> +        """
> +        set ip protocol field behavior
> +        """
> +        fields_config = {'ip':  {'dst': {'action': 'random'}, }, }
> +        return fields_config
> +
>      def send_and_verify(self, case_info):
>          """
>          start to send packets and calculate avg throughput @@ -175,11
> +174,17 @@ class TestPVPVirtioMultiQueues(TestCase, IxiaPacketGenerator):
>              tgen_input = []
>              port = self.tester.get_local_port(self.dut_ports[0])
> 
> self.tester.scapy_append('a=[Ether(dst="%s")/IP(src="0.240.74.101",proto=25
> 5)/UDP()/("X"*%d)]' % (self.dst_mac, payload_size))
> -            self.tester.scapy_append('wrpcap("multiqueue.pcap", a)')
> +            self.tester.scapy_append('wrpcap("%s/multiqueue.pcap" , a)'
> + % self.out_path)
>              self.tester.scapy_execute()
> 
> -            tgen_input.append((port, port, "multiqueue.pcap"))
> -            _, pps = self.tester.traffic_generator_throughput(tgen_input)
> +            tgen_input.append((port, port, "%s/multiqueue.pcap" %
> + self.out_path))
> +
> +            vm_config = self.set_fields()
> +            self.tester.pktgen.clear_streams()
> +            streams =
> self.pktgen_helper.prepare_stream_from_tginput(tgen_input, 100,
> vm_config, self.tester.pktgen)
> +            # set traffic option
> +            traffic_opt = {'delay': 5, 'duration': 20}
> +            _, pps =
> + self.tester.pktgen.measure_throughput(stream_ids=streams,
> + options=traffic_opt)
>              Mpps = pps / 1000000.0
>              self.verify(Mpps > 0, "can not receive packets of frame size %d" %
> (frame_size))
>              throughput = Mpps * 100 / \
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-14 17:35 [dts] [PATCH V1] tests/pvp_virtio_user_multi_queues: update code to support trex lihong
2019-08-20  2:37 ` Wang, Yinan
2019-08-28 10:06 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox