test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] TestSuite_ipv4_reassembly.py: Corrected dest mac address with correct mac
@ 2019-08-19  3:52 nareddy
  2019-08-28 10:26 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: nareddy @ 2019-08-19  3:52 UTC (permalink / raw)
  To: dts; +Cc: fmasood, avijay, Praneeth Reddy

From: Praneeth Reddy <nareddy@marvell.com>

Corrected dest mac with DUT ports mac address

Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
---
 tests/TestSuite_ipv4_reassembly.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_ipv4_reassembly.py b/tests/TestSuite_ipv4_reassembly.py
index 54412eb..3f33809 100644
--- a/tests/TestSuite_ipv4_reassembly.py
+++ b/tests/TestSuite_ipv4_reassembly.py
@@ -134,7 +134,7 @@ class TestIpReassembly(TestCase):
 
         packet = Ether() / IP() / TCP() / ("X" * self.test_config.payload_size)
         packet[Ether].src = self.test_config.mac_src
-        packet[Ether].dst = self.test_config.mac_dst
+        packet[Ether].dst = self.destination_mac
         packet[IP].src = src_ip
         packet[IP].dst = self.test_config.dst_ip
         packet[IP].id = identifier
@@ -366,6 +366,9 @@ class TestIpReassembly(TestCase):
 
         self.tester.send_expect('export PS1="# "', '#')
         self.compile_example_app()
+        dut_ports = self.dut.get_ports(self.nic)
+        dut_port = dut_ports[0]
+        self.destination_mac = self.dut.get_mac_address(dut_port)
 
     def test_send_1K_frames_split_in_4_and_1K_maxflows(self):
         """
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] TestSuite_ipv4_reassembly.py: Corrected dest mac address with correct mac
  2019-08-19  3:52 [dts] [PATCH] TestSuite_ipv4_reassembly.py: Corrected dest mac address with correct mac nareddy
@ 2019-08-28 10:26 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-08-28 10:26 UTC (permalink / raw)
  To: nareddy, dts; +Cc: fmasood, avijay

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, August 19, 2019 11:53 AM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_ipv4_reassembly.py: Corrected dest mac
> address with correct mac
> 
> From: Praneeth Reddy <nareddy@marvell.com>
> 
> Corrected dest mac with DUT ports mac address
> 
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  tests/TestSuite_ipv4_reassembly.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_ipv4_reassembly.py
> b/tests/TestSuite_ipv4_reassembly.py
> index 54412eb..3f33809 100644
> --- a/tests/TestSuite_ipv4_reassembly.py
> +++ b/tests/TestSuite_ipv4_reassembly.py
> @@ -134,7 +134,7 @@ class TestIpReassembly(TestCase):
> 
>          packet = Ether() / IP() / TCP() / ("X" * self.test_config.payload_size)
>          packet[Ether].src = self.test_config.mac_src
> -        packet[Ether].dst = self.test_config.mac_dst
> +        packet[Ether].dst = self.destination_mac
>          packet[IP].src = src_ip
>          packet[IP].dst = self.test_config.dst_ip
>          packet[IP].id = identifier
> @@ -366,6 +366,9 @@ class TestIpReassembly(TestCase):
> 
>          self.tester.send_expect('export PS1="# "', '#')
>          self.compile_example_app()
> +        dut_ports = self.dut.get_ports(self.nic)
> +        dut_port = dut_ports[0]
> +        self.destination_mac = self.dut.get_mac_address(dut_port)
> 
>      def test_send_1K_frames_split_in_4_and_1K_maxflows(self):
>          """
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19  3:52 [dts] [PATCH] TestSuite_ipv4_reassembly.py: Corrected dest mac address with correct mac nareddy
2019-08-28 10:26 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox