test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w
  2019-08-19 19:09 [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w Wenjie Li
@ 2019-08-19 10:17 ` Li, WenjieX A
  2019-08-30  2:57 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Li, WenjieX A @ 2019-08-19 10:17 UTC (permalink / raw)
  To: dts; +Cc: Li, WenjieX A

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Tuesday, August 20, 2019 3:09 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] tests/enable_package_download_in_ice_driver:add all
> ports with -w
> 
> Should add ALL ports with -w parameter.
> If the nic has 4 ports, all ports should be bind with -w; otherwise, the ports will
> be down in testpmd.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_enable_package_download_in_ice_driver.py | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py
> b/tests/TestSuite_enable_package_download_in_ice_driver.py
> index 9197198..b225ef3 100644
> --- a/tests/TestSuite_enable_package_download_in_ice_driver.py
> +++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
> @@ -54,9 +54,6 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>          self.tester_p0_mac = self.tester.get_mac(localPort0)
>          self.dut_testpmd = PmdOutput(self.dut)
> 
> -        self.dut_p0_pci = self.dut.get_port_pci(self.dut_ports[0])
> -        self.dut_p1_pci = self.dut.get_port_pci(self.dut_ports[1])
> -
>          self.pkg_file = '/lib/firmware/intel/ice/ddp/ice.pkg'
>          out = self.dut.send_expect("ls %s" % self.pkg_file, "#")
>          self.verify("No such file or directory" not in out, "Cannot find %s, please
> check you system/driver." % self.pkg_file) @@ -88,10 +85,10 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>              self.dut.send_expect("touch %s" % self.pkg_file, "#")
> 
>      def start_testpmd(self, ice_pkg="true", safe_mode_support="false"):
> +        self.eal_param = ""
>          if safe_mode_support == "true":
> -            self.eal_param="-w %s,safe-mode-support=1 -w %s,safe-mode-
> support=1" % (self.dut_p0_pci, self.dut_p1_pci)
> -        else:
> -            self.eal_param=""
> +            for i in range(len(self.dut_ports)):
> +                self.eal_param = self.eal_param + "-w
> + %s,safe-mode-support=1 " % self.dut.ports_info[i]['pci']
>          out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --
> txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE),
> eal_param=self.eal_param)
>          if ice_pkg == "false":
>              if safe_mode_support == "true":
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w
@ 2019-08-19 19:09 Wenjie Li
  2019-08-19 10:17 ` Li, WenjieX A
  2019-08-30  2:57 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-08-19 19:09 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

Should add ALL ports with -w parameter.
If the nic has 4 ports, all ports should be bind with -w; otherwise, the
ports will be down in testpmd.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_enable_package_download_in_ice_driver.py | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py b/tests/TestSuite_enable_package_download_in_ice_driver.py
index 9197198..b225ef3 100644
--- a/tests/TestSuite_enable_package_download_in_ice_driver.py
+++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
@@ -54,9 +54,6 @@ class TestEnable_Package_Download_In_Ice_Driver(TestCase):
         self.tester_p0_mac = self.tester.get_mac(localPort0)
         self.dut_testpmd = PmdOutput(self.dut)
 
-        self.dut_p0_pci = self.dut.get_port_pci(self.dut_ports[0])
-        self.dut_p1_pci = self.dut.get_port_pci(self.dut_ports[1])
-
         self.pkg_file = '/lib/firmware/intel/ice/ddp/ice.pkg'
         out = self.dut.send_expect("ls %s" % self.pkg_file, "#")
         self.verify("No such file or directory" not in out, "Cannot find %s, please check you system/driver." % self.pkg_file)
@@ -88,10 +85,10 @@ class TestEnable_Package_Download_In_Ice_Driver(TestCase):
             self.dut.send_expect("touch %s" % self.pkg_file, "#")
 
     def start_testpmd(self, ice_pkg="true", safe_mode_support="false"):
+        self.eal_param = ""
         if safe_mode_support == "true":
-            self.eal_param="-w %s,safe-mode-support=1 -w %s,safe-mode-support=1" % (self.dut_p0_pci, self.dut_p1_pci)
-        else:
-            self.eal_param=""
+            for i in range(len(self.dut_ports)):
+                self.eal_param = self.eal_param + "-w %s,safe-mode-support=1 " % self.dut.ports_info[i]['pci']
         out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE), eal_param=self.eal_param)
         if ice_pkg == "false":
             if safe_mode_support == "true":
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w
  2019-08-19 19:09 [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w Wenjie Li
  2019-08-19 10:17 ` Li, WenjieX A
@ 2019-08-30  2:57 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-08-30  2:57 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Tuesday, August 20, 2019 3:09 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add
> all ports with -w
> 
> Should add ALL ports with -w parameter.
> If the nic has 4 ports, all ports should be bind with -w; otherwise, the ports
> will be down in testpmd.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_enable_package_download_in_ice_driver.py | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_enable_package_download_in_ice_driver.py
> b/tests/TestSuite_enable_package_download_in_ice_driver.py
> index 9197198..b225ef3 100644
> --- a/tests/TestSuite_enable_package_download_in_ice_driver.py
> +++ b/tests/TestSuite_enable_package_download_in_ice_driver.py
> @@ -54,9 +54,6 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>          self.tester_p0_mac = self.tester.get_mac(localPort0)
>          self.dut_testpmd = PmdOutput(self.dut)
> 
> -        self.dut_p0_pci = self.dut.get_port_pci(self.dut_ports[0])
> -        self.dut_p1_pci = self.dut.get_port_pci(self.dut_ports[1])
> -
>          self.pkg_file = '/lib/firmware/intel/ice/ddp/ice.pkg'
>          out = self.dut.send_expect("ls %s" % self.pkg_file, "#")
>          self.verify("No such file or directory" not in out, "Cannot find %s, please
> check you system/driver." % self.pkg_file) @@ -88,10 +85,10 @@ class
> TestEnable_Package_Download_In_Ice_Driver(TestCase):
>              self.dut.send_expect("touch %s" % self.pkg_file, "#")
> 
>      def start_testpmd(self, ice_pkg="true", safe_mode_support="false"):
> +        self.eal_param = ""
>          if safe_mode_support == "true":
> -            self.eal_param="-w %s,safe-mode-support=1 -w %s,safe-mode-
> support=1" % (self.dut_p0_pci, self.dut_p1_pci)
> -        else:
> -            self.eal_param=""
> +            for i in range(len(self.dut_ports)):
> +                self.eal_param = self.eal_param + "-w
> + %s,safe-mode-support=1 " % self.dut.ports_info[i]['pci']
>          out = self.dut_testpmd.start_testpmd("all", "--nb-cores=8 --rxq=%s --
> txq=%s --port-topology=chained" % (self.PF_QUEUE, self.PF_QUEUE),
> eal_param=self.eal_param)
>          if ice_pkg == "false":
>              if safe_mode_support == "true":
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 19:09 [dts] [PATCH V1] tests/enable_package_download_in_ice_driver:add all ports with -w Wenjie Li
2019-08-19 10:17 ` Li, WenjieX A
2019-08-30  2:57 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox