test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] tests: modify the cmd of tester bind driver
@ 2019-08-22 23:55 Xinfeng Zhao
  2019-08-23  8:10 ` Zhao, XinfengX
  2019-09-04  4:53 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xinfeng Zhao @ 2019-08-22 23:55 UTC (permalink / raw)
  To: dts; +Cc: Xinfeng Zhao

add "--force" in binding command to allow active links to be bind,
and modify the bind back cmd

Signed-off-by: Xinfeng Zhao <xinfengx.zhao@intel.com>
---
 tests/TestSuite_vf_port_start_stop.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vf_port_start_stop.py b/tests/TestSuite_vf_port_start_stop.py
index 7cb797b..2ff2d1c 100644
--- a/tests/TestSuite_vf_port_start_stop.py
+++ b/tests/TestSuite_vf_port_start_stop.py
@@ -85,7 +85,7 @@ class TestVfPortStartStop(TestCase):
         self.tester_tx_pci = self.tester.ports_info[self.tester_tx_port]['pci']
         port = self.tester.ports_info[self.tester_tx_port]['port']
         self.tester_port_driver = port.get_nic_driver()
-        self.tester.send_expect("./dpdk-devbind.py --bind=igb_uio %s" % self.tester_tx_pci, "#")
+        self.tester.send_expect("./dpdk-devbind.py --force --bind=igb_uio %s" % self.tester_tx_pci, "#")
 
         src_mac = self.tester.get_mac(self.tester_tx_port) 
         if src_mac == 'N/A':
@@ -245,7 +245,7 @@ class TestVfPortStartStop(TestCase):
         self.pktgen_kill()
         if getattr(self, 'tester_port_driver', None) and \
            getattr(self, 'tester_tx_pci', None):
-            self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
+            self.tester.send_expect("./dpdk-devbind.py --bind=%s %s" \
                 %(self.tester_port_driver, self.tester_tx_pci), "#")
             tx_interface = self.tester.get_interface(self.tester_tx_port)
             self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests: modify the cmd of tester bind driver
  2019-08-22 23:55 [dts] [PATCH] tests: modify the cmd of tester bind driver Xinfeng Zhao
@ 2019-08-23  8:10 ` Zhao, XinfengX
  2019-09-04  4:53 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhao, XinfengX @ 2019-08-23  8:10 UTC (permalink / raw)
  To: dts

Tested-by: Zhao, XinfengX <xinfengx.zhao@intel.com>

-----Original Message-----
From: Zhao, XinfengX 
Sent: Friday, August 23, 2019 7:55 AM
To: dts@dpdk.org
Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
Subject: [dts][PATCH] tests: modify the cmd of tester bind driver

add "--force" in binding command to allow active links to be bind, and modify the bind back cmd

Signed-off-by: Xinfeng Zhao <xinfengx.zhao@intel.com>
---
 tests/TestSuite_vf_port_start_stop.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vf_port_start_stop.py b/tests/TestSuite_vf_port_start_stop.py
index 7cb797b..2ff2d1c 100644
--- a/tests/TestSuite_vf_port_start_stop.py
+++ b/tests/TestSuite_vf_port_start_stop.py
@@ -85,7 +85,7 @@ class TestVfPortStartStop(TestCase):
         self.tester_tx_pci = self.tester.ports_info[self.tester_tx_port]['pci']
         port = self.tester.ports_info[self.tester_tx_port]['port']
         self.tester_port_driver = port.get_nic_driver()
-        self.tester.send_expect("./dpdk-devbind.py --bind=igb_uio %s" % self.tester_tx_pci, "#")
+        self.tester.send_expect("./dpdk-devbind.py --force 
+ --bind=igb_uio %s" % self.tester_tx_pci, "#")
 
         src_mac = self.tester.get_mac(self.tester_tx_port) 
         if src_mac == 'N/A':
@@ -245,7 +245,7 @@ class TestVfPortStartStop(TestCase):
         self.pktgen_kill()
         if getattr(self, 'tester_port_driver', None) and \
            getattr(self, 'tester_tx_pci', None):
-            self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
+            self.tester.send_expect("./dpdk-devbind.py --bind=%s %s" \
                 %(self.tester_port_driver, self.tester_tx_pci), "#")
             tx_interface = self.tester.get_interface(self.tester_tx_port)
             self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
--
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] tests: modify the cmd of tester bind driver
  2019-08-22 23:55 [dts] [PATCH] tests: modify the cmd of tester bind driver Xinfeng Zhao
  2019-08-23  8:10 ` Zhao, XinfengX
@ 2019-09-04  4:53 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-09-04  4:53 UTC (permalink / raw)
  To: Zhao, XinfengX, dts; +Cc: Zhao, XinfengX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xinfeng Zhao
> Sent: Friday, August 23, 2019 7:55 AM
> To: dts@dpdk.org
> Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
> Subject: [dts] [PATCH] tests: modify the cmd of tester bind driver
> 
> add "--force" in binding command to allow active links to be bind, and
> modify the bind back cmd
> 
> Signed-off-by: Xinfeng Zhao <xinfengx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_port_start_stop.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_port_start_stop.py
> b/tests/TestSuite_vf_port_start_stop.py
> index 7cb797b..2ff2d1c 100644
> --- a/tests/TestSuite_vf_port_start_stop.py
> +++ b/tests/TestSuite_vf_port_start_stop.py
> @@ -85,7 +85,7 @@ class TestVfPortStartStop(TestCase):
>          self.tester_tx_pci = self.tester.ports_info[self.tester_tx_port]['pci']
>          port = self.tester.ports_info[self.tester_tx_port]['port']
>          self.tester_port_driver = port.get_nic_driver()
> -        self.tester.send_expect("./dpdk-devbind.py --bind=igb_uio %s" %
> self.tester_tx_pci, "#")
> +        self.tester.send_expect("./dpdk-devbind.py --force
> + --bind=igb_uio %s" % self.tester_tx_pci, "#")
> 
>          src_mac = self.tester.get_mac(self.tester_tx_port)
>          if src_mac == 'N/A':
> @@ -245,7 +245,7 @@ class TestVfPortStartStop(TestCase):
>          self.pktgen_kill()
>          if getattr(self, 'tester_port_driver', None) and \
>             getattr(self, 'tester_tx_pci', None):
> -            self.tester.send_expect("./dpdk_nic_bind.py --bind=%s %s" \
> +            self.tester.send_expect("./dpdk-devbind.py --bind=%s %s" \
>                  %(self.tester_port_driver, self.tester_tx_pci), "#")
>              tx_interface = self.tester.get_interface(self.tester_tx_port)
>              self.tester.send_expect("ifconfig %s up" % tx_interface, "#")
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-04  4:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 23:55 [dts] [PATCH] tests: modify the cmd of tester bind driver Xinfeng Zhao
2019-08-23  8:10 ` Zhao, XinfengX
2019-09-04  4:53 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).