From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84549A2E1B for ; Wed, 4 Sep 2019 07:00:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 493661BF51; Wed, 4 Sep 2019 07:00:56 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4FB151BF46 for ; Wed, 4 Sep 2019 07:00:54 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 22:00:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,465,1559545200"; d="scan'208";a="184994275" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 03 Sep 2019 22:00:52 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 22:00:52 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 22:00:52 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Wed, 4 Sep 2019 13:00:50 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] tests/tx_preparation: optimize script Thread-Index: AQHVWYoyZFCCvZSShECscnomAIFn7qcbCFQA Date: Wed, 4 Sep 2019 05:00:49 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB1BDF8@SHSMSX101.ccr.corp.intel.com> References: <1566579803-48004-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1566579803-48004-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWMzNzdiNWEtZDYyYy00MjE0LTgzZTAtYzc0ZTFmYjhkZmU0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGNIN3lGd0daWldLd2lrK25McWRRR2NVUG84a0VNWG53Vm9odVpRMVYrRk1MS3FzS3ZEV05xaStEOE9WczFrdiJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/tx_preparation: optimize script X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > Sent: Saturday, August 24, 2019 1:03 AM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts] [PATCH V1] tests/tx_preparation: optimize script >=20 > move stop/quit testpmd into tear_down; otherwise, if one case is failed, = the > testpmd is still running, it will affect the following cases. >=20 > Signed-off-by: Wenjie Li > --- > tests/TestSuite_tx_preparation.py | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) >=20 > diff --git a/tests/TestSuite_tx_preparation.py > b/tests/TestSuite_tx_preparation.py > index eea95c1..ba0aac7 100644 > --- a/tests/TestSuite_tx_preparation.py > +++ b/tests/TestSuite_tx_preparation.py > @@ -173,8 +173,6 @@ class TestTX_preparation(TestCase): > self.dut_testpmd.execute_cmd('start') >=20 > self.send_packet_verify() > - self.dut_testpmd.execute_cmd('stop') > - self.dut_testpmd.quit() >=20 > def test_tx_preparation_TSO(self): > """ > @@ -185,16 +183,13 @@ class TestTX_preparation(TestCase): > self.dut_testpmd.execute_cmd('start') >=20 > self.send_packet_verify(1) > - self.dut_testpmd.execute_cmd('stop') > - self.dut_testpmd.quit() > - >=20 > def tear_down(self): > """ > Run after each test case. > - """ > - pass > - > + """ > + self.dut_testpmd.execute_cmd('stop') > + self.dut_testpmd.quit() >=20 > def tear_down_all(self): > """ > -- > 2.17.1