From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C26DCA2E1B for ; Wed, 4 Sep 2019 07:28:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A6D01EBB7; Wed, 4 Sep 2019 07:28:47 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 0C29C1EBAC for ; Wed, 4 Sep 2019 07:28:45 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 22:28:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,465,1559545200"; d="scan'208";a="190051287" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 03 Sep 2019 22:28:44 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 22:28:44 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Sep 2019 22:28:43 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Sep 2019 22:28:43 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Wed, 4 Sep 2019 13:28:41 +0800 From: "Tu, Lijuan" To: "Mei, JianweiX" , "dts@dpdk.org" CC: "Mei, JianweiX" Thread-Topic: [dts] [PATCH V1] tests/TestSuite_runtime_vf_queue_number update rss-hash-key after command port start all Thread-Index: AQHVXhTVRzX0erHEA0+yFg/wPBiThKcbBvrQ Date: Wed, 4 Sep 2019 05:28:41 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB1C06D@SHSMSX101.ccr.corp.intel.com> References: <1567078834-199209-1-git-send-email-jianweix.mei@intel.com> In-Reply-To: <1567078834-199209-1-git-send-email-jianweix.mei@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzEwZmE2NGQtZTM0NC00NzI3LWFhMDItZjljNmViZWYwNWQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMEVZWndHMGR2b1VacjlqSmdnK1BKbmlCeHFUbDhYRXhLd3RRZThEN1I3aUluK0w3OE5xc2llUENSTXA0VnNyeSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/TestSuite_runtime_vf_queue_number update rss-hash-key after command port start all X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied failed, could you please rework it. Thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei > Sent: Thursday, August 29, 2019 7:41 PM > To: dts@dpdk.org > Cc: Mei, JianweiX > Subject: [dts] [PATCH V1] tests/TestSuite_runtime_vf_queue_number update > rss-hash-key after command port start all >=20 > set rss-hash key after execute port start all and reduce packet count to = save > time. >=20 > Signed-off-by: Jianwei Mei > --- > tests/TestSuite_runtime_vf_queue_number.py | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) >=20 > diff --git a/tests/TestSuite_runtime_vf_queue_number.py > b/tests/TestSuite_runtime_vf_queue_number.py > index 3e04489..f484f70 100644 > --- a/tests/TestSuite_runtime_vf_queue_number.py > +++ b/tests/TestSuite_runtime_vf_queue_number.py > @@ -41,6 +41,7 @@ from test_case import TestCase from pmd_output > import PmdOutput >=20 > RSS_KEY =3D > '6EA6A420D5138E712433B813AE45B3C4BECB2B405F31AD6C331835372D15E2 > D5E49566EE0ED1962AFA1B7932F3549520FD71C75E' > +PACKET_COUNT =3D 100 >=20 > class TestRuntimeVfQn(TestCase): > supported_vf_driver =3D ['pci-stub', 'vfio-pci'] @@ -48,7 +49,7 @@ c= lass > TestRuntimeVfQn(TestCase): > self.dut_ports =3D self.dut.get_ports(self.nic) > self.verify(len(self.dut_ports) >=3D 1, 'Insufficient ports') > self.src_intf =3D self.tester.get_interface(self.tester.get_loca= l_port(0)) > - self.src_mac =3D self.tester.get_mac(self.tester.get_local_port= (0)) > + self.src_mac =3D > + self.tester.get_mac(self.tester.get_local_port(0)) > self.dst_mac =3D self.dut.get_mac_address(0) > self.vm0 =3D None > self.pf_pci =3D self.dut.ports_info[self.dut_ports[0]]['pci'] > @@ -187,10 +188,10 @@ class TestRuntimeVfQn(TestCase): > def testpmd_config_cmd_list(self, qn): > cmd_list =3D [['stop'], > ['port stop all'], > - ['port config 0 rss-hash-key ipv4 %s' % RSS_KEY], > ['port config all txq %d' % qn], > ['port config all rxq %d' % qn], > - ['port start all']] > + ['port start all'], > + ['port config 0 rss-hash-key ipv4 %s' % RSS_KEY]] > return cmd_list >=20 > def verify_result(self, queue_num, pkt_num): > @@ -225,7 +226,6 @@ class TestRuntimeVfQn(TestCase): > for qn in valid_qn: > host_eal_param =3D '-w %s,queue-num-per-vf=3D%d --file-prefi= x=3Dtest1 -- > socket-mem 1024,1024' % (self.pf_pci, qn) > self.host_testpmd.start_testpmd(self.pmdout.default_cores, > param=3D'', eal_param=3Dhost_eal_param) > - > gest_eal_param =3D '-w %s --file-prefix=3Dtest2' % > self.vm_dut_0.ports_info[0]['pci'] > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > self.vm0_testpmd.start_testpmd(self.pmdout.default_cores, > eal_param=3Dgest_eal_param, param=3D'') @@ -236,18 +236,18 @@ class > TestRuntimeVfQn(TestCase): > self.verify("port 0: RX queue number: %d Tx queue number: %d= " % > (qn, qn) in outstring, "The RX/TX queue number error.") > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > self.vf_mac =3D self.vm0_testpmd.get_port_mac(self.vm0_dut_p= orts[0]) > - self.send_packet(self.vf_mac, self.src_intf, 100) > + self.send_packet(self.vf_mac, self.src_intf, PACKET_COUNT) > outstring1 =3D self.vm0_testpmd.execute_cmd("stop", "testpmd= > ") > - self.verify_queue_number(outstring1, qn, 100) > + self.verify_queue_number(outstring1, qn, PACKET_COUNT) > guest_cmds1 =3D self.testpmd_config_cmd_list(qn + 1) > self.execute_testpmd_cmd(guest_cmds1) > outstring2 =3D self.vm0_testpmd.execute_cmd("start", "testpm= d> ") > self.logger.info(outstring2) > self.verify("port 0: RX queue number: %d Tx queue number: %d= " % > ((qn + 1), (qn + 1)) in outstring2, "The RX/TX queue number error.") > - self.send_packet(self.vf_mac, self.src_intf, 254) > + self.send_packet(self.vf_mac, self.src_intf, PACKET_COUNT) > outstring3 =3D self.vm0_testpmd.execute_cmd("stop", "testpmd= > ") > self.logger.info(outstring3) > - self.verify_queue_number(outstring3, qn + 1, 254) > + self.verify_queue_number(outstring3, qn + 1, PACKET_COUNT) > self.vm0_testpmd.execute_cmd('quit', '# ') > self.dut.send_expect("quit", "# ") >=20 > @@ -279,7 +279,7 @@ class TestRuntimeVfQn(TestCase): > self.vm0_testpmd.execute_cmd("set promisc all off", "tes= tpmd> ") > self.vm0_testpmd.execute_cmd("set fwd mac", "testpmd> ") > self.vm0_testpmd.execute_cmd('port config 0 rss-hash-key > ipv4 %s' % RSS_KEY) > - self.verify_result(valid_qn, 500) > + self.verify_result(valid_qn, PACKET_COUNT) > self.vm0_testpmd.execute_cmd('quit', '# ') > else: > self.vm0_testpmd.start_testpmd(self.pmdout.default_cores= , > eal_param=3Dgest_eal_param, @@ -287,7 +287,7 @@ class > TestRuntimeVfQn(TestCase): > self.vm0_testpmd.execute_cmd("set promisc all off", "tes= tpmd> ") > self.vm0_testpmd.execute_cmd("set fwd mac", "testpmd> ") > self.vm0_testpmd.execute_cmd('port config 0 rss-hash-key > ipv4 %s' % RSS_KEY) > - self.verify_result(valid_qn, 500) > + self.verify_result(valid_qn, PACKET_COUNT) > self.vm0_testpmd.execute_cmd('quit', '# ') >=20 > def test_set_invalid_vf_qn_in_testpmd(self): > @@ -329,13 +329,13 @@ class TestRuntimeVfQn(TestCase): > guest_cmds.insert(0, ['set promisc all off']) > guest_cmds.insert(0, ['set verbose 1']) > self.execute_testpmd_cmd(guest_cmds) > - self.verify_result(valid_qn, 500) > + self.verify_result(valid_qn, PACKET_COUNT) > else: > guest_cmds =3D self.testpmd_config_cmd_list(valid_qn) > guest_cmds.insert(0, ['set fwd mac']) > guest_cmds.insert(0, ['set promisc all off']) > self.execute_testpmd_cmd(guest_cmds) > - self.verify_result(valid_qn, 500) > + self.verify_result(valid_qn, PACKET_COUNT) > self.vm0_testpmd.execute_cmd('quit', '# ') >=20 > def test_set_invalid_vf_qn_with_testpmd_func_cmd(self): > -- > 1.8.3.1