From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F629A2EFC for ; Wed, 18 Sep 2019 07:32:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 247B01BF83; Wed, 18 Sep 2019 07:32:17 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id BCAD41BF81 for ; Wed, 18 Sep 2019 07:32:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 22:32:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,519,1559545200"; d="scan'208";a="191614036" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 17 Sep 2019 22:32:14 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 22:32:14 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 22:32:13 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Wed, 18 Sep 2019 13:32:12 +0800 From: "Tu, Lijuan" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V1] tests/dpdk_gso_lib:Put the same case to suite Thread-Index: AQHVY8BuxfktriUeo06cBb18TBDgBacw+Kqw Date: Wed, 18 Sep 2019 05:32:11 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB23AE2@SHSMSX101.ccr.corp.intel.com> References: <1567670875-149095-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1567670875-149095-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjgzOTNhNGItYzEyOS00MjQ5LThkMmQtYTdmNDNmY2UwY2Y3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNDdqNkc1QTJoV2UxWUp2U1BmZGlTQllhWmtlUUdhTEJBWG1zNFlJM085Q3B3bENGWUdlQ3pXaFJtcmlCbVpFTyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/dpdk_gso_lib:Put the same case to suite X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Disagree with the patch 1, This test suite called dpdk_gso_lib, it is meant the test cases if for G= SO library, virtio_user_as_exeptional_path is not partial of it. 2, why you called "the same case" in the subject and comment. Exceptional p= ath and gso are obviously different cases. 3, I saw moved 2 cases from virtio_user_as_exeptional_path to dpdk_gso_lib = ,but does not remove it from the original file. Also, I don't found any cha= nge at test plan. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui > Sent: Thursday, September 5, 2019 4:08 PM > To: dts@dpdk.org > Cc: Zhu, WenhuiX > Subject: [dts] [PATCH V1] tests/dpdk_gso_lib:Put the same case to suite >=20 > Due to the different topology of cases in virtio_user_as_exceptional_path= . > Put the same case as the dpdk_gso_lib topology into dpdk_gso_lib >=20 > Signed-off-by: zhuwenhui > --- > tests/TestSuite_dpdk_gso_lib.py | 103 +++++++++++++++++++++++++++++++- > 1 file changed, 102 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_dpdk_gso_lib.py > b/tests/TestSuite_dpdk_gso_lib.py index 68d09cb..fd50ba5 100644 > --- a/tests/TestSuite_dpdk_gso_lib.py > +++ b/tests/TestSuite_dpdk_gso_lib.py > @@ -207,6 +207,14 @@ class TestDPDKGsoLib(TestCase): > "ip netns exec ns1 ifconfig gre100 1.1.1.1/24 up", > "#") >=20 > + def config_kernel_nic_host_for_exception_path(self): > + self.dut.send_expect("ip netns del ns1", "#") > + self.dut.send_expect("ip netns add ns1", "#") > + self.dut.send_expect("ip link set %s netns ns1" % self.nic_in_ke= rnel, "#") > + self.dut.send_expect("ip netns exec ns1 ifconfig %s 1.1.1.8 up" = % > self.nic_in_kernel, "#") > + self.dut.send_expect("ip netns exec ns1 ethtool -K %s gro on" % > self.nic_in_kernel, "#") > + self.dut.send_expect("ip netns exec ns1 ethtool -K %s tso on" % > + self.nic_in_kernel, "#") > + > def prepare_dpdk(self): > # Changhe the testpmd checksum fwd code for mac change > self.dut.send_expect( > @@ -282,18 +290,59 @@ class TestDPDKGsoLib(TestCase): > print iperfdata > self.verify(iperfdata, 'There no data about this case') > self.result_table_create(['Data', 'Unit']) > - results_row =3D ['GSO'] > + if self.type_row =3D=3D "exception_path": > + results_row =3D ['exception path'] > + else: > + results_row =3D ['GSO'] > results_row.append(iperfdata[-1]) > self.result_table_add(results_row) > self.result_table_print() > self.output_result =3D "Iperf throughput is %s" % iperfdata[-1] > self.logger.info(self.output_result) >=20 > + def launch_testpmd_exception_path(self): > + self.testcmd =3D self.target + "/app/testpmd -c %s -n %d --socke= t-mem %s > --legacy-mem" \ > + + " --vdev=3Dvirtio_user0,mac=3D%s,path=3D/dev/vhost- > net,queue_size=3D1024 -- -i" \ > + + " --rxd=3D1024 --txd=3D1024" > + self.cores =3D self.dut.get_core_list("1S/2C/1T", socket=3Dself.= socket) > + self.coremask =3D utils.create_mask(self.cores) > + self.testcmd_start =3D self.testcmd % (self.coremask, > self.memory_channel, > + self.socket_mem, self.virtio_mac1) > + self.vhost_user =3D self.dut.new_session(suite=3D"user") > + self.vhost_user.send_expect("modprobe vhost-net", "#", 120) > + self.vhost_user.send_expect(self.testcmd_start, "testpmd> ", 120= ) > + self.vhost_user.send_expect("set fwd csum", "testpmd> ", 120) > + self.vhost_user.send_expect("stop", "testpmd> ", 120) > + self.vhost_user.send_expect("port stop 0", "testpmd> ", 120) > + self.vhost_user.send_expect("port stop 1", "testpmd> ", 120) > + self.vhost_user.send_expect("port config 0 tx_offload tcp_cksum = on", > "testpmd> ", 120) > + self.vhost_user.send_expect("port config 0 tx_offload ipv4_cksum= on", > "testpmd> ", 120) > + self.vhost_user.send_expect("csum set ip sw 1", "testpmd> ", 120= ) > + self.vhost_user.send_expect("csum set tcp hw 1", "testpmd> ", 12= 0) > + self.vhost_user.send_expect("csum set ip hw 0", "testpmd> ", 120= ) > + self.vhost_user.send_expect("csum set tcp hw 0", "testpmd> ", 12= 0) > + self.vhost_user.send_expect("tso set 1448 0", "testpmd> ", 120) > + self.vhost_user.send_expect("port start 0", "testpmd> ", 120) > + self.vhost_user.send_expect("port start 1", "testpmd> ", 120) > + self.vhost_user.send_expect("start", "testpmd> ", 120) > + > + def testpmd_reset(self): > + self.vhost_user.send_expect("stop", "testpmd> ", 120) > + self.vhost_user.send_expect("port stop 1", "testpmd> ", 120) > + self.vhost_user.send_expect("csum set ip sw 1", "testpmd> ", 120= ) > + self.vhost_user.send_expect("port start 1", "testpmd> ", 120) > + self.vhost_user.send_expect("start", "testpmd> ", 120) > + > + def prepare_tap_device(self): > + self.dut.send_expect("ifconfig tap0 up", "#") > + self.dut.send_expect("ifconfig tap0 1.1.1.2", "#") > + > def test_vhost_gso_dpdk_tcp(self): > """ > DPDK GSO test with tcp traffic > """ > # Config the NIC which will be assigned to another namespace > + self.type_row =3D "gso" > self.config_kernel_nic_host() > self.launch_testpmd_gso_on(0) > self.start_vm(0) > @@ -323,6 +372,7 @@ class TestDPDKGsoLib(TestCase): > DPDK GSO test with udp traffic > """ > # Config the NIC which will be assigned to another namespace > + self.type_row =3D "gso" > self.config_kernel_nic_host() > self.launch_testpmd_gso_on(1) > self.start_vm(0) > @@ -352,6 +402,7 @@ class TestDPDKGsoLib(TestCase): > self.dut.send_expect("killall -s INT qemu-system-x86_64", "#") >=20 > def test_vhost_tso_dpdk(self): > + self.type_row =3D "gso" > self.config_kernel_nic_host() > self.launch_testpmd_gso_on(3) > self.start_vm(0) > @@ -387,6 +438,7 @@ class TestDPDKGsoLib(TestCase): > self.dut.send_expect("killall -s INT qemu-system-x86_64", "#") >=20 > def test_kernel_gso_dpdk(self): > + self.type_row =3D "gso" > self.config_kernel_nic_host() > self.launch_testpmd_gso_on(4) > self.start_vm(1) > @@ -423,6 +475,7 @@ class TestDPDKGsoLib(TestCase): > self.dut.send_expect("killall -s INT qemu-system-x86_64", "#") >=20 > def test_no_gso_dpdk(self): > + self.type_row =3D "gso" > self.config_kernel_nic_host() > self.launch_testpmd_gso_on(4) > self.start_vm(1) > @@ -461,6 +514,7 @@ class TestDPDKGsoLib(TestCase): > """ > Test Performance with GSO for VXLAN traffic > """ > + self.type_row =3D "gso" > self.config_kernel_nic_host_for_vxlan() > self.launch_testpmd_gso_on(2) > self.start_vm(2) > @@ -493,6 +547,7 @@ class TestDPDKGsoLib(TestCase): > """ > Test Performance with GSO for GRE traffic > """ > + self.type_row =3D "gso" > self.config_kernel_nic_host_for_gre() > self.launch_testpmd_gso_on(2) > self.start_vm(2) > @@ -520,6 +575,52 @@ class TestDPDKGsoLib(TestCase): > self.quit_testpmd() > self.dut.send_expect("killall -s INT qemu-system-x86_64", "#") >=20 > + def test_vhost_exception_path_TAP_original(self): > + self.type_row =3D "exception_path" > + self.config_kernel_nic_host_for_exception_path() > + self.launch_testpmd_exception_path() > + self.dut.get_session_output(timeout=3D2) > + time.sleep(5) > + # Get the virtio-net device name > + self.prepare_tap_device() > + self.testpmd_reset() > + self.dut.send_expect('ip netns exec ns1 iperf -s -i 1', '', 10) > + self.iperf =3D self.dut.new_session(suite=3D"iperf") > + self.iperf.send_expect('rm /root/iperf_client.log', '#', 10) > + self.iperf.send_expect('iperf -c 1.1.1.8 -i 1 -t 10 > /root/iper= f_client.log > &', '', 180) > + time.sleep(30) > + self.dut.send_expect('^C', '#', 10) > + self.iperf_result_verify(self.iperf) > + self.logger.info("TAP->virtio-user->Kernel_NIC %s " % > (self.output_result)) > + self.iperf.send_expect('rm /root/iperf_client.log', '#', 10) > + self.vhost_user.send_expect("quit", "#", 120) > + self.dut.close_session(self.vhost_user) > + self.dut.send_expect("ip netns del ns1", "#") > + self.dut.close_session(self.iperf) > + > + def test_vhost_exception_path_NIC_original(self): > + self.type_row =3D "exception_path" > + self.config_kernel_nic_host_for_exception_path() > + self.launch_testpmd_exception_path() > + time.sleep(5) > + self.dut.get_session_output(timeout=3D2) > + self.prepare_tap_device() > + self.testpmd_reset() > + self.iperf =3D self.dut.new_session(suite=3D"iperf") > + self.dut.send_expect('rm /root/iperf_client.log', '#', 10) > + self.iperf.send_expect('iperf -s -i 1', '', 180) > + self.dut.send_expect('ip netns exec ns1 iperf -c 1.1.1.2 -i 1 -t= 10 > > /root/iperf_client.log &', '', 10) > + time.sleep(30) > + self.iperf.send_expect('^C', '#', 10) > + self.iperf_result_verify(self.dut) > + self.dut.get_session_output(timeout=3D2) > + self.logger.info("Kernel_NIC<-virtio-user<-TAP %s " % > (self.output_result)) > + self.dut.send_expect('rm /root/iperf_client.log', '#', 10) > + self.vhost_user.send_expect("quit", "#", 120) > + self.dut.close_session(self.vhost_user) > + self.dut.send_expect("ip netns del ns1", "#") > + self.dut.close_session(self.iperf) > + > def tear_down(self): > """ > Run after each test case. > -- > 2.17.2