test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhao, HaiyangX" <haiyangx.zhao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>,
	"Zhao, HaiyangX" <haiyangx.zhao@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vf_rss: do special processing for NIC	sageville and sagepond
Date: Wed, 18 Sep 2019 10:25:25 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB23D23@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1567750602-10740-1-git-send-email-haiyangx.zhao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Friday, September 6, 2019 2:17 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>; Zhao, HaiyangX
> <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_rss: do special processing for NIC sageville
> and sagepond
> 
> *.NIC with kernel driver ixgbe only enable queue 0 and queue 1   in
>   vf rss as default.
> *.sageville and sagepond do not support sctp in vf rss.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_rss.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_rss.py b/tests/TestSuite_vf_rss.py index
> c41c932..8220926 100644
> --- a/tests/TestSuite_vf_rss.py
> +++ b/tests/TestSuite_vf_rss.py
> @@ -157,6 +157,9 @@ class TestVfRss(TestCase):
>          if not reta_entries:
>              # for test_vfpmd_rss, check every queue can receive packet.
>              for i in range(queue):
> +                if self.kdriver == 'ixgbe' and i > 1:
> +                    self.logger.info('NIC with kernel driver ixgbe only enable queue
> 0 and queue 1 as default')
> +                    break
>                  self.verify('RSS queue={}'.format(hex(i)) in out, 'queue {} did not
> receive packets'.format(i))
>              return
>          lines = out.split("\r\n")
> @@ -362,6 +365,9 @@ class TestVfRss(TestCase):
>                              "port config 0 rss reta (%d,%d)" % (i, reta_entries[i]),
> "testpmd> ")
>                      self.vm_dut_0.send_expect("port config all rss %s" % rss_type,
> "testpmd> ")
>                  elif self.kdriver == 'i40e' or self.nic in ['sageville', 'sagepond']:
> +                    if self.nic in ['sageville', 'sagepond'] and rss_type == 'sctp':
> +                        self.logger.info('sageville and sagepond do not support
> rsstype sctp')
> +                        continue
>                      for i in range(64):
>                          reta_entries.insert(i, random.randint(0, queue - 1))
>                          self.vm_dut_0.send_expect( @@ -407,6 +413,9 @@ class
> TestVfRss(TestCase):
>              for iptype, rsstype in iptypes.items():
>                  self.vm_dut_0.send_expect("set verbose 8", "testpmd> ")
>                  self.vm_dut_0.send_expect("set fwd rxonly", "testpmd> ")
> +                if self.nic in ['sageville', 'sagepond'] and rsstype == 'sctp':
> +                    self.logger.info('sageville and sagepond do not support rsstype
> sctp')
> +                    continue
>                  out = self.vm_dut_0.send_expect("port config all rss %s" % rsstype,
> "testpmd> ")
>                  self.verify("Operation not supported" not in out, "Operation not
> supported")
>                  self.vm_dut_0.send_expect(
> --
> 1.8.3.1


      reply	other threads:[~2019-09-18 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  6:16 Haiyang Zhao
2019-09-18 10:25 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB23D23@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=haiyangx.zhao@intel.com \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).