test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/ipgre: optimize script
Date: Wed, 18 Sep 2019 10:34:10 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB23DAF@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1567795350-70617-1-git-send-email-wenjiex.a.li@intel.com>

Applied failed, please rework it. thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Saturday, September 7, 2019 2:43 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/ipgre: optimize script
> 
> 1. could support cvl nic, add cvl to nic list 2. move dut.kill_all from
> tear_down_all to tear_down, since testpmd will be started in every case, if
> one case is failed, the testpmd is still runnning, this will affect the following
> cases.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_ipgre.py | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> 7fbddf1..e10b0e0 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -63,7 +63,7 @@ class TestIpgre(TestCase):
>          """
>          self.printFlag = self._enable_debug
>          ports = self.dut.get_ports()
> -        self.verify(self.nic in ["fortville_eagle", "fortville_spirit",
> "fortville_spirit_single", "fortville_25g", "carlsville"],
> +        self.verify(self.nic in ["fortville_eagle", "fortville_spirit",
> + "fortville_spirit_single", "fortville_25g", "carlsville",
> + "columbiaville_25g", "columbiaville_100g"],
>                      "GRE tunnel packet type only support by fortville and carlsville")
>          self.verify(len(ports) >= 1, "Insufficient ports for testing")
>          valports = [_ for _ in ports if self.tester.get_local_port(_) != -1] @@ -
> 439,12 +439,11 @@ class TestIpgre(TestCase):
>          Run after each test case.
>          Nothing to do.
>          """
> -        pass
> +        self.dut.kill_all()
> 
>      def tear_down_all(self):
>          """
>          Run after each test suite.
>          Nothing to do.
>          """
> -        self.dut.kill_all()
>          pass
> --
> 2.17.1


      parent reply	other threads:[~2019-09-18 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 18:42 Wenjie Li
2019-09-09  2:36 ` Zhang, YanX A
2019-09-18 10:34 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB23DAF@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).