From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6143A2EFC for ; Wed, 18 Sep 2019 12:34:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A10FF1C23D; Wed, 18 Sep 2019 12:34:14 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 189411C22E for ; Wed, 18 Sep 2019 12:34:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 03:34:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,520,1559545200"; d="scan'208";a="199008344" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 18 Sep 2019 03:34:12 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 03:34:11 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 18 Sep 2019 03:34:11 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 18 Sep 2019 03:34:11 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Wed, 18 Sep 2019 18:34:10 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] tests/ipgre: optimize script Thread-Index: AQHVZJh+Fr/mjHiRrkCkmgThCKghlacxT/UA Date: Wed, 18 Sep 2019 10:34:10 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB23DAF@SHSMSX101.ccr.corp.intel.com> References: <1567795350-70617-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1567795350-70617-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzIzMThjODMtODY2Yy00MzlhLWEzOTYtNDM1NmViNjM0ODM1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNTVjNks3QjFYNHJxU3Faa29MUVF4TVhcL0N1QmFDZVE0NnVoVWFOVFJqOG9KTmhuRk0xMERxVGlGUEFxWDcwUmEifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/ipgre: optimize script X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied failed, please rework it. thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li > Sent: Saturday, September 7, 2019 2:43 AM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts] [PATCH V1] tests/ipgre: optimize script >=20 > 1. could support cvl nic, add cvl to nic list 2. move dut.kill_all from > tear_down_all to tear_down, since testpmd will be started in every case, = if > one case is failed, the testpmd is still runnning, this will affect the f= ollowing > cases. >=20 > Signed-off-by: Wenjie Li > --- > tests/TestSuite_ipgre.py | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index > 7fbddf1..e10b0e0 100644 > --- a/tests/TestSuite_ipgre.py > +++ b/tests/TestSuite_ipgre.py > @@ -63,7 +63,7 @@ class TestIpgre(TestCase): > """ > self.printFlag =3D self._enable_debug > ports =3D self.dut.get_ports() > - self.verify(self.nic in ["fortville_eagle", "fortville_spirit", > "fortville_spirit_single", "fortville_25g", "carlsville"], > + self.verify(self.nic in ["fortville_eagle", "fortville_spirit", > + "fortville_spirit_single", "fortville_25g", "carlsville", > + "columbiaville_25g", "columbiaville_100g"], > "GRE tunnel packet type only support by fortville an= d carlsville") > self.verify(len(ports) >=3D 1, "Insufficient ports for testing") > valports =3D [_ for _ in ports if self.tester.get_local_port(_) = !=3D -1] @@ - > 439,12 +439,11 @@ class TestIpgre(TestCase): > Run after each test case. > Nothing to do. > """ > - pass > + self.dut.kill_all() >=20 > def tear_down_all(self): > """ > Run after each test suite. > Nothing to do. > """ > - self.dut.kill_all() > pass > -- > 2.17.1