test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "pvukkisala@marvell.com" <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
	"fmasood@marvell.com" <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] packet: Add support to send geneve packets from scapy
Date: Thu, 19 Sep 2019 07:22:34 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB242C0@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1568033946-31996-1-git-send-email-pvukkisala@marvell.com>

Reverted the patch, because most version of scapy not support GENEVE.
Must have version control to import GENEVE, otherwise a lot of failure will happen if the scapy not supporting it.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Monday, September 9, 2019 8:59 PM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] packet: Add support to send geneve packets from
> scapy
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  framework/packet.py |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/framework/packet.py b/framework/packet.py index
> 502d85c..ac8402d 100755
> --- a/framework/packet.py
> +++ b/framework/packet.py
> @@ -57,6 +57,7 @@ from scapy.route import *  from scapy.packet import
> bind_layers, Raw  from scapy.sendrecv import sendp  from scapy.arch import
> get_if_hwaddr
> +from scapy.contrib.geneve import GENEVE
>  from pexpect import pxssh
> 
>  # load extension layers
> @@ -145,7 +146,7 @@ class scapy(object):
>          'ipv6_in_ip': IP() / IPv6(src="::1"),
>          'ipv6_frag_in_ip': IP() / IPv6(src="::1", nh=44) / IPv6ExtHdrFragment(),
>          'nvgre': NVGRE(),
> -        'geneve': "Not Implement",
> +        'geneve': GENEVE(),
>      }
> 
>      def __init__(self):
> @@ -555,6 +556,7 @@ class Packet(object):
>              'GRE': 'gre',
>              'VXLAN': 'vxlan',
>              'PKT': 'raw',
> +            'GENEVE': 'geneve',
>          }
> 
>          layers = self.pkt_type.split('_')
> --
> 1.7.9.5


      parent reply	other threads:[~2019-09-19  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 12:59 pvukkisala
2019-09-18 10:35 ` Tu, Lijuan
2019-09-19  7:22 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB242C0@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).