test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Wang, Yinan" <yinan.wang@intel.com>,
	"Ma, LihongX" <lihongx.ma@intel.com>
Cc: "Mo, YufengX" <yufengx.mo@intel.com>
Subject: Re: [dts] [PATCH V1 1/1] tests/pvp_share_lib: fix condition check	sequence issue
Date: Fri, 20 Sep 2019 06:21:48 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB24B3E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190912075421.19400-2-yufengx.mo@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Thursday, September 12, 2019 3:54 PM
> To: dts@dpdk.org; Wang, Yinan <yinan.wang@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V1 1/1] tests/pvp_share_lib: fix condition check
> sequence issue
> 
> 
> fix condition check sequence issue.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_pvp_share_lib.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_share_lib.py
> b/tests/TestSuite_pvp_share_lib.py
> index f117fd5..77c1704 100644
> --- a/tests/TestSuite_pvp_share_lib.py
> +++ b/tests/TestSuite_pvp_share_lib.py
> @@ -46,12 +46,12 @@ class TestPVPShareLib(TestCase):
>          """
>          Run at the start of each test suite.
>          """
> -        self.core_config = "1S/4C/1T"
>          self.dut_ports = self.dut.get_ports()
> +        self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
> +        self.core_config = "1S/4C/1T"
>          self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
>          self.core_list = self.dut.get_core_list(
>              self.core_config, socket=self.ports_socket)
> -        self.verify(len(self.dut_ports) >= 1, "Insufficient ports for testing")
>          self.verify(len(self.core_list) >= 4,
>                      "There has not enought cores to test this suite %s" %
>                      self.suite_name)
> --
> 2.21.0


      parent reply	other threads:[~2019-09-20  6:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  7:54 [dts] [PATCH V1 0/1] " yufengmx
2019-09-12  7:54 ` [dts] [PATCH V1 1/1] " yufengmx
2019-09-16  1:40   ` Mo, YufengX
2019-09-20  6:21   ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB24B3E@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    --cc=yinan.wang@intel.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).