test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]tests/TestSuite_multicast: update to new packet api
Date: Tue, 22 Oct 2019 09:52:33 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB450F5@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1571297407-82596-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, October 17, 2019 3:30 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_multicast: update to new packet api
> 
> update case to invoke new api
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_multicast.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_multicast.py b/tests/TestSuite_multicast.py index
> bcdb0bc..b9dc4e8 100644
> --- a/tests/TestSuite_multicast.py
> +++ b/tests/TestSuite_multicast.py
> @@ -108,7 +108,7 @@ class TestMulticast(TestCase):
>                  for rx_port in trafficFlow[flow][1].split(","):
>                      sniff_src = "not 00:00:00:00:00:00"
> 
> -                    inst =
> self.tester.tcpdump_sniff_packets(intf=self.tester.get_interface(eval(rx_port)
> ), timeout=5,
> +                    inst =
> + self.tester.tcpdump_sniff_packets(intf=self.tester.get_interface(eval(
> + rx_port)),
>                          count=1, filters=[{"layer": "ether", "config": {"src": sniff_src}}] )
>                      dmac = self.dut.get_mac_address(TGs[int(trafficFlow[flow][0][2])])
> 
> @@ -119,8 +119,8 @@ class TestMulticast(TestCase):
>                      time.sleep(5)  # Wait for the sniffer to finish.
> 
>                      pkts = self.tester.load_tcpdump_sniff_packets(inst)
> -                    for packet in pkts:
> -                        result = str(packet.pktgen.pkt.show)
> +                    for i in range(len(pkts)):
> +                        result = str(pkts[i].show)
> 
>                          print result
>                          self.verify("Ether" in result, "No packet received")
> --
> 1.8.3.1


      reply	other threads:[~2019-10-22  9:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17  7:30 Xiao Qimai
2019-10-22  9:52 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB450F5@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).