test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1]tests/TestSuite_generic_flow_api: remove quotation marks in type value
@ 2019-10-17 11:12 Xiao Qimai
  2019-10-23  9:26 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Qimai @ 2019-10-17 11:12 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

type value has no quotation marks

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_generic_flow_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_generic_flow_api.py b/tests/TestSuite_generic_flow_api.py
index e0a4aa6..8d4aa73 100644
--- a/tests/TestSuite_generic_flow_api.py
+++ b/tests/TestSuite_generic_flow_api.py
@@ -813,7 +813,7 @@ class TestGeneric_flow_api(TestCase):
                 {'create': 'create', 'flows': ['ether', 'lldp'], 'actions': ['queue']},
             ]
             extrapkt_rulenum = self.all_flows_process(basic_flow_actions)
-            self.sendpkt(pktstr='Ether(dst="%s",type="0x88E5")/Raw("x" * 20)' % self.pf_mac)
+            self.sendpkt(pktstr='Ether(dst="%s",type=0x88E5)/Raw("x" * 20)' % self.pf_mac)
 
             self.verify_result("pf", expect_rxpkts="1", expect_queue="0", verify_mac=self.pf_mac)
             rule_num = extrapkt_rulenum['rulenum']
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_generic_flow_api: remove quotation marks in type value
  2019-10-17 11:12 [dts] [PATCH V1]tests/TestSuite_generic_flow_api: remove quotation marks in type value Xiao Qimai
@ 2019-10-23  9:26 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-10-23  9:26 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, October 17, 2019 7:13 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_generic_flow_api: remove
> quotation marks in type value
> 
> type value has no quotation marks
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_generic_flow_api.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_generic_flow_api.py
> b/tests/TestSuite_generic_flow_api.py
> index e0a4aa6..8d4aa73 100644
> --- a/tests/TestSuite_generic_flow_api.py
> +++ b/tests/TestSuite_generic_flow_api.py
> @@ -813,7 +813,7 @@ class TestGeneric_flow_api(TestCase):
>                  {'create': 'create', 'flows': ['ether', 'lldp'], 'actions': ['queue']},
>              ]
>              extrapkt_rulenum = self.all_flows_process(basic_flow_actions)
> -            self.sendpkt(pktstr='Ether(dst="%s",type="0x88E5")/Raw("x" * 20)' %
> self.pf_mac)
> +            self.sendpkt(pktstr='Ether(dst="%s",type=0x88E5)/Raw("x" * 20)' %
> self.pf_mac)
> 
>              self.verify_result("pf", expect_rxpkts="1", expect_queue="0",
> verify_mac=self.pf_mac)
>              rule_num = extrapkt_rulenum['rulenum']
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 11:12 [dts] [PATCH V1]tests/TestSuite_generic_flow_api: remove quotation marks in type value Xiao Qimai
2019-10-23  9:26 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox