test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/fdir: ensure port is up before send packets
  2019-10-18 17:00 [dts] [PATCH V1] tests/fdir: ensure port is up before send packets Wenjie Li
@ 2019-10-18  8:10 ` Li, WenjieX A
  2019-10-23  9:51 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Li, WenjieX A @ 2019-10-18  8:10 UTC (permalink / raw)
  To: dts; +Cc: Li, WenjieX A

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Saturday, October 19, 2019 1:01 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] tests/fdir: ensure port is up before send packets
> 
> ensure the port is up before send packets; if the port is down, wait for at most
> 15s, then return failure with 'link is down'.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_fdir.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py index
> 9f5a812..d74a06e 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -87,6 +87,11 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          """
>          self.scapyCmds.append(packet)
>          self.dut.send_expect("start", "testpmd>")
> +
> +        self.pmd_output = PmdOutput(self.dut)
> +        res = self.pmd_output.wait_link_status_up('all', timeout=15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          self.scapy_execute()
>          time.sleep(.5)
>          out = self.dut.get_session_output()
> --
> 2.17.1


[-- Attachment #2: TestFdir.log --]
[-- Type: application/octet-stream, Size: 944573 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/fdir: ensure port is up before send packets
@ 2019-10-18 17:00 Wenjie Li
  2019-10-18  8:10 ` Li, WenjieX A
  2019-10-23  9:51 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-10-18 17:00 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

ensure the port is up before send packets; if the port is down, wait for
at most 15s, then return failure with 'link is down'.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_fdir.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py
index 9f5a812..d74a06e 100644
--- a/tests/TestSuite_fdir.py
+++ b/tests/TestSuite_fdir.py
@@ -87,6 +87,11 @@ class TestFdir(TestCase, IxiaPacketGenerator):
         """
         self.scapyCmds.append(packet)
         self.dut.send_expect("start", "testpmd>")
+
+        self.pmd_output = PmdOutput(self.dut)
+        res = self.pmd_output.wait_link_status_up('all', timeout=15)
+        self.verify(res is True, 'there have port link is down')
+
         self.scapy_execute()
         time.sleep(.5)
         out = self.dut.get_session_output()
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/fdir: ensure port is up before send packets
  2019-10-18 17:00 [dts] [PATCH V1] tests/fdir: ensure port is up before send packets Wenjie Li
  2019-10-18  8:10 ` Li, WenjieX A
@ 2019-10-23  9:51 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-10-23  9:51 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Saturday, October 19, 2019 1:01 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/fdir: ensure port is up before send packets
> 
> ensure the port is up before send packets; if the port is down, wait for at
> most 15s, then return failure with 'link is down'.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_fdir.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/TestSuite_fdir.py b/tests/TestSuite_fdir.py index
> 9f5a812..d74a06e 100644
> --- a/tests/TestSuite_fdir.py
> +++ b/tests/TestSuite_fdir.py
> @@ -87,6 +87,11 @@ class TestFdir(TestCase, IxiaPacketGenerator):
>          """
>          self.scapyCmds.append(packet)
>          self.dut.send_expect("start", "testpmd>")
> +
> +        self.pmd_output = PmdOutput(self.dut)
> +        res = self.pmd_output.wait_link_status_up('all', timeout=15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          self.scapy_execute()
>          time.sleep(.5)
>          out = self.dut.get_session_output()
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 17:00 [dts] [PATCH V1] tests/fdir: ensure port is up before send packets Wenjie Li
2019-10-18  8:10 ` Li, WenjieX A
2019-10-23  9:51 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox