From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57630A3295 for ; Wed, 23 Oct 2019 11:52:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D3921BFF2; Wed, 23 Oct 2019 11:52:01 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 389591C02D for ; Wed, 23 Oct 2019 11:51:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 02:51:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,220,1569308400"; d="scan'208";a="397990228" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 23 Oct 2019 02:51:58 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 23 Oct 2019 02:51:58 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.166]) with mapi id 14.03.0439.000; Wed, 23 Oct 2019 17:51:56 +0800 From: "Tu, Lijuan" To: "pvukkisala@marvell.com" , "dts@dpdk.org" CC: "avijay@marvell.com" , "fmasood@marvell.com" Thread-Topic: [dts] [PATCH] shutdown_api: support vector mode to this test Thread-Index: AQHVhp467hTb08eoeky+zll/d/x9uqdoAb8g Date: Wed, 23 Oct 2019 09:51:55 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB45A3F@SHSMSX101.ccr.corp.intel.com> References: <1571504188-29749-1-git-send-email-pvukkisala@marvell.com> In-Reply-To: <1571504188-29749-1-git-send-email-pvukkisala@marvell.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjY4ZDMyZTEtODQ0NS00NzIyLTg5ODItMDY1ZThhNTc5Y2M2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMGFjbXVkaVJhWHo0ZVRIc3huUDFvWDNRQXcwRHJoMEtKRWtmVjZKQWtTdnlpUU5tWDhPWUVqYXpJYUhha3VKcyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] shutdown_api: support vector mode to this test X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of > pvukkisala@marvell.com > Sent: Sunday, October 20, 2019 12:56 AM > To: dts@dpdk.org > Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala > > Subject: [dts] [PATCH] shutdown_api: support vector mode to this test >=20 > From: Phanendra Vukkisala >=20 > Vector mode needs multiple of 4 packets > Make sure link is up at end of tests(even test fails) to avoid further te= sts > failure >=20 > Signed-off-by: Phanendra Vukkisala > --- > tests/TestSuite_shutdown_api.py | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py index 32bb765..d7f070f 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -116,7 +116,7 @@ class TestShutdownApi(TestCase): > pkg =3D 'Ether(src=3D"%s", dst=3D"%s")/IP()/Raw(load=3D"P" *= %d)' % (smac, > dmac, padding) >=20 > self.tester.scapy_foreground() > - self.tester.scapy_append('sendp(%s, iface=3D"%s")' % (pkg, itf)) > + self.tester.scapy_append('sendp(%s, iface=3D"%s", count=3D4)' % > + (pkg, itf)) > self.tester.scapy_execute() > time.sleep(3) >=20 > @@ -131,8 +131,8 @@ class TestShutdownApi(TestCase): > p1rx_pkts -=3D gp1rx_pkts > p1rx_bytes -=3D gp1rx_bytes >=20 > - rx_bytes_exp =3D pktSize > - tx_bytes_exp =3D pktSize > + rx_bytes_exp =3D pktSize*4 > + tx_bytes_exp =3D pktSize*4 >=20 > if self.kdriver =3D=3D "fm10k": > # RRC will always strip rx/tx crc @@ -144,11 +144,11 @@ clas= s > TestShutdownApi(TestCase): > tx_bytes_exp -=3D 4 > else: > # some NIC will always include tx crc > - rx_bytes_exp -=3D 4 > - tx_bytes_exp -=3D 4 > + rx_bytes_exp -=3D 16 > + tx_bytes_exp -=3D 16 > if vlan_strip is True: > # vlan strip default is off > - tx_bytes_exp -=3D 4 > + tx_bytes_exp -=3D 16 >=20 > # fortville nic enable send lldp packet function when port setup > # now the tx-packets size is lldp_size(110) * n + forward packe = size @@ - > 548,6 +548,16 @@ class TestShutdownApi(TestCase): > Run after each test case. > """ > self.dut.kill_all() > + self.pmdout.start_testpmd("Default", "--portmask=3D%s --port- > topology=3Dloop" % utils.create_mask(self.ports), socket=3Dself.ports_soc= ket) > + ports_num =3D len(self.ports) > + # link up test, to avoid failing further tests if link was down > + for i in range(ports_num): > + ## sometimes output text messingup testpmd prompt so trimmed > prompt > + self.dut.send_expect("set link-up port %d" % i, ">") > + # start ports, to avodi failing further tests if ports are stope= d > + self.dut.send_expect("port start all", "testpmd> ", 100) > + self.dut.send_expect("quit", "# ") > + >=20 > def tear_down_all(self): > """ > -- > 1.7.9.5