test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "pvukkisala@marvell.com" <pvukkisala@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "avijay@marvell.com" <avijay@marvell.com>,
	"fmasood@marvell.com" <fmasood@marvell.com>
Subject: Re: [dts] [PATCH] unit_tests_pmd_perf: Fix throwing error and exiting	app on failure
Date: Wed, 23 Oct 2019 09:52:12 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB45A67@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1571515466-4190-1-git-send-email-pvukkisala@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Sunday, October 20, 2019 4:04 AM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] unit_tests_pmd_perf: Fix throwing error and exiting
> app on failure
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_unit_tests_pmd_perf.py |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_unit_tests_pmd_perf.py
> b/tests/TestSuite_unit_tests_pmd_perf.py
> index ea221df..c9a18dc 100644
> --- a/tests/TestSuite_unit_tests_pmd_perf.py
> +++ b/tests/TestSuite_unit_tests_pmd_perf.py
> @@ -113,6 +113,7 @@ class TestUnitTestsPmdPerf(TestCase):
>              match_regex = "Result: (\d+) cycles per packet"
>              m = re.compile(r"%s" % match_regex, re.S)
>              result = m.search(out)
> +            self.verify(result, "Failed to get result")
>              self.logger.info("Mode %s latency is %s" % (mode, result.group(1)))
> 
>          self.dut.send_expect("quit", "# ") @@ -143,6 +144,7 @@ class
> TestUnitTestsPmdPerf(TestCase):
>                  match_regex = "Result: (\d+) cycles per packet"
>                  m = re.compile(r"%s" % match_regex, re.S)
>                  result = m.search(out)
> +                self.verify(result, "Failed to get result")
>                  table_row.append(result.group(1))
> 
>              self.dut.send_expect("quit", "# ") @@ -154,7 +156,7 @@ class
> TestUnitTestsPmdPerf(TestCase):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.dut.kill_all()
> 
>      def tear_down_all(self):
>          """
> --
> 1.7.9.5


      reply	other threads:[~2019-10-23  9:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 20:04 pvukkisala
2019-10-23  9:52 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB45A67@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).