test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] unit_tests_pmd_perf: Fix throwing error and exiting app on failure
@ 2019-10-19 20:04 pvukkisala
  2019-10-23  9:52 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: pvukkisala @ 2019-10-19 20:04 UTC (permalink / raw)
  To: dts; +Cc: avijay, fmasood, Phanendra Vukkisala

From: Phanendra Vukkisala <pvukkisala@marvell.com>

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
---
 tests/TestSuite_unit_tests_pmd_perf.py |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_unit_tests_pmd_perf.py b/tests/TestSuite_unit_tests_pmd_perf.py
index ea221df..c9a18dc 100644
--- a/tests/TestSuite_unit_tests_pmd_perf.py
+++ b/tests/TestSuite_unit_tests_pmd_perf.py
@@ -113,6 +113,7 @@ class TestUnitTestsPmdPerf(TestCase):
             match_regex = "Result: (\d+) cycles per packet"
             m = re.compile(r"%s" % match_regex, re.S)
             result = m.search(out)
+            self.verify(result, "Failed to get result")
             self.logger.info("Mode %s latency is %s" % (mode, result.group(1)))
 
         self.dut.send_expect("quit", "# ")
@@ -143,6 +144,7 @@ class TestUnitTestsPmdPerf(TestCase):
                 match_regex = "Result: (\d+) cycles per packet"
                 m = re.compile(r"%s" % match_regex, re.S)
                 result = m.search(out)
+                self.verify(result, "Failed to get result")
                 table_row.append(result.group(1))
 
             self.dut.send_expect("quit", "# ")
@@ -154,7 +156,7 @@ class TestUnitTestsPmdPerf(TestCase):
         """
         Run after each test case.
         """
-        pass
+        self.dut.kill_all()
 
     def tear_down_all(self):
         """
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] unit_tests_pmd_perf: Fix throwing error and exiting app on failure
  2019-10-19 20:04 [dts] [PATCH] unit_tests_pmd_perf: Fix throwing error and exiting app on failure pvukkisala
@ 2019-10-23  9:52 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-10-23  9:52 UTC (permalink / raw)
  To: pvukkisala, dts; +Cc: avijay, fmasood

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> pvukkisala@marvell.com
> Sent: Sunday, October 20, 2019 4:04 AM
> To: dts@dpdk.org
> Cc: avijay@marvell.com; fmasood@marvell.com; Phanendra Vukkisala
> <pvukkisala@marvell.com>
> Subject: [dts] [PATCH] unit_tests_pmd_perf: Fix throwing error and exiting
> app on failure
> 
> From: Phanendra Vukkisala <pvukkisala@marvell.com>
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> ---
>  tests/TestSuite_unit_tests_pmd_perf.py |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_unit_tests_pmd_perf.py
> b/tests/TestSuite_unit_tests_pmd_perf.py
> index ea221df..c9a18dc 100644
> --- a/tests/TestSuite_unit_tests_pmd_perf.py
> +++ b/tests/TestSuite_unit_tests_pmd_perf.py
> @@ -113,6 +113,7 @@ class TestUnitTestsPmdPerf(TestCase):
>              match_regex = "Result: (\d+) cycles per packet"
>              m = re.compile(r"%s" % match_regex, re.S)
>              result = m.search(out)
> +            self.verify(result, "Failed to get result")
>              self.logger.info("Mode %s latency is %s" % (mode, result.group(1)))
> 
>          self.dut.send_expect("quit", "# ") @@ -143,6 +144,7 @@ class
> TestUnitTestsPmdPerf(TestCase):
>                  match_regex = "Result: (\d+) cycles per packet"
>                  m = re.compile(r"%s" % match_regex, re.S)
>                  result = m.search(out)
> +                self.verify(result, "Failed to get result")
>                  table_row.append(result.group(1))
> 
>              self.dut.send_expect("quit", "# ") @@ -154,7 +156,7 @@ class
> TestUnitTestsPmdPerf(TestCase):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.dut.kill_all()
> 
>      def tear_down_all(self):
>          """
> --
> 1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-19 20:04 [dts] [PATCH] unit_tests_pmd_perf: Fix throwing error and exiting app on failure pvukkisala
2019-10-23  9:52 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox