test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked issue.
@ 2019-10-24  5:35 zhu,shuai
  2019-10-24  6:36 ` Wang, Yinan
  2019-11-04  2:46 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: zhu,shuai @ 2019-10-24  5:35 UTC (permalink / raw)
  To: dts; +Cc: yinan.wang, zhu,shuai

Modify the code due to dpdk changes.(commit id:f430bbcecf3eed93916f45654f51dd19d6955aa2)

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_vhost_virtio_user_interrupt.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py b/tests/TestSuite_vhost_virtio_user_interrupt.py
index 5422e04..91edcce 100644
--- a/tests/TestSuite_vhost_virtio_user_interrupt.py
+++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
@@ -84,6 +84,10 @@ class TestVirtioUserInterrupt(TestCase):
         self.dut.send_expect("cp ./examples/l3fwd-power/main.c .", "#")
         self.dut.send_expect(
                 "sed -i '/DEV_RX_OFFLOAD_CHECKSUM/d' ./examples/l3fwd-power/main.c", "#", 10)
+        self.dut.send_expect(
+                "sed -i '/if (promiscuous_on/i\#if 0' ./examples/l3fwd-power/main.c", "#", 10)
+        self.dut.send_expect(
+                "sed -i '/rte_spinlock_init(&(locks/i\#endif' ./examples/l3fwd-power/main.c", "#", 10)
         out = self.dut.build_dpdk_apps("./examples/l3fwd-power")
         self.verify("Error" not in out, "compilation l3fwd-power error")
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked issue.
  2019-10-24  5:35 [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked issue zhu,shuai
@ 2019-10-24  6:36 ` Wang, Yinan
  2019-11-04  2:46 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Wang, Yinan @ 2019-10-24  6:36 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: Zhu, ShuaiX
> Sent: 2019^[$BG/^[(B10^[$B7n^[(B24^[$BF|^[(B 13:36
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts][PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked
> issue.
> 
> Modify the code due to dpdk changes.(commit
> id:f430bbcecf3eed93916f45654f51dd19d6955aa2)
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vhost_virtio_user_interrupt.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> b/tests/TestSuite_vhost_virtio_user_interrupt.py
> index 5422e04..91edcce 100644
> --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> @@ -84,6 +84,10 @@ class TestVirtioUserInterrupt(TestCase):
>          self.dut.send_expect("cp ./examples/l3fwd-power/main.c .", "#")
>          self.dut.send_expect(
>                  "sed -i
> '/DEV_RX_OFFLOAD_CHECKSUM/d' ./examples/l3fwd-power/main.c", "#", 10)
> +        self.dut.send_expect(
> +                "sed -i '/if (promiscuous_on/i\#if
> 0' ./examples/l3fwd-power/main.c", "#", 10)
> +        self.dut.send_expect(
> +                "sed -i
> '/rte_spinlock_init(&(locks/i\#endif' ./examples/l3fwd-power/main.c", "#", 10)
>          out = self.dut.build_dpdk_apps("./examples/l3fwd-power")
>          self.verify("Error" not in out, "compilation l3fwd-power error")
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked issue.
  2019-10-24  5:35 [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked issue zhu,shuai
  2019-10-24  6:36 ` Wang, Yinan
@ 2019-11-04  2:46 ` Tu, Lijuan
  2019-11-12 14:53   ` Wang, Yinan
  1 sibling, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2019-11-04  2:46 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Wang, Yinan, Zhu, ShuaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Thursday, October 24, 2019 1:36 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test
> caseblocked issue.
> 
> Modify the code due to dpdk changes.(commit
> id:f430bbcecf3eed93916f45654f51dd19d6955aa2)
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vhost_virtio_user_interrupt.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> b/tests/TestSuite_vhost_virtio_user_interrupt.py
> index 5422e04..91edcce 100644
> --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> @@ -84,6 +84,10 @@ class TestVirtioUserInterrupt(TestCase):
>          self.dut.send_expect("cp ./examples/l3fwd-power/main.c .", "#")
>          self.dut.send_expect(
>                  "sed -i '/DEV_RX_OFFLOAD_CHECKSUM/d' ./examples/l3fwd-
> power/main.c", "#", 10)
> +        self.dut.send_expect(
> +                "sed -i '/if (promiscuous_on/i\#if 0' ./examples/l3fwd-
> power/main.c", "#", 10)
> +        self.dut.send_expect(
> +                "sed -i '/rte_spinlock_init(&(locks/i\#endif' ./examples/l3fwd-
> power/main.c", "#", 10)
>          out = self.dut.build_dpdk_apps("./examples/l3fwd-power")
>          self.verify("Error" not in out, "compilation l3fwd-power error")
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked issue.
  2019-11-04  2:46 ` Tu, Lijuan
@ 2019-11-12 14:53   ` Wang, Yinan
  0 siblings, 0 replies; 4+ messages in thread
From: Wang, Yinan @ 2019-11-12 14:53 UTC (permalink / raw)
  To: Tu, Lijuan, Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

Hi shuai,

Could you please send another patch to rollback below patch, as developer will fix issue by another solution.

Br,
yinan

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: 2019^[$BG/^[(B11^[$B7n^[(B4^[$BF|^[(B 10:46
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: RE: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test
> caseblocked issue.
> 
> Applied, thanks
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> > Sent: Thursday, October 24, 2019 1:36 PM
> > To: dts@dpdk.org
> > Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> > <shuaix.zhu@intel.com>
> > Subject: [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test
> > caseblocked issue.
> >
> > Modify the code due to dpdk changes.(commit
> > id:f430bbcecf3eed93916f45654f51dd19d6955aa2)
> >
> > Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> > ---
> >  tests/TestSuite_vhost_virtio_user_interrupt.py | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> > b/tests/TestSuite_vhost_virtio_user_interrupt.py
> > index 5422e04..91edcce 100644
> > --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> > +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> > @@ -84,6 +84,10 @@ class TestVirtioUserInterrupt(TestCase):
> >          self.dut.send_expect("cp ./examples/l3fwd-power/main.c .", "#")
> >          self.dut.send_expect(
> >                  "sed -i '/DEV_RX_OFFLOAD_CHECKSUM/d'
> > ./examples/l3fwd- power/main.c", "#", 10)
> > +        self.dut.send_expect(
> > +                "sed -i '/if (promiscuous_on/i\#if 0'
> > + ./examples/l3fwd-
> > power/main.c", "#", 10)
> > +        self.dut.send_expect(
> > +                "sed -i '/rte_spinlock_init(&(locks/i\#endif'
> > + ./examples/l3fwd-
> > power/main.c", "#", 10)
> >          out = self.dut.build_dpdk_apps("./examples/l3fwd-power")
> >          self.verify("Error" not in out, "compilation l3fwd-power
> > error")
> >
> > --
> > 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24  5:35 [dts] [PATCH V2] tests/vhost_virtio_user_interrupt:fix test caseblocked issue zhu,shuai
2019-10-24  6:36 ` Wang, Yinan
2019-11-04  2:46 ` Tu, Lijuan
2019-11-12 14:53   ` Wang, Yinan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox