test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tear_down add self.dut.kill_all()
  2019-10-24 13:12 [dts] [PATCH V1] tear_down add self.dut.kill_all() Peng Zhihong
@ 2019-10-24  5:44 ` Xiao, QimaiX
  2019-11-04  2:52   ` Tu, Lijuan
  2019-10-24  8:19 ` He, Zhiwei
  2019-11-04  2:53 ` Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Xiao, QimaiX @ 2019-10-24  5:44 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

CVL not support some case of this suit lead testpmd can't quit normally. Add this to ensure testpmd process be killed before next case start. 

Tested-by:  Xiao Qimai <qimaix.xiao@intel.com>

Best Regards,
Xiao,Qimai


-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
Sent: Thursday, October 24, 2019 9:13 PM
To: dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: [dts] [PATCH V1] tear_down add self.dut.kill_all()

tear_down add self.dut.kill_all()

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_ipgre.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index 7258db5..c6bb380 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -459,6 +459,7 @@ class TestIpgre(TestCase):
         Run after each test case.
         Nothing to do.
         """
+        self.dut.kill_all()
         pass
 
     def tear_down_all(self):
--
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tear_down add self.dut.kill_all()
  2019-10-24 13:12 [dts] [PATCH V1] tear_down add self.dut.kill_all() Peng Zhihong
  2019-10-24  5:44 ` Xiao, QimaiX
@ 2019-10-24  8:19 ` He, Zhiwei
  2019-11-04  2:53 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: He, Zhiwei @ 2019-10-24  8:19 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Acked-by zhiwei <zhiwei.he@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
Sent: Thursday, October 24, 2019 9:13 PM
To: dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: [dts] [PATCH V1] tear_down add self.dut.kill_all()

tear_down add self.dut.kill_all()

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_ipgre.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index 7258db5..c6bb380 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -459,6 +459,7 @@ class TestIpgre(TestCase):
         Run after each test case.
         Nothing to do.
         """
+        self.dut.kill_all()
         pass
 
     def tear_down_all(self):
--
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1] tear_down add self.dut.kill_all()
@ 2019-10-24 13:12 Peng Zhihong
  2019-10-24  5:44 ` Xiao, QimaiX
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Peng Zhihong @ 2019-10-24 13:12 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

tear_down add self.dut.kill_all()

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_ipgre.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index 7258db5..c6bb380 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -459,6 +459,7 @@ class TestIpgre(TestCase):
         Run after each test case.
         Nothing to do.
         """
+        self.dut.kill_all()
         pass
 
     def tear_down_all(self):
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tear_down add self.dut.kill_all()
  2019-10-24  5:44 ` Xiao, QimaiX
@ 2019-11-04  2:52   ` Tu, Lijuan
  0 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2019-11-04  2:52 UTC (permalink / raw)
  To: Xiao, QimaiX, Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao, QimaiX
> Sent: Thursday, October 24, 2019 1:45 PM
> To: Peng, ZhihongX <zhihongx.peng@intel.com>; dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: Re: [dts] [PATCH V1] tear_down add self.dut.kill_all()
> 
> CVL not support some case of this suit lead testpmd can't quit normally. Add
> this to ensure testpmd process be killed before next case start.
> 
> Tested-by:  Xiao Qimai <qimaix.xiao@intel.com>
> 
> Best Regards,
> Xiao,Qimai
> 
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Thursday, October 24, 2019 9:13 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] tear_down add self.dut.kill_all()
> 
> tear_down add self.dut.kill_all()
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_ipgre.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> 7258db5..c6bb380 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -459,6 +459,7 @@ class TestIpgre(TestCase):
>          Run after each test case.
>          Nothing to do.
>          """
> +        self.dut.kill_all()
>          pass
> 
>      def tear_down_all(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tear_down add self.dut.kill_all()
  2019-10-24 13:12 [dts] [PATCH V1] tear_down add self.dut.kill_all() Peng Zhihong
  2019-10-24  5:44 ` Xiao, QimaiX
  2019-10-24  8:19 ` He, Zhiwei
@ 2019-11-04  2:53 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2019-11-04  2:53 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Thursday, October 24, 2019 9:13 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] tear_down add self.dut.kill_all()
> 
> tear_down add self.dut.kill_all()
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_ipgre.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> 7258db5..c6bb380 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -459,6 +459,7 @@ class TestIpgre(TestCase):
>          Run after each test case.
>          Nothing to do.
>          """
> +        self.dut.kill_all()
>          pass
> 
>      def tear_down_all(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 13:12 [dts] [PATCH V1] tear_down add self.dut.kill_all() Peng Zhihong
2019-10-24  5:44 ` Xiao, QimaiX
2019-11-04  2:52   ` Tu, Lijuan
2019-10-24  8:19 ` He, Zhiwei
2019-11-04  2:53 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox