test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/generic_filter: add timeout when quit testpmd
@ 2019-10-24 19:17 Xiaoxiao Zeng
  2019-11-04  2:56 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoxiao Zeng @ 2019-10-24 19:17 UTC (permalink / raw)
  To: dts; +Cc: Xiaoxiao Zeng

*.quit testpmd need more time to run.

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_generic_filter.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index 4f14fc1..3eb3123 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -237,7 +237,7 @@ class TestGeneric_filter(TestCase):
         out = self.dut.send_expect("stop", "testpmd> ")
 
         self.verify_result(out, tx_pkts="1", expect_queue="0")
-        self.dut.send_expect("quit", "#")
+        self.dut.send_expect("quit", "#", timeout=30)
 
     def test_priority_filter(self):
         """
@@ -364,7 +364,7 @@ class TestGeneric_filter(TestCase):
                 self.filter_send_packet("fivetuple")
                 out = self.dut.send_expect("stop", "testpmd> ")
                 self.verify_result(out, tx_pkts="1", expect_queue="0")
-            self.dut.send_expect("quit", "#")
+            self.dut.send_expect("quit", "#", timeout=30)
         else:
             self.verify(False, "%s nic not support syn filter" % self.nic)
 
@@ -761,7 +761,7 @@ class TestGeneric_filter(TestCase):
                 if int(cur_pkt) != frames_to_send:
                     packet_flag = 0
                     break
-            self.dut.send_expect("quit", "#")
+            self.dut.send_expect("quit", "#", timeout=30)
             self.dut.send_expect("sed -i -e 's/#define IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define IXGBE_NONE_MODE_TX_NB_QUEUES 64/' drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
             self.dut.build_install_dpdk(self.target)
             self.verify(set_filter_flag == 1, "set filters error")
-- 
2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/generic_filter: add timeout when quit testpmd
  2019-10-24 19:17 [dts] [PATCH V1] tests/generic_filter: add timeout when quit testpmd Xiaoxiao Zeng
@ 2019-11-04  2:56 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-11-04  2:56 UTC (permalink / raw)
  To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Friday, October 25, 2019 3:18 AM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/generic_filter: add timeout when quit
> testpmd
> 
> *.quit testpmd need more time to run.
> 
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_generic_filter.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index 4f14fc1..3eb3123 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -237,7 +237,7 @@ class TestGeneric_filter(TestCase):
>          out = self.dut.send_expect("stop", "testpmd> ")
> 
>          self.verify_result(out, tx_pkts="1", expect_queue="0")
> -        self.dut.send_expect("quit", "#")
> +        self.dut.send_expect("quit", "#", timeout=30)
> 
>      def test_priority_filter(self):
>          """
> @@ -364,7 +364,7 @@ class TestGeneric_filter(TestCase):
>                  self.filter_send_packet("fivetuple")
>                  out = self.dut.send_expect("stop", "testpmd> ")
>                  self.verify_result(out, tx_pkts="1", expect_queue="0")
> -            self.dut.send_expect("quit", "#")
> +            self.dut.send_expect("quit", "#", timeout=30)
>          else:
>              self.verify(False, "%s nic not support syn filter" % self.nic)
> 
> @@ -761,7 +761,7 @@ class TestGeneric_filter(TestCase):
>                  if int(cur_pkt) != frames_to_send:
>                      packet_flag = 0
>                      break
> -            self.dut.send_expect("quit", "#")
> +            self.dut.send_expect("quit", "#", timeout=30)
>              self.dut.send_expect("sed -i -e 's/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 128$/#define
> IXGBE_NONE_MODE_TX_NB_QUEUES 64/'
> drivers/net/ixgbe/ixgbe_ethdev.h", "# ",30)
>              self.dut.build_install_dpdk(self.target)
>              self.verify(set_filter_flag == 1, "set filters error")
> --
> 2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 19:17 [dts] [PATCH V1] tests/generic_filter: add timeout when quit testpmd Xiaoxiao Zeng
2019-11-04  2:56 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox