test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd
@ 2019-10-25  3:06 zhang,yan
  2019-10-25  3:08 ` Zhang, YanX A
  2019-11-04  3:09 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: zhang,yan @ 2019-10-25  3:06 UTC (permalink / raw)
  To: dts; +Cc: zhang,yan

Optimize the code to exit testpmd.

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index dd728d9..f88f914 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -174,7 +174,7 @@ class TestVfJumboFrame(TestCase):
 
         pkt = Packet(pkt_type='UDP', pkt_len=pktsize)
         pkt.config_layer('ether', {'dst': mac})
-        pkt.send_pkt(self.tester, tx_port=self.tester_intf)
+        pkt.send_pkt(self.tester, tx_port=self.tester_intf, timeout=30)
 
         time.sleep(1)
 
@@ -219,9 +219,6 @@ class TestVfJumboFrame(TestCase):
         self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
         self.jumboframes_send_packet(ETHER_STANDARD_MTU)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_normal_withjumbo(self):
         """
         When jumbo frame supported, this case is to verify that the normal size
@@ -240,9 +237,6 @@ class TestVfJumboFrame(TestCase):
         self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
         self.jumboframes_send_packet(ETHER_STANDARD_MTU)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_jumbo_nojumbo(self):
         """
         This case aims to test transmitting jumbo frame packet on testpmd without
@@ -269,9 +263,6 @@ class TestVfJumboFrame(TestCase):
         else:
             self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_jumbo_withjumbo(self):
         """
         When jumbo frame supported, this case is to verify that jumbo frame
@@ -291,9 +282,6 @@ class TestVfJumboFrame(TestCase):
         self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU - 1)
         self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_jumbo_overjumbo(self):
         """
         When the jubmo frame MTU set as 9000, this case is to verify that the
@@ -315,14 +303,12 @@ class TestVfJumboFrame(TestCase):
         else:
             self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU + 1, False)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def tear_down(self):
         """
         Run after each test case.
         """
-        pass
+        self.vm_testpmd.execute_cmd("stop")
+        self.vm_testpmd.quit()
 
     def tear_down_all(self):
         """
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd
  2019-10-25  3:06 [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd zhang,yan
@ 2019-10-25  3:08 ` Zhang, YanX A
  2019-11-04  3:09 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, YanX A @ 2019-10-25  3:08 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 3073 bytes --]

Tested-by:  Zhang, YanX A <yanx.a.zhang@intel.com>

-----Original Message-----
From: Zhang, YanX A 
Sent: Friday, October 25, 2019 11:07 AM
To: dts@dpdk.org
Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
Subject: [dts][PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd

Optimize the code to exit testpmd.

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index dd728d9..f88f914 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -174,7 +174,7 @@ class TestVfJumboFrame(TestCase):
 
         pkt = Packet(pkt_type='UDP', pkt_len=pktsize)
         pkt.config_layer('ether', {'dst': mac})
-        pkt.send_pkt(self.tester, tx_port=self.tester_intf)
+        pkt.send_pkt(self.tester, tx_port=self.tester_intf, timeout=30)
 
         time.sleep(1)
 
@@ -219,9 +219,6 @@ class TestVfJumboFrame(TestCase):
         self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
         self.jumboframes_send_packet(ETHER_STANDARD_MTU)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_normal_withjumbo(self):
         """
         When jumbo frame supported, this case is to verify that the normal size @@ -240,9 +237,6 @@ class TestVfJumboFrame(TestCase):
         self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
         self.jumboframes_send_packet(ETHER_STANDARD_MTU)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_jumbo_nojumbo(self):
         """
         This case aims to test transmitting jumbo frame packet on testpmd without @@ -269,9 +263,6 @@ class TestVfJumboFrame(TestCase):
         else:
             self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_jumbo_withjumbo(self):
         """
         When jumbo frame supported, this case is to verify that jumbo frame @@ -291,9 +282,6 @@ class TestVfJumboFrame(TestCase):
         self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU - 1)
         self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def test_vf_jumbo_overjumbo(self):
         """
         When the jubmo frame MTU set as 9000, this case is to verify that the @@ -315,14 +303,12 @@ class TestVfJumboFrame(TestCase):
         else:
             self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU + 1, False)
 
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.quit()
-
     def tear_down(self):
         """
         Run after each test case.
         """
-        pass
+        self.vm_testpmd.execute_cmd("stop")
+        self.vm_testpmd.quit()
 
     def tear_down_all(self):
         """
--
2.17.2


[-- Attachment #2: TestVfJumboFrame.log --]
[-- Type: application/octet-stream, Size: 92743 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd
  2019-10-25  3:06 [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd zhang,yan
  2019-10-25  3:08 ` Zhang, YanX A
@ 2019-11-04  3:09 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-04  3:09 UTC (permalink / raw)
  To: Zhang, YanX A, dts; +Cc: Zhang, YanX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Friday, October 25, 2019 11:07 AM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code
> to exit testpmd
> 
> Optimize the code to exit testpmd.
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_vf_jumboframe.py | 20 +++-----------------
>  1 file changed, 3 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_jumboframe.py
> b/tests/TestSuite_vf_jumboframe.py
> index dd728d9..f88f914 100644
> --- a/tests/TestSuite_vf_jumboframe.py
> +++ b/tests/TestSuite_vf_jumboframe.py
> @@ -174,7 +174,7 @@ class TestVfJumboFrame(TestCase):
> 
>          pkt = Packet(pkt_type='UDP', pkt_len=pktsize)
>          pkt.config_layer('ether', {'dst': mac})
> -        pkt.send_pkt(self.tester, tx_port=self.tester_intf)
> +        pkt.send_pkt(self.tester, tx_port=self.tester_intf, timeout=30)
> 
>          time.sleep(1)
> 
> @@ -219,9 +219,6 @@ class TestVfJumboFrame(TestCase):
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_normal_withjumbo(self):
>          """
>          When jumbo frame supported, this case is to verify that the normal size
> @@ -240,9 +237,6 @@ class TestVfJumboFrame(TestCase):
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
>          self.jumboframes_send_packet(ETHER_STANDARD_MTU)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_jumbo_nojumbo(self):
>          """
>          This case aims to test transmitting jumbo frame packet on testpmd
> without @@ -269,9 +263,6 @@ class TestVfJumboFrame(TestCase):
>          else:
>              self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_jumbo_withjumbo(self):
>          """
>          When jumbo frame supported, this case is to verify that jumbo frame
> @@ -291,9 +282,6 @@ class TestVfJumboFrame(TestCase):
>          self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU - 1)
>          self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def test_vf_jumbo_overjumbo(self):
>          """
>          When the jubmo frame MTU set as 9000, this case is to verify that the
> @@ -315,14 +303,12 @@ class TestVfJumboFrame(TestCase):
>          else:
>              self.jumboframes_send_packet(ETHER_JUMBO_FRAME_MTU + 1,
> False)
> 
> -        self.vm_testpmd.execute_cmd("stop")
> -        self.vm_testpmd.quit()
> -
>      def tear_down(self):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.vm_testpmd.execute_cmd("stop")
> +        self.vm_testpmd.quit()
> 
>      def tear_down_all(self):
>          """
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25  3:06 [dts] [PATCH V2] tests/TestSuite_vf_jumboframe:Optimize the code to exit testpmd zhang,yan
2019-10-25  3:08 ` Zhang, YanX A
2019-11-04  3:09 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox