test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Mei, JianweiX" <jianweix.mei@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Mei, JianweiX" <jianweix.mei@intel.com>
Subject: Re: [dts] [PATCH V1] tests/runtime_vf_queue_number: add case
Date: Mon, 4 Nov 2019 03:23:36 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB5D561@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1572350029-83187-1-git-send-email-jianweix.mei@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jianwei Mei
> Sent: Tuesday, October 29, 2019 7:54 PM
> To: dts@dpdk.org
> Cc: Mei, JianweiX <jianweix.mei@intel.com>
> Subject: [dts] [PATCH V1] tests/runtime_vf_queue_number: add case
> 
> add case,bug fixed on dpdk19.08 for set invalid VF queue number with
> testpmd function command.
> 
> Signed-off-by: Jianwei Mei <jianweix.mei@intel.com>
> ---
>  tests/TestSuite_runtime_vf_queue_number.py | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_runtime_vf_queue_number.py
> b/tests/TestSuite_runtime_vf_queue_number.py
> index 227d815..940e36a 100644
> --- a/tests/TestSuite_runtime_vf_queue_number.py
> +++ b/tests/TestSuite_runtime_vf_queue_number.py
> @@ -341,8 +341,21 @@ class TestRuntimeVfQn(TestCase):
>          Test case 6: set invalid VF queue number with testpmd function
> command
>          :return:
>          """
> -        # There is a bug of this test case, so the function hasn't been
> implemented.
> -        pass
> +        expect_str = ["Warning: Either rx or tx queues should be non zero",
> +                      "Fail: input rxq (17) can't be greater than max_rx_queues (16)
> of port 0",
> +                      "Fail: input txq (17) can't be greater than max_tx_queues (16) of
> port 0"]
> +        host_eal_param = '-w %s --file-prefix=test1 --socket-mem 1024,1024' %
> self.pf_pci
> +        self.host_testpmd.start_testpmd(self.pmdout.default_cores, param='',
> eal_param=host_eal_param)
> +        gest_eal_param = '-w %s --file-prefix=test2' %
> self.vm_dut_0.ports_info[0]['pci']
> +        self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> +        self.vm0_testpmd.start_testpmd(self.pmdout.default_cores,
> eal_param=gest_eal_param, param='')
> +        for invalid_qn in [0, 17]:
> +            self.vm0_testpmd.execute_cmd('port stop all')
> +            rxq_output = self.vm0_testpmd.execute_cmd('port config all rxq %d' %
> invalid_qn)
> +            txq_output = self.vm0_testpmd.execute_cmd('port config all txq %d' %
> invalid_qn)
> +            self.verify(rxq_output or txq_output in expect_str, "The output is not
> expect.")
> +            self.vm0_testpmd.execute_cmd('port start all')
> +        self.vm0_testpmd.execute_cmd('quit', '# ')
> 
>      def test_reserve_vf_qn(self):
>          """
> --
> 1.8.3.1


      parent reply	other threads:[~2019-11-04  3:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 11:53 Jianwei Mei
2019-10-29  5:31 ` Zhang, YanX A
2019-11-04  3:23 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB5D561@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=jianweix.mei@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).