test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
@ 2019-11-22  3:21 Peng Zhihong
  2019-11-22  5:26 ` Tu, Lijuan
  0 siblings, 1 reply; 6+ messages in thread
From: Peng Zhihong @ 2019-11-22  3:21 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 92724aa..743be63 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         # only detect physical link disconnect status
         verify_pass = True
         verify_msg = ''
-        if self.nic.startswith("fortville") == False or self.nic.startswith("columbiaville"):  
+        if self.nic.startswith("fortville") == False and self.nic.startswith("columbiaville") == False:  
             # check link status dump function
             for port in self.ports:
                 tester_port = self.tester.get_local_port(port)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
  2019-11-22  3:21 [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status Peng Zhihong
@ 2019-11-22  5:26 ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-11-22  5:26 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Please rework it:

Applying: tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
.git/rebase-apply/patch:14: trailing whitespace.
        if self.nic.startswith("fortville") == False and self.nic.startswith("columbiaville") == False:
warning: 1 line adds whitespace errors.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Friday, November 22, 2019 11:21 AM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do
> not check the nic status
> 
> tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 92724aa..743be63 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          # only detect physical link disconnect status
>          verify_pass = True
>          verify_msg = ''
> -        if self.nic.startswith("fortville") == False or
> self.nic.startswith("columbiaville"):
> +        if self.nic.startswith("fortville") == False and
> self.nic.startswith("columbiaville") == False:
>              # check link status dump function
>              for port in self.ports:
>                  tester_port = self.tester.get_local_port(port)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
  2019-11-22  5:38 Peng Zhihong
@ 2019-11-22  6:37 ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-11-22  6:37 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Friday, November 22, 2019 1:38 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do
> not check the nic status
> 
> tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 6e19888..e9b6ccf 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          # only detect physical link disconnect status
>          verify_pass = True
>          verify_msg = ''
> -        if self.nic.startswith("fortville") == False or
> self.nic.startswith("columbiaville"):
> +        if self.nic.startswith("fortville") == False and
> self.nic.startswith("columbiaville") == False:
>              # check link status dump function
>              for port in self.ports:
>                  tester_port = self.tester.get_local_port(port)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
@ 2019-11-22  5:38 Peng Zhihong
  2019-11-22  6:37 ` Tu, Lijuan
  0 siblings, 1 reply; 6+ messages in thread
From: Peng Zhihong @ 2019-11-22  5:38 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 6e19888..e9b6ccf 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         # only detect physical link disconnect status
         verify_pass = True
         verify_msg = ''
-        if self.nic.startswith("fortville") == False or self.nic.startswith("columbiaville"):  
+        if self.nic.startswith("fortville") == False and self.nic.startswith("columbiaville") == False:
             # check link status dump function
             for port in self.ports:
                 tester_port = self.tester.get_local_port(port)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
  2019-11-04  8:51 Peng Zhihong
@ 2019-11-22  3:07 ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-11-22  3:07 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Please rework, applied failed.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, November 4, 2019 4:52 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do
> not check the nic status
> 
> tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 116fd3a..743be63 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          # only detect physical link disconnect status
>          verify_pass = True
>          verify_msg = ''
> -        if self.nic.startswith("fortville") == False:
> +        if self.nic.startswith("fortville") == False and
> self.nic.startswith("columbiaville") == False:
>              # check link status dump function
>              for port in self.ports:
>                  tester_port = self.tester.get_local_port(port)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status
@ 2019-11-04  8:51 Peng Zhihong
  2019-11-22  3:07 ` Tu, Lijuan
  0 siblings, 1 reply; 6+ messages in thread
From: Peng Zhihong @ 2019-11-04  8:51 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 116fd3a..743be63 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         # only detect physical link disconnect status
         verify_pass = True
         verify_msg = ''
-        if self.nic.startswith("fortville") == False:  
+        if self.nic.startswith("fortville") == False and self.nic.startswith("columbiaville") == False:  
             # check link status dump function
             for port in self.ports:
                 tester_port = self.tester.get_local_port(port)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22  3:21 [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status Peng Zhihong
2019-11-22  5:26 ` Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2019-11-22  5:38 Peng Zhihong
2019-11-22  6:37 ` Tu, Lijuan
2019-11-04  8:51 Peng Zhihong
2019-11-22  3:07 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox