From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0E86A04C1; Fri, 22 Nov 2019 06:26:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFFCC2C28; Fri, 22 Nov 2019 06:26:09 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 03C7B2C23 for ; Fri, 22 Nov 2019 06:26:07 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 21:26:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="290554230" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 21 Nov 2019 21:26:05 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 21:26:06 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Nov 2019 21:26:05 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 21 Nov 2019 21:26:05 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0439.000; Fri, 22 Nov 2019 13:26:04 +0800 From: "Tu, Lijuan" To: "Peng, ZhihongX" , "dts@dpdk.org" CC: "Peng, ZhihongX" Thread-Topic: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status Thread-Index: AQHVoOUKCUxr1Poup0m2YUBrUbOhyqeWqNRQ Date: Fri, 22 Nov 2019 05:26:03 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB67638@SHSMSX101.ccr.corp.intel.com> References: <20191122032120.5704-1-zhihongx.peng@intel.com> In-Reply-To: <20191122032120.5704-1-zhihongx.peng@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY5M2FiNGEtZTJmYS00MGY1LTk5NWUtZmU1MDVjN2E5MzA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSlFkUmpCeG1RUW1weFpGanM3TThwRjZ4QW1PMlVZYXR5SHlxTkIrOFBKZW9oRnJEZjNaU0FyS2FFME9nYUphdyJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic status X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Please rework it: Applying: tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the= nic status .git/rebase-apply/patch:14: trailing whitespace. if self.nic.startswith("fortville") =3D=3D False and self.nic.start= swith("columbiaville") =3D=3D False: warning: 1 line adds whitespace errors. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong > Sent: Friday, November 22, 2019 11:21 AM > To: dts@dpdk.org > Cc: Peng, ZhihongX > Subject: [dts] [PATCH V1] tests/TestSuite_userspace_ethtool.py:Fvl and cv= l do > not check the nic status >=20 > tests/TestSuite_userspace_ethtool.py:Fvl and cvl do not check the nic sta= tus >=20 > Signed-off-by: Peng Zhihong > --- > tests/TestSuite_userspace_ethtool.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 92724aa..743be63 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > # only detect physical link disconnect status > verify_pass =3D True > verify_msg =3D '' > - if self.nic.startswith("fortville") =3D=3D False or > self.nic.startswith("columbiaville"): > + if self.nic.startswith("fortville") =3D=3D False and > self.nic.startswith("columbiaville") =3D=3D False: > # check link status dump function > for port in self.ports: > tester_port =3D self.tester.get_local_port(port) > -- > 2.17.1