test suite reviews and discussions
 help / color / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session	instead of creating a new session
Date: Fri, 22 Nov 2019 05:30:27 +0000
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB67677@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1573026037-87704-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Wednesday, November 6, 2019 3:41 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session
> instead of creating a new session
> 
> optimize scripts, use existed session to send command
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_telemetry.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py index
> c6e7e08..13a0729 100644
> --- a/tests/TestSuite_telemetry.py
> +++ b/tests/TestSuite_telemetry.py
> @@ -451,13 +451,12 @@ class TestTelemetry(TestCase):
>      def change_run_fileprefix(self, out):
>          self.get_file_prefix(out)
>          if self.file_prefix:
> -            self.dut_session2 = self.dut.new_session()
>              cmd1 = "sed -i
> 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.so
> cket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
>                  self.file_prefix, os.path.join(self.target_dir, 'usertools/dpdk-
> telemetry-client.py'))
> -            cmd = "sed -i
> 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.so
> cket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
> +            cmd2 = "sed -i
> + 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/se
> + lf.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g'
> + {1}".format(
>                  self.file_prefix, os.path.join(self.target_dir,
> 'dpdk_telemetry_client.py'))
> -            self.dut_session2.send_expect(cmd1, "# ", 3)
> -            self.dut_session2.send_expect(cmd, "# ", 3)
> +            self.d_a_console(cmd1)
> +            self.d_a_console(cmd2)
>              self.change_flag = True
> 
>      def verify_basic_script(self):
> --
> 1.8.3.1


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  7:40 Xiao Qimai
2019-11-22  5:30 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB67677@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox