test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session instead of creating a new session
@ 2019-11-06  7:40 Xiao Qimai
  2019-11-22  5:30 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Qimai @ 2019-11-06  7:40 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

optimize scripts, use existed session to send command

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_telemetry.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
index c6e7e08..13a0729 100644
--- a/tests/TestSuite_telemetry.py
+++ b/tests/TestSuite_telemetry.py
@@ -451,13 +451,12 @@ class TestTelemetry(TestCase):
     def change_run_fileprefix(self, out):
         self.get_file_prefix(out)
         if self.file_prefix:
-            self.dut_session2 = self.dut.new_session()
             cmd1 = "sed -i 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
                 self.file_prefix, os.path.join(self.target_dir, 'usertools/dpdk-telemetry-client.py'))
-            cmd = "sed -i 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
+            cmd2 = "sed -i 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
                 self.file_prefix, os.path.join(self.target_dir, 'dpdk_telemetry_client.py'))
-            self.dut_session2.send_expect(cmd1, "# ", 3)
-            self.dut_session2.send_expect(cmd, "# ", 3)
+            self.d_a_console(cmd1)
+            self.d_a_console(cmd2)
             self.change_flag = True
 
     def verify_basic_script(self):
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session instead of creating a new session
  2019-11-06  7:40 [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session instead of creating a new session Xiao Qimai
@ 2019-11-22  5:30 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-11-22  5:30 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Wednesday, November 6, 2019 3:41 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session
> instead of creating a new session
> 
> optimize scripts, use existed session to send command
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_telemetry.py | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py index
> c6e7e08..13a0729 100644
> --- a/tests/TestSuite_telemetry.py
> +++ b/tests/TestSuite_telemetry.py
> @@ -451,13 +451,12 @@ class TestTelemetry(TestCase):
>      def change_run_fileprefix(self, out):
>          self.get_file_prefix(out)
>          if self.file_prefix:
> -            self.dut_session2 = self.dut.new_session()
>              cmd1 = "sed -i
> 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.so
> cket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
>                  self.file_prefix, os.path.join(self.target_dir, 'usertools/dpdk-
> telemetry-client.py'))
> -            cmd = "sed -i
> 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/self.so
> cket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g' {1}".format(
> +            cmd2 = "sed -i
> + 's/self.socket.send_fd.connect(\"\/var\/run\/dpdk\/.*\/telemetry\")/se
> + lf.socket.send_fd.connect(\"\/var\/run\/dpdk\/{0}\/telemetry\")/g'
> + {1}".format(
>                  self.file_prefix, os.path.join(self.target_dir,
> 'dpdk_telemetry_client.py'))
> -            self.dut_session2.send_expect(cmd1, "# ", 3)
> -            self.dut_session2.send_expect(cmd, "# ", 3)
> +            self.d_a_console(cmd1)
> +            self.d_a_console(cmd2)
>              self.change_flag = True
> 
>      def verify_basic_script(self):
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06  7:40 [dts] [PATCH V1]tests/TestSuite_telemetry: use existed session instead of creating a new session Xiao Qimai
2019-11-22  5:30 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox