test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS.
@ 2019-11-06  3:07 zhu,shuai
  2019-11-12 14:56 ` Wang, Yinan
  2019-11-22  5:43 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: zhu,shuai @ 2019-11-06  3:07 UTC (permalink / raw)
  To: dts; +Cc: zhu,shuai

RSS is not support by virito device and will thus will return error configure device with RSS enabled. Need to disable RSS when configuring virtio device.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_vdev_primary_secondary.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vdev_primary_secondary.py b/tests/TestSuite_vdev_primary_secondary.py
index 8b7b899..e03d615 100644
--- a/tests/TestSuite_vdev_primary_secondary.py
+++ b/tests/TestSuite_vdev_primary_secondary.py
@@ -118,14 +118,18 @@ class TestVdevPrimarySecondary(TestCase):
         example_cmd_secondary = "./examples/multi_process/symmetric_mp/build/symmetric_mp -l 1 -n %d --proc-type=secondary -- -p 3 --num-procs=%d --proc-id=1"
         final_cmd_first = example_cmd_auto % (self.mem_channels, self.queues)
         final_cmd_secondary = example_cmd_secondary % (self.mem_channels, self.queues)
-        self.vhost_first.send_expect(final_cmd_first, " ", 120)
-        self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120)
+        self.vhost_first.send_expect(final_cmd_first, "Lcore", 120)
+        time.sleep(3)
+        self.vhost_secondary.send_expect(final_cmd_secondary, "Lcore", 120)
 
 
     def prepare_symmetric_mp(self):
         self.vm_dut.send_expect("cp ./examples/multi_process/symmetric_mp/main.c .", "#")
         self.vm_dut.send_expect(
                 "sed -i '/.offloads = DEV_RX_OFFLOAD_CHECKSUM,/d' ./examples/multi_process/symmetric_mp/main.c", "#")
+        self.vm_dut.send_expect(
+                "sed -i 's/.mq_mode        = ETH_MQ_RX_RSS,/.mq_mode        = ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c", "#")
+        self.vm_dut.send_expect(
         out = self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp')
         self.verify("Error" not in out, "compilation symmetric_mp error")
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS.
  2019-11-06  3:07 [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS zhu,shuai
@ 2019-11-12 14:56 ` Wang, Yinan
  2019-11-22  5:43 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Wang, Yinan @ 2019-11-12 14:56 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of zhu,shuai
> Sent: 2019^[$BG/^[(B11^[$B7n^[(B6^[$BF|^[(B 11:08
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS.
> 
> RSS is not support by virito device and will thus will return error configure
> device with RSS enabled. Need to disable RSS when configuring virtio device.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vdev_primary_secondary.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vdev_primary_secondary.py
> b/tests/TestSuite_vdev_primary_secondary.py
> index 8b7b899..e03d615 100644
> --- a/tests/TestSuite_vdev_primary_secondary.py
> +++ b/tests/TestSuite_vdev_primary_secondary.py
> @@ -118,14 +118,18 @@ class TestVdevPrimarySecondary(TestCase):
>          example_cmd_secondary =
> "./examples/multi_process/symmetric_mp/build/symmetric_mp -l 1 -n %d
> --proc-type=secondary -- -p 3 --num-procs=%d --proc-id=1"
>          final_cmd_first = example_cmd_auto % (self.mem_channels,
> self.queues)
>          final_cmd_secondary = example_cmd_secondary %
> (self.mem_channels, self.queues)
> -        self.vhost_first.send_expect(final_cmd_first, " ", 120)
> -        self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120)
> +        self.vhost_first.send_expect(final_cmd_first, "Lcore", 120)
> +        time.sleep(3)
> +        self.vhost_secondary.send_expect(final_cmd_secondary, "Lcore",
> 120)
> 
> 
>      def prepare_symmetric_mp(self):
> 
> self.vm_dut.send_expect("cp ./examples/multi_process/symmetric_mp/main.c
>  .", "#")
>          self.vm_dut.send_expect(
>                  "sed -i '/.offloads =
> DEV_RX_OFFLOAD_CHECKSUM,/d' ./examples/multi_process/symmetric_mp/
> main.c", "#")
> +        self.vm_dut.send_expect(
> +                "sed -i 's/.mq_mode        =
> ETH_MQ_RX_RSS,/.mq_mode        =
> ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c", "#")
> +        self.vm_dut.send_expect(
>          out =
> self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp')
>          self.verify("Error" not in out, "compilation symmetric_mp error")
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS.
  2019-11-06  3:07 [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS zhu,shuai
  2019-11-12 14:56 ` Wang, Yinan
@ 2019-11-22  5:43 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-22  5:43 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Wednesday, November 6, 2019 11:08 AM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS.
> 
> RSS is not support by virito device and will thus will return error configure
> device with RSS enabled. Need to disable RSS when configuring virtio device.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vdev_primary_secondary.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vdev_primary_secondary.py
> b/tests/TestSuite_vdev_primary_secondary.py
> index 8b7b899..e03d615 100644
> --- a/tests/TestSuite_vdev_primary_secondary.py
> +++ b/tests/TestSuite_vdev_primary_secondary.py
> @@ -118,14 +118,18 @@ class TestVdevPrimarySecondary(TestCase):
>          example_cmd_secondary =
> "./examples/multi_process/symmetric_mp/build/symmetric_mp -l 1 -n %d --
> proc-type=secondary -- -p 3 --num-procs=%d --proc-id=1"
>          final_cmd_first = example_cmd_auto % (self.mem_channels,
> self.queues)
>          final_cmd_secondary = example_cmd_secondary % (self.mem_channels,
> self.queues)
> -        self.vhost_first.send_expect(final_cmd_first, " ", 120)
> -        self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120)
> +        self.vhost_first.send_expect(final_cmd_first, "Lcore", 120)
> +        time.sleep(3)
> +        self.vhost_secondary.send_expect(final_cmd_secondary, "Lcore", 120)
> 
> 
>      def prepare_symmetric_mp(self):
> 
> self.vm_dut.send_expect("cp ./examples/multi_process/symmetric_mp/mai
> n.c .", "#")
>          self.vm_dut.send_expect(
>                  "sed -i '/.offloads =
> DEV_RX_OFFLOAD_CHECKSUM,/d' ./examples/multi_process/symmetric_mp
> /main.c", "#")
> +        self.vm_dut.send_expect(
> +                "sed -i 's/.mq_mode        = ETH_MQ_RX_RSS,/.mq_mode        =
> ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c",
> "#")
> +        self.vm_dut.send_expect(
>          out =
> self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp')
>          self.verify("Error" not in out, "compilation symmetric_mp error")
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06  3:07 [dts] [PATCH V2] tests/vdev_primary_secondary:Disable RSS zhu,shuai
2019-11-12 14:56 ` Wang, Yinan
2019-11-22  5:43 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox