test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests: optimize three suites
  2019-11-11 17:18 [dts] [PATCH V1] tests: optimize three suites Wenjie Li
@ 2019-11-11  8:34 ` Li, WenjieX A
  2019-11-22  6:21 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Li, WenjieX A @ 2019-11-11  8:34 UTC (permalink / raw)
  To: dts; +Cc: Li, WenjieX A

[-- Attachment #1: Type: text/plain, Size: 4032 bytes --]

Tested-by: Li, WenjieX A <wenjiex.a.li@intel.com>

> -----Original Message-----
> From: Li, WenjieX A
> Sent: Tuesday, November 12, 2019 1:19 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts][PATCH V1] tests: optimize three suites
> 
> ensure the DUT port is up before the tester send packets in below suites:
>   tests/TestSuite_metering_and_policing.py
>   tests/TestSuite_short_live.py
>   tests/TestSuite_tx_preparation.py
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_metering_and_policing.py |  8 ++++++--
>  tests/TestSuite_short_live.py            | 12 ++++++++++++
>  tests/TestSuite_tx_preparation.py        |  5 +++++
>  3 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_metering_and_policing.py
> b/tests/TestSuite_metering_and_policing.py
> index 77da805..ef8c419 100644
> --- a/tests/TestSuite_metering_and_policing.py
> +++ b/tests/TestSuite_metering_and_policing.py
> @@ -42,7 +42,7 @@ from test_case import TestCase  from plotting import
> Plotting  from settings import HEADER_SIZE  from dut import Dut
> -
> +from pmd_output import PmdOutput
> 
>  class TestMeteringAndPolicing(TestCase):
>      scapyCmds = []
> @@ -244,7 +244,11 @@ class TestMeteringAndPolicing(TestCase):
>          """
>          Send packet and check the stats. If expect_port == -1, the packet should be
> dropped.
>          """
> -        time.sleep(3)
> +        # check the ports are UP before sending packets
> +        self.pmd_out = PmdOutput(self.dut)
> +        res = self.pmd_out.wait_link_status_up('all', 15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          rx_before = []
>          tx_before = []
>          for i in range(0, len(self.dut_ports)):
> diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py index
> 4e1ee15..dfccbd8 100644
> --- a/tests/TestSuite_short_live.py
> +++ b/tests/TestSuite_short_live.py
> @@ -141,6 +141,12 @@ class TestShortLiveApp(TestCase):
>          self.dut.send_expect("set fwd mac", "testpmd>")
>          self.dut.send_expect("set promisc all off", "testpmd>")
>          self.dut.send_expect("start", "testpmd>")
> +
> +        # check the ports are UP before sending packets
> +        self.pmd_out = PmdOutput(self.dut)
> +        res = self.pmd_out.wait_link_status_up('all', 15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          self.check_forwarding([0, 1], self.nic)
> 
>      def test_start_up_time(self):
> @@ -166,6 +172,12 @@ class TestShortLiveApp(TestCase):
>              self.dut.send_expect("set fwd mac", "testpmd>")
>              self.dut.send_expect("set promisc all off", "testpmd>")
>              self.dut.send_expect("start", "testpmd>")
> +
> +            # check the ports are UP before sending packets
> +            self.pmd_out = PmdOutput(self.dut)
> +            res = self.pmd_out.wait_link_status_up('all', 15)
> +            self.verify(res is True, 'there have port link is down')
> +
>              self.check_forwarding([0, 1], self.nic)
> 
>              # kill with different Signal diff --git a/tests/TestSuite_tx_preparation.py
> b/tests/TestSuite_tx_preparation.py
> index 366a547..90ab7b6 100644
> --- a/tests/TestSuite_tx_preparation.py
> +++ b/tests/TestSuite_tx_preparation.py
> @@ -116,6 +116,11 @@ class TestTX_preparation(TestCase):
>          """
>          Send packet to portid and output
>          """
> +        # check the ports are UP before sending packets
> +        self.pmd_out = PmdOutput(self.dut)
> +        res = self.pmd_out.wait_link_status_up('all', 15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          LrgLength = random.randint(Normal_mtu, Max_mtu-100)
>          pkts = {'IPv4/cksum TCP': 'Ether(dst="%s")/IP()/TCP(flags=0x10)\
>                      /Raw(RandString(50))' % self.dmac,
> --
> 2.17.1


[-- Attachment #2: TestMeteringAndPolicing.log --]
[-- Type: application/octet-stream, Size: 1172832 bytes --]

[-- Attachment #3: TestShortLiveApp.log --]
[-- Type: application/octet-stream, Size: 195175 bytes --]

[-- Attachment #4: TestTX_preparation.log --]
[-- Type: application/octet-stream, Size: 141679 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests: optimize three suites
@ 2019-11-11 17:18 Wenjie Li
  2019-11-11  8:34 ` Li, WenjieX A
  2019-11-22  6:21 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-11-11 17:18 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

ensure the DUT port is up before the tester send packets in below suites:
  tests/TestSuite_metering_and_policing.py
  tests/TestSuite_short_live.py
  tests/TestSuite_tx_preparation.py

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_metering_and_policing.py |  8 ++++++--
 tests/TestSuite_short_live.py            | 12 ++++++++++++
 tests/TestSuite_tx_preparation.py        |  5 +++++
 3 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_metering_and_policing.py b/tests/TestSuite_metering_and_policing.py
index 77da805..ef8c419 100644
--- a/tests/TestSuite_metering_and_policing.py
+++ b/tests/TestSuite_metering_and_policing.py
@@ -42,7 +42,7 @@ from test_case import TestCase
 from plotting import Plotting
 from settings import HEADER_SIZE
 from dut import Dut
-
+from pmd_output import PmdOutput
 
 class TestMeteringAndPolicing(TestCase):
     scapyCmds = []
@@ -244,7 +244,11 @@ class TestMeteringAndPolicing(TestCase):
         """
         Send packet and check the stats. If expect_port == -1, the packet should be dropped.
         """
-        time.sleep(3)
+        # check the ports are UP before sending packets
+        self.pmd_out = PmdOutput(self.dut)
+        res = self.pmd_out.wait_link_status_up('all', 15)
+        self.verify(res is True, 'there have port link is down')
+
         rx_before = []
         tx_before = []
         for i in range(0, len(self.dut_ports)):
diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
index 4e1ee15..dfccbd8 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -141,6 +141,12 @@ class TestShortLiveApp(TestCase):
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("set promisc all off", "testpmd>")
         self.dut.send_expect("start", "testpmd>")
+
+        # check the ports are UP before sending packets
+        self.pmd_out = PmdOutput(self.dut)
+        res = self.pmd_out.wait_link_status_up('all', 15)
+        self.verify(res is True, 'there have port link is down')
+
         self.check_forwarding([0, 1], self.nic)
 
     def test_start_up_time(self):
@@ -166,6 +172,12 @@ class TestShortLiveApp(TestCase):
             self.dut.send_expect("set fwd mac", "testpmd>")
             self.dut.send_expect("set promisc all off", "testpmd>")
             self.dut.send_expect("start", "testpmd>")
+
+            # check the ports are UP before sending packets
+            self.pmd_out = PmdOutput(self.dut)
+            res = self.pmd_out.wait_link_status_up('all', 15)
+            self.verify(res is True, 'there have port link is down')
+
             self.check_forwarding([0, 1], self.nic)
 
             # kill with different Signal
diff --git a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py
index 366a547..90ab7b6 100644
--- a/tests/TestSuite_tx_preparation.py
+++ b/tests/TestSuite_tx_preparation.py
@@ -116,6 +116,11 @@ class TestTX_preparation(TestCase):
         """
         Send packet to portid and output
         """
+        # check the ports are UP before sending packets
+        self.pmd_out = PmdOutput(self.dut)
+        res = self.pmd_out.wait_link_status_up('all', 15)
+        self.verify(res is True, 'there have port link is down')
+
         LrgLength = random.randint(Normal_mtu, Max_mtu-100)
         pkts = {'IPv4/cksum TCP': 'Ether(dst="%s")/IP()/TCP(flags=0x10)\
                     /Raw(RandString(50))' % self.dmac,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests: optimize three suites
  2019-11-11 17:18 [dts] [PATCH V1] tests: optimize three suites Wenjie Li
  2019-11-11  8:34 ` Li, WenjieX A
@ 2019-11-22  6:21 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-22  6:21 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied failed, please rework, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Tuesday, November 12, 2019 1:19 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests: optimize three suites
> 
> ensure the DUT port is up before the tester send packets in below suites:
>   tests/TestSuite_metering_and_policing.py
>   tests/TestSuite_short_live.py
>   tests/TestSuite_tx_preparation.py
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_metering_and_policing.py |  8 ++++++--
>  tests/TestSuite_short_live.py            | 12 ++++++++++++
>  tests/TestSuite_tx_preparation.py        |  5 +++++
>  3 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_metering_and_policing.py
> b/tests/TestSuite_metering_and_policing.py
> index 77da805..ef8c419 100644
> --- a/tests/TestSuite_metering_and_policing.py
> +++ b/tests/TestSuite_metering_and_policing.py
> @@ -42,7 +42,7 @@ from test_case import TestCase  from plotting import
> Plotting  from settings import HEADER_SIZE  from dut import Dut
> -
> +from pmd_output import PmdOutput
> 
>  class TestMeteringAndPolicing(TestCase):
>      scapyCmds = []
> @@ -244,7 +244,11 @@ class TestMeteringAndPolicing(TestCase):
>          """
>          Send packet and check the stats. If expect_port == -1, the packet should
> be dropped.
>          """
> -        time.sleep(3)
> +        # check the ports are UP before sending packets
> +        self.pmd_out = PmdOutput(self.dut)
> +        res = self.pmd_out.wait_link_status_up('all', 15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          rx_before = []
>          tx_before = []
>          for i in range(0, len(self.dut_ports)):
> diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py
> index 4e1ee15..dfccbd8 100644
> --- a/tests/TestSuite_short_live.py
> +++ b/tests/TestSuite_short_live.py
> @@ -141,6 +141,12 @@ class TestShortLiveApp(TestCase):
>          self.dut.send_expect("set fwd mac", "testpmd>")
>          self.dut.send_expect("set promisc all off", "testpmd>")
>          self.dut.send_expect("start", "testpmd>")
> +
> +        # check the ports are UP before sending packets
> +        self.pmd_out = PmdOutput(self.dut)
> +        res = self.pmd_out.wait_link_status_up('all', 15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          self.check_forwarding([0, 1], self.nic)
> 
>      def test_start_up_time(self):
> @@ -166,6 +172,12 @@ class TestShortLiveApp(TestCase):
>              self.dut.send_expect("set fwd mac", "testpmd>")
>              self.dut.send_expect("set promisc all off", "testpmd>")
>              self.dut.send_expect("start", "testpmd>")
> +
> +            # check the ports are UP before sending packets
> +            self.pmd_out = PmdOutput(self.dut)
> +            res = self.pmd_out.wait_link_status_up('all', 15)
> +            self.verify(res is True, 'there have port link is down')
> +
>              self.check_forwarding([0, 1], self.nic)
> 
>              # kill with different Signal diff --git
> a/tests/TestSuite_tx_preparation.py b/tests/TestSuite_tx_preparation.py
> index 366a547..90ab7b6 100644
> --- a/tests/TestSuite_tx_preparation.py
> +++ b/tests/TestSuite_tx_preparation.py
> @@ -116,6 +116,11 @@ class TestTX_preparation(TestCase):
>          """
>          Send packet to portid and output
>          """
> +        # check the ports are UP before sending packets
> +        self.pmd_out = PmdOutput(self.dut)
> +        res = self.pmd_out.wait_link_status_up('all', 15)
> +        self.verify(res is True, 'there have port link is down')
> +
>          LrgLength = random.randint(Normal_mtu, Max_mtu-100)
>          pkts = {'IPv4/cksum TCP': 'Ether(dst="%s")/IP()/TCP(flags=0x10)\
>                      /Raw(RandString(50))' % self.dmac,
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 17:18 [dts] [PATCH V1] tests: optimize three suites Wenjie Li
2019-11-11  8:34 ` Li, WenjieX A
2019-11-22  6:21 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox