test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add judgment range to suit CVL 100G
@ 2019-11-20 21:34 Xiaoxiao Zeng
  2019-11-22  6:32 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoxiao Zeng @ 2019-11-20 21:34 UTC (permalink / raw)
  To: dts; +Cc: Xiaoxiao Zeng

*.to suit CVL 100G.

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_shutdown_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 63fff84..f0a4eea 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -317,7 +317,7 @@ class TestShutdownApi(TestCase):
 
         out = self.tester.send_expect(
             "ethtool %s" % self.tester.get_interface(self.tester.get_local_port(self.ports[0])), "# ")
-        if 'fortville_spirit' == self.nic:
+        if 'fortville_spirit' == self.nic or 'columbiaville_100g' == self.nic:
             result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
         else:
             result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"
-- 
2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add judgment range to suit CVL 100G
  2019-11-20 21:34 [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add judgment range to suit CVL 100G Xiaoxiao Zeng
@ 2019-11-22  6:32 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-11-22  6:32 UTC (permalink / raw)
  To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX

Hi xiaoxiao,

It's not difficult to have regex to suit for both condition, could you please to optimize the regex, thanks

result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
> Sent: Thursday, November 21, 2019 5:35 AM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add
> judgment range to suit CVL 100G
> 
> *.to suit CVL 100G.
> 
> Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 63fff84..f0a4eea 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -317,7 +317,7 @@ class TestShutdownApi(TestCase):
> 
>          out = self.tester.send_expect(
>              "ethtool %s" %
> self.tester.get_interface(self.tester.get_local_port(self.ports[0])), "# ")
> -        if 'fortville_spirit' == self.nic:
> +        if 'fortville_spirit' == self.nic or 'columbiaville_100g' == self.nic:
>              result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
>          else:
>              result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"
> --
> 2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-20 21:34 [dts] [PATCH V1] tests/shutdown_api:test_change_linkspeed add judgment range to suit CVL 100G Xiaoxiao Zeng
2019-11-22  6:32 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox