From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BB99A04E0; Wed, 27 Nov 2019 10:02:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 418A05596; Wed, 27 Nov 2019 10:02:52 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 777BBCF3 for ; Wed, 27 Nov 2019 10:02:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 01:02:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,248,1571727600"; d="scan'208";a="292003211" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 27 Nov 2019 01:02:49 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 01:02:48 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 01:02:48 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000; Wed, 27 Nov 2019 17:02:46 +0800 From: "Tu, Lijuan" To: "Ma, LihongX" , "dts@dpdk.org" CC: "Ma, LihongX" Thread-Topic: [dts] [PATCH V2] tests: delete cmd about cd to absolute path Thread-Index: AQHVoNiocX/B+cFK50miXUcEvhNehaeewSTQ Date: Wed, 27 Nov 2019 09:02:46 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB695FF@SHSMSX101.ccr.corp.intel.com> References: <1574361287-4194-1-git-send-email-lihongx.ma@intel.com> In-Reply-To: <1574361287-4194-1-git-send-email-lihongx.ma@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjQ4ZmJiMTYtODY1OC00MGMwLTk1YmItYzIzYmJmYjg0ZTVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWjB3V3B1dlBuamo5TXlkRlBma1pJTzBMa0JFTzI0eWQzSnZLNTJudVlINThVclU3SXR2NndoQzZFTm03MUo3ayJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests: delete cmd about cd to absolute path X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong > Sent: Friday, November 22, 2019 2:35 AM > To: dts@dpdk.org > Cc: Ma, LihongX > Subject: [dts] [PATCH V2] tests: delete cmd about cd to absolute path >=20 > Signed-off-by: lihong > --- > tests/TestSuite_multiprocess.py | 1 - > tests/TestSuite_packet_capture.py | 4 +--- > tests/TestSuite_unit_tests_loopback.py | 18 +++++++++--------- > tests/TestSuite_vhost_user_live_migration.py | 1 - > 4 files changed, 10 insertions(+), 14 deletions(-) >=20 > diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiproce= ss.py > index 384872c..aa8bfde 100644 > --- a/tests/TestSuite_multiprocess.py > +++ b/tests/TestSuite_multiprocess.py > @@ -69,7 +69,6 @@ class TestMultiprocess(TestCase): > executions.append({'nprocs': 4, 'cores': '1S/2C/2T', 'pps': 0}) > executions.append({'nprocs': 4, 'cores': '1S/4C/1T', 'pps': 0}) > executions.append({'nprocs': 8, 'cores': '1S/4C/2T', 'pps': 0}) > - self.dut.alt_session.send_expect("cd dpdk", "# ", 5) >=20 > # start new session to run secondary > self.session_secondary =3D self.dut.new_session() diff --git > a/tests/TestSuite_packet_capture.py b/tests/TestSuite_packet_capture.py > index fdaa0d0..b1fbff4 100644 > --- a/tests/TestSuite_packet_capture.py > +++ b/tests/TestSuite_packet_capture.py > @@ -500,9 +500,7 @@ class TestPacketCapture(TestCase): > if not self.is_dut_on_tester: > self.tester.alt_session.send_expect( > "rm -fr {0}/*".format(self.pdump_log), "# ", 20) > - cmd =3D ';'.join([ > - "cd %s" % self.target_dir, > - self.dpdk_pdump + " '%s' >/dev/null 2>&1 &" % (option[0])]) > + cmd =3D self.dpdk_pdump + " '%s' >/dev/null 2>&1 &" % (option[0]= ) > self.session_ex.send_expect(cmd, "# ", 15) > time.sleep(6) >=20 > diff --git a/tests/TestSuite_unit_tests_loopback.py > b/tests/TestSuite_unit_tests_loopback.py > index 50533a6..b52b1c2 100644 > --- a/tests/TestSuite_unit_tests_loopback.py > +++ b/tests/TestSuite_unit_tests_loopback.py > @@ -91,9 +91,9 @@ class TestUnitTestsLoopback(TestCase): > Run pmd stream control mode burst test case. > """ > self.dut.send_expect("sed -i -e 's/lpbk_mode =3D 0/lpbk_mode =3D= 1/' > app/test/test_pmd_perf.c", "# ", 30) > - self.dut.send_expect("cd app/test", "# ") > - self.dut.send_expect("make -j", "# ", 120) > - self.dut.send_expect("cd /root/dpdk", "# ") > + out =3D self.dut.build_dpdk_apps('app/test') > + self.verify("Error" not in out, "Compilation error") > + self.verify("No such" not in out, "Compilation error") >=20 > self.tester.send_expect("rm -rf ./getPackageByTcpdump.cap", "#") > self.tester.send_expect("tcpdump -i %s -w ./getPackageByTcpdump.= cap > 2> /dev/null& " % self.tester_itf, "#") @@ -112,9 +112,9 @@ class > TestUnitTestsLoopback(TestCase): > Run pmd stream control mode burst test case. > """ > self.dut.send_expect("sed -i -e 's/lpbk_mode =3D 1/lpbk_mode =3D= 0/' > app/test/test_pmd_perf.c", "# ", 30) > - self.dut.send_expect("cd app/test", "# ") > - self.dut.send_expect("make -j", "# ", 120) > - self.dut.send_expect("cd /root/dpdk", "# ") > + out =3D self.dut.build_dpdk_apps('app/test') > + self.verify("Error" not in out, "Compilation error") > + self.verify("No such" not in out, "Compilation error") >=20 > self.tester.send_expect("rm -rf ./getPackageByTcpdump.cap", "#") > self.tester.send_expect("tcpdump -i %s -w ./getPackageByTcpdump.= cap > 2> /dev/null& " % self.tester_itf, "#") @@ -139,7 +139,7 @@ class > TestUnitTestsLoopback(TestCase): > """ > self.dut.send_expect("sed -i -e 's/lpbk_mode =3D 0/lpbk_mode =3D= 1/' > app/test/test_pmd_perf.c", "# ", 30) > self.dut.send_expect("sed -i -e 's/#define MAX_TRAFFIC_BURST > 32/#define MAX_TRAFFIC_BURST %s/' app/test/test_pmd_perf.c" = % > self.max_traffic_burst, "# ", 30) > - self.dut.send_expect("cd app/test", "# ") > - self.dut.send_expect("make -j", "# ", 120) > - self.dut.send_expect("cd /root/dpdk", "# ") > + out =3D self.dut.build_dpdk_apps('app/test') > + self.verify("Error" not in out, "Compilation error") > + self.verify("No such" not in out, "Compilation error") > self.dut.kill_all() > diff --git a/tests/TestSuite_vhost_user_live_migration.py > b/tests/TestSuite_vhost_user_live_migration.py > index 0b1abcc..521f3f5 100644 > --- a/tests/TestSuite_vhost_user_live_migration.py > +++ b/tests/TestSuite_vhost_user_live_migration.py > @@ -298,7 +298,6 @@ class TestVhostUserLiveMigration(TestCase): > vm_dut.send_expect('screen -S %s' % self.screen_name, '# ', 120) >=20 > vm_testpmd =3D self.target + '/app/testpmd -c 0x3 -n 4 -- -i' > - vm_dut.send_expect('cd %s' % self.base_dir, "# ") > vm_dut.send_expect(vm_testpmd, 'testpmd> ', 120) > vm_dut.send_expect('set fwd rxonly', 'testpmd> ', 30) > vm_dut.send_expect('set promisc all off', 'testpmd> ', 30) > -- > 2.7.4