test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
@ 2019-11-25  7:15 Xie Wei
  2019-11-25  8:02 ` Mo, YufengX
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Xie Wei @ 2019-11-25  7:15 UTC (permalink / raw)
  To: dts; +Cc: Xie Wei

modify command parameter

Signed-off-by: Xie Wei <weix.xie@intel.com>
---
 tests/TestSuite_eventdev_pipeline.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_eventdev_pipeline.py b/tests/TestSuite_eventdev_pipeline.py
index 1e99389..2fc2ded 100644
--- a/tests/TestSuite_eventdev_pipeline.py
+++ b/tests/TestSuite_eventdev_pipeline.py
@@ -95,7 +95,7 @@ class TestEventdevPipeline(TestCase):
         """
         run eventdev_pipeline command
         """
-        eal_params = self.dut.create_eal_parameters(cores=self.core_list,
+        eal_params = self.dut.create_eal_parameters(cores=self.self.core_config,
                     ports=[self.dut.ports_info[0]['pci']])
         command_line = "taskset -c %s " + self.app_command + \
                        "/build/app/eventdev_pipeline %s " + \
-- 
2.17.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
  2019-11-25  7:15 [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter Xie Wei
@ 2019-11-25  8:02 ` Mo, YufengX
  2019-11-27  9:19   ` Tu, Lijuan
  2019-11-26  5:18 ` Ma, LihongX
  2019-11-27  9:18 ` Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Mo, YufengX @ 2019-11-25  8:02 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

hi, xiewei

see below, you double write. self.self

BRs
Yufen, Mo

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
> Sent: Monday, November 25, 2019 3:15 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
> 
> modify command parameter
> 
> Signed-off-by: Xie Wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_eventdev_pipeline.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_eventdev_pipeline.py b/tests/TestSuite_eventdev_pipeline.py
> index 1e99389..2fc2ded 100644
> --- a/tests/TestSuite_eventdev_pipeline.py
> +++ b/tests/TestSuite_eventdev_pipeline.py
> @@ -95,7 +95,7 @@ class TestEventdevPipeline(TestCase):
>          """
>          run eventdev_pipeline command
>          """
> -        eal_params = self.dut.create_eal_parameters(cores=self.core_list,
> +        eal_params = self.dut.create_eal_parameters(cores=self.self.core_config,
[Mo, Yufen]  double write. self.self
>                      ports=[self.dut.ports_info[0]['pci']])
>          command_line = "taskset -c %s " + self.app_command + \
>                         "/build/app/eventdev_pipeline %s " + \
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
  2019-11-25  7:15 [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter Xie Wei
  2019-11-25  8:02 ` Mo, YufengX
@ 2019-11-26  5:18 ` Ma, LihongX
  2019-11-27  9:18 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Ma, LihongX @ 2019-11-26  5:18 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Hi, wei
I think we should optimization the dut code instead of change the suite code.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
Sent: Monday, November 25, 2019 3:15 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter

modify command parameter

Signed-off-by: Xie Wei <weix.xie@intel.com>
---
 tests/TestSuite_eventdev_pipeline.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_eventdev_pipeline.py b/tests/TestSuite_eventdev_pipeline.py
index 1e99389..2fc2ded 100644
--- a/tests/TestSuite_eventdev_pipeline.py
+++ b/tests/TestSuite_eventdev_pipeline.py
@@ -95,7 +95,7 @@ class TestEventdevPipeline(TestCase):
         """
         run eventdev_pipeline command
         """
-        eal_params = self.dut.create_eal_parameters(cores=self.core_list,
+        eal_params = self.dut.create_eal_parameters(cores=self.self.core_config,
                     ports=[self.dut.ports_info[0]['pci']])
         command_line = "taskset -c %s " + self.app_command + \
                        "/build/app/eventdev_pipeline %s " + \
-- 
2.17.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
  2019-11-25  7:15 [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter Xie Wei
  2019-11-25  8:02 ` Mo, YufengX
  2019-11-26  5:18 ` Ma, LihongX
@ 2019-11-27  9:18 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2019-11-27  9:18 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

self.self.core_config should be self.core_config

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
> Sent: Monday, November 25, 2019 3:15 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
> 
> modify command parameter
> 
> Signed-off-by: Xie Wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_eventdev_pipeline.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_eventdev_pipeline.py
> b/tests/TestSuite_eventdev_pipeline.py
> index 1e99389..2fc2ded 100644
> --- a/tests/TestSuite_eventdev_pipeline.py
> +++ b/tests/TestSuite_eventdev_pipeline.py
> @@ -95,7 +95,7 @@ class TestEventdevPipeline(TestCase):
>          """
>          run eventdev_pipeline command
>          """
> -        eal_params = self.dut.create_eal_parameters(cores=self.core_list,
> +        eal_params =
> self.dut.create_eal_parameters(cores=self.self.core_config,
>                      ports=[self.dut.ports_info[0]['pci']])
>          command_line = "taskset -c %s " + self.app_command + \
>                         "/build/app/eventdev_pipeline %s " + \
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
  2019-11-25  8:02 ` Mo, YufengX
@ 2019-11-27  9:19   ` Tu, Lijuan
  0 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2019-11-27  9:19 UTC (permalink / raw)
  To: Mo, YufengX, Xie, WeiX, dts; +Cc: Xie, WeiX

Thanks for your reviews.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Mo, YufengX
> Sent: Monday, November 25, 2019 4:03 PM
> To: Xie, WeiX <weix.xie@intel.com>; dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: Re: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
> 
> hi, xiewei
> 
> see below, you double write. self.self
> 
> BRs
> Yufen, Mo
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
> > Sent: Monday, November 25, 2019 3:15 PM
> > To: dts@dpdk.org
> > Cc: Xie, WeiX <weix.xie@intel.com>
> > Subject: [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter
> >
> > modify command parameter
> >
> > Signed-off-by: Xie Wei <weix.xie@intel.com>
> > ---
> >  tests/TestSuite_eventdev_pipeline.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_eventdev_pipeline.py
> b/tests/TestSuite_eventdev_pipeline.py
> > index 1e99389..2fc2ded 100644
> > --- a/tests/TestSuite_eventdev_pipeline.py
> > +++ b/tests/TestSuite_eventdev_pipeline.py
> > @@ -95,7 +95,7 @@ class TestEventdevPipeline(TestCase):
> >          """
> >          run eventdev_pipeline command
> >          """
> > -        eal_params = self.dut.create_eal_parameters(cores=self.core_list,
> > +        eal_params =
> self.dut.create_eal_parameters(cores=self.self.core_config,
> [Mo, Yufen]  double write. self.self
> >                      ports=[self.dut.ports_info[0]['pci']])
> >          command_line = "taskset -c %s " + self.app_command + \
> >                         "/build/app/eventdev_pipeline %s " + \
> > --
> > 2.17.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25  7:15 [dts] [PATCH V1] tests/eventdev_pipeline:modify parameter Xie Wei
2019-11-25  8:02 ` Mo, YufengX
2019-11-27  9:19   ` Tu, Lijuan
2019-11-26  5:18 ` Ma, LihongX
2019-11-27  9:18 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox