fix create_eal_parameters method Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com> --- framework/dut.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/framework/dut.py b/framework/dut.py index 4d8874a..f26b081 100644 --- a/framework/dut.py +++ b/framework/dut.py @@ -120,12 +120,13 @@ class Dut(Crb): if config: # deal with cores if config.has_key('cores'): - if config['cores'] == '' or config['cores'].lower() == 'default': - core_list = self.get_core_list(default_cores) - elif type(config['cores']) == list: + if type(config['cores']) == list: core_list = config['cores'] - else: - core_list = self.get_core_list(config['cores'], socket=socket) + elif isinstance(config['cores'], str): + if config['cores'] == '' or config['cores'].lower() == 'default': + core_list = self.get_core_list(default_cores) + else: + core_list = self.get_core_list(config['cores'], socket=socket) else: core_list = self.get_core_list(default_cores) -- 2.17.1
Reviewed-by:ma,lihong <lihongx.ma@intel.com> -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai Sent: Monday, November 25, 2019 5:33 PM To: dts@dpdk.org Cc: Xiao, QimaiX <qimaix.xiao@intel.com> Subject: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method fix create_eal_parameters method Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com> --- framework/dut.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/framework/dut.py b/framework/dut.py index 4d8874a..f26b081 100644 --- a/framework/dut.py +++ b/framework/dut.py @@ -120,12 +120,13 @@ class Dut(Crb): if config: # deal with cores if config.has_key('cores'): - if config['cores'] == '' or config['cores'].lower() == 'default': - core_list = self.get_core_list(default_cores) - elif type(config['cores']) == list: + if type(config['cores']) == list: core_list = config['cores'] - else: - core_list = self.get_core_list(config['cores'], socket=socket) + elif isinstance(config['cores'], str): + if config['cores'] == '' or config['cores'].lower() == 'default': + core_list = self.get_core_list(default_cores) + else: + core_list = self.get_core_list(config['cores'], + socket=socket) else: core_list = self.get_core_list(default_cores) -- 2.17.1
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Monday, November 25, 2019 5:33 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]framework/dut: fix create_eal_parameters method
>
> fix create_eal_parameters method
>
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
> framework/dut.py | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/framework/dut.py b/framework/dut.py index 4d8874a..f26b081
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -120,12 +120,13 @@ class Dut(Crb):
> if config:
> # deal with cores
> if config.has_key('cores'):
> - if config['cores'] == '' or config['cores'].lower() == 'default':
> - core_list = self.get_core_list(default_cores)
> - elif type(config['cores']) == list:
> + if type(config['cores']) == list:
> core_list = config['cores']
> - else:
> - core_list = self.get_core_list(config['cores'], socket=socket)
> + elif isinstance(config['cores'], str):
> + if config['cores'] == '' or config['cores'].lower() == 'default':
> + core_list = self.get_core_list(default_cores)
> + else:
> + core_list = self.get_core_list(config['cores'],
> + socket=socket)
> else:
> core_list = self.get_core_list(default_cores)
>
> --
> 2.17.1