test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "nareddy@marvell.com" <nareddy@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "pvukkisala@marvell.com" <pvukkisala@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_ipgre.py: cavium_a063 and cavium_a064	supports IPv4 GRE
Date: Fri, 20 Dec 2019 08:06:54 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB8A20E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1576665159-6699-1-git-send-email-nareddy@marvell.com>

applied

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Wednesday, December 18, 2019 6:33 PM
> To: dts@dpdk.org
> Cc: pvukkisala@marvell.com; Praneeth Reddy <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_ipgre.py: cavium_a063 and cavium_a064
> supports IPv4 GRE
> 
> From: Praneeth Reddy <nareddy@marvell.com>
> 
> Added support GRE for cavium_a063 and cavium_a064 Hardware vlan is not
> supported for cavium_a063 and cavium_a064 test_GRE_packet_filter is not
> supported by cavium_a063 and cavium_a064, added to checklist
> 
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  conf/test_case_checklist.json |  4 +-
>  tests/TestSuite_ipgre.py      | 91 ++++++++++++++++++++++++++++--------------
> -
>  2 files changed, 63 insertions(+), 32 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 38b1335..a42d1e7 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -2407,7 +2407,9 @@
>              ],
>              "NIC": [
>                  "columbiaville_25g",
> -                "columbiaville_100g"
> +                "columbiaville_100g",
> +                "cavium_a063",
> +                "cavium_a064"
>              ],
>              "Target": [
>                  "ALL"
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> c6bb380..71f26cd 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -65,8 +65,8 @@ class TestIpgre(TestCase):
>          ports = self.dut.get_ports()
>          self.verify(self.nic in ["fortville_eagle", "fortville_spirit",
>                                   "fortville_spirit_single", "fortville_25g", "carlsville",
> -                                 "columbiaville_25g", "columbiaville_100g"],
> -                    "GRE tunnel packet type only support by fortville and carlsville")
> +                                 "columbiaville_25g", "columbiaville_100g",
> "cavium_a063", "cavium_a064"],
> +                    "GRE tunnel packet type only support by fortville,
> + carlsville and cavium")
>          self.verify(len(ports) >= 1, "Insufficient ports for testing")
>          valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
>          # start testpmd
> @@ -189,14 +189,24 @@ class TestIpgre(TestCase):
>          Start testpmd and enable rxonly forwarding mode
>          Send packet as table listed and packet type match each layer
>          """
> -        pkt_types = {
> -            "MAC_IP_GRE_IPv4-TUNNEL_UDP_PKT":        ["TUNNEL_GRENAT",
> "INNER_L4_UDP"],
> -            "MAC_IP_GRE_IPv4-TUNNEL_TCP_PKT":        ["TUNNEL_GRENAT",
> "INNER_L4_TCP"],
> -            "MAC_IP_GRE_IPv4-TUNNEL_SCTP_PKT":       ["TUNNEL_GRENAT",
> "INNER_L4_SCTP"],
> -            "MAC_VLAN_IP_GRE_IPv4-TUNNEL_UDP_PKT":   ["TUNNEL_GRENAT",
> "INNER_L4_UDP"],
> -            "MAC_VLAN_IP_GRE_IPv4-TUNNEL_TCP_PKT":   ["TUNNEL_GRENAT",
> "INNER_L4_TCP"],
> -            "MAC_VLAN_IP_GRE_IPv4-TUNNEL_SCTP_PKT":  ["TUNNEL_GRENAT",
> "INNER_L4_SCTP"]
> -        }
> +        if (self.nic in ["cavium_a063", "cavium_a064"]):
> +            pkt_types = {
> +                "MAC_IP_GRE_IPv4-TUNNEL_UDP_PKT":        ["TUNNEL_GRE",
> "INNER_L4_UDP"],
> +                "MAC_IP_GRE_IPv4-TUNNEL_TCP_PKT":        ["TUNNEL_GRE",
> "INNER_L4_TCP"],
> +                "MAC_IP_GRE_IPv4-TUNNEL_SCTP_PKT":       ["TUNNEL_GRE",
> "INNER_L4_SCTP"],
> +                "MAC_VLAN_IP_GRE_IPv4-TUNNEL_UDP_PKT":   ["TUNNEL_GRE",
> "INNER_L4_UDP"],
> +                "MAC_VLAN_IP_GRE_IPv4-TUNNEL_TCP_PKT":   ["TUNNEL_GRE",
> "INNER_L4_TCP"],
> +                "MAC_VLAN_IP_GRE_IPv4-TUNNEL_SCTP_PKT":  ["TUNNEL_GRE",
> "INNER_L4_SCTP"]
> +            }
> +        else:
> +            pkt_types = {
> +                "MAC_IP_GRE_IPv4-TUNNEL_UDP_PKT":        ["TUNNEL_GRENAT",
> "INNER_L4_UDP"],
> +                "MAC_IP_GRE_IPv4-TUNNEL_TCP_PKT":        ["TUNNEL_GRENAT",
> "INNER_L4_TCP"],
> +                "MAC_IP_GRE_IPv4-TUNNEL_SCTP_PKT":       ["TUNNEL_GRENAT",
> "INNER_L4_SCTP"],
> +                "MAC_VLAN_IP_GRE_IPv4-TUNNEL_UDP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_UDP"],
> +                "MAC_VLAN_IP_GRE_IPv4-TUNNEL_TCP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_TCP"],
> +                "MAC_VLAN_IP_GRE_IPv4-TUNNEL_SCTP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_SCTP"]
> +            }
>          config_layers =  {'ether': {'src': self.outer_mac_src},
>                            'ipv4': {'proto': 'gre'}}
>          # Start testpmd and enable rxonly forwarding mode @@ -217,29
> +227,48 @@ class TestIpgre(TestCase):
>          Start testpmd and enable rxonly forwarding mode
>          Send packet as table listed and packet type match each layer
>          """
> -        pkt_types_ipv6_ip = {
> -            "MAC_IPv6_GRE_IPv4-TUNNEL_UDP_PKT":           ["TUNNEL_GRENAT",
> "INNER_L4_UDP"],
> -            "MAC_IPv6_GRE_IPv4-TUNNEL_TCP_PKT":           ["TUNNEL_GRENAT",
> "INNER_L4_TCP"],
> -            "MAC_IPv6_GRE_IPv4-TUNNEL_SCTP_PKT":          ["TUNNEL_GRENAT",
> "INNER_L4_SCTP"],
> -            "MAC_VLAN_IPv6_GRE_IPv4-TUNNEL_UDP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_UDP", "PKT_RX_VLAN"],
> -            "MAC_VLAN_IPv6_GRE_IPv4-TUNNEL_TCP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_TCP", "PKT_RX_VLAN"],
> -            "MAC_VLAN_IPv6_GRE_IPv4-TUNNEL_SCTP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_SCTP", "PKT_RX_VLAN"]
> -        }
> -
> -        pkt_types_ipv6_ipv6 = {
> -            "MAC_IPv6_GRE_IPv6-TUNNEL_UDP_PKT":         ["TUNNEL_GRENAT",
> "INNER_L4_UDP"],
> -            "MAC_IPv6_GRE_IPv6-TUNNEL_TCP_PKT":         ["TUNNEL_GRENAT",
> "INNER_L4_TCP"],
> -            "MAC_VLAN_IPv6_GRE_IPv6-TUNNEL_UDP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_UDP", "PKT_RX_VLAN"],
> -            "MAC_VLAN_IPv6_GRE_IPv6-TUNNEL_TCP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_TCP", "PKT_RX_VLAN"]
> -        }
> -
> -        pkt_types_ipv6_ipv6_SCTP = {
> -            "MAC_IPv6_GRE_IPv6-TUNNEL_SCTP_PKT":        ["TUNNEL_GRENAT",
> "INNER_L4_SCTP"],
> -            "MAC_VLAN_IPv6_GRE_IPv6-TUNNEL_SCTP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_SCTP", "PKT_RX_VLAN"]
> -        }
> +        if (self.nic in ["cavium_a063", "cavium_a064"]):
> +            pkt_types_ipv6_ip = {
> +                "MAC_IPv6_GRE_IPv4-TUNNEL_UDP_PKT":           ["TUNNEL_GRE",
> "INNER_L4_UDP"],
> +                "MAC_IPv6_GRE_IPv4-TUNNEL_TCP_PKT":           ["TUNNEL_GRE",
> "INNER_L4_TCP"],
> +                "MAC_IPv6_GRE_IPv4-TUNNEL_SCTP_PKT":          ["TUNNEL_GRE",
> "INNER_L4_SCTP"]
> +            }
> +
> +            pkt_types_ipv6_ipv6 = {
> +                "MAC_IPv6_GRE_IPv6-TUNNEL_UDP_PKT":         ["TUNNEL_GRE",
> "INNER_L4_UDP"],
> +                "MAC_IPv6_GRE_IPv6-TUNNEL_TCP_PKT":         ["TUNNEL_GRE",
> "INNER_L4_TCP"]
> +            }
> +
> +            pkt_types_ipv6_ipv6_SCTP = {
> +                "MAC_IPv6_GRE_IPv6-TUNNEL_SCTP_PKT":        ["TUNNEL_GRE",
> "INNER_L4_SCTP"]
> +            }
> +        else:
> +            pkt_types_ipv6_ip = {
> +                "MAC_IPv6_GRE_IPv4-TUNNEL_UDP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_UDP"],
> +                "MAC_IPv6_GRE_IPv4-TUNNEL_TCP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_TCP"],
> +                "MAC_IPv6_GRE_IPv4-TUNNEL_SCTP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_SCTP"],
> +                "MAC_VLAN_IPv6_GRE_IPv4-TUNNEL_UDP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_UDP", "PKT_RX_VLAN"],
> +                "MAC_VLAN_IPv6_GRE_IPv4-TUNNEL_TCP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_TCP", "PKT_RX_VLAN"],
> +                "MAC_VLAN_IPv6_GRE_IPv4-TUNNEL_SCTP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_SCTP", "PKT_RX_VLAN"]
> +            }
> +
> +            pkt_types_ipv6_ipv6 = {
> +                "MAC_IPv6_GRE_IPv6-TUNNEL_UDP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_UDP"],
> +                "MAC_IPv6_GRE_IPv6-TUNNEL_TCP_PKT":         ["TUNNEL_GRENAT",
> "INNER_L4_TCP"],
> +                "MAC_VLAN_IPv6_GRE_IPv6-TUNNEL_UDP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_UDP", "PKT_RX_VLAN"],
> +                "MAC_VLAN_IPv6_GRE_IPv6-TUNNEL_TCP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_TCP", "PKT_RX_VLAN"]
> +            }
> +
> +            pkt_types_ipv6_ipv6_SCTP = {
> +                "MAC_IPv6_GRE_IPv6-TUNNEL_SCTP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_SCTP"],
> +                "MAC_VLAN_IPv6_GRE_IPv6-TUNNEL_SCTP_PKT":
> ["TUNNEL_GRENAT", "INNER_L4_SCTP", "PKT_RX_VLAN"]
> +            }
> 
>          # Start testpmd and enable rxonly forwarding mode
> -        testpmd_cmd = "./%s/app/testpmd -c ffff -n 4 -- -i --enable-rx-cksum --
> enable-hw-vlan" % self.target
> +        if (self.nic in ["cavium_a063", "cavium_a064"]):
> +            testpmd_cmd = "./%s/app/testpmd -c ffff -n 4 -- -i --enable-rx-
> cksum" % self.target
> +        else:
> +            testpmd_cmd = "./%s/app/testpmd -c ffff -n 4 -- -i
> + --enable-rx-cksum --enable-hw-vlan" % self.target
>          self.dut.send_expect(testpmd_cmd, "testpmd>", 20)
>          self.dut.send_expect("set fwd rxonly", "testpmd>")
>          self.dut.send_expect("set verbose 1", "testpmd>")
> --
> 1.8.3.1


      reply	other threads:[~2019-12-20  8:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 10:32 nareddy
2019-12-20  8:06 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB8A20E@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=nareddy@marvell.com \
    --cc=pvukkisala@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).